[ http://jira.jboss.com/jira/browse/SECURITY-206?page=all ] Kevin Carlin updated SECURITY-206: ---------------------------------- Description: The constructor public Attribute(URI id, String issuer, DateTimeAttribute issueInstant, AttributeValue value) fails to set the attribute's type. Test case and patch below: JUnit test case. /** * */ package test.attributefinder; import static org.junit.Assert.*; import java.net.URI; import java.net.URISyntaxException; import org.jboss.security.xacml.sunxacml.attr.DateTimeAttribute; import org.jboss.security.xacml.sunxacml.attr.StringAttribute; import org.jboss.security.xacml.sunxacml.ctx.Attribute; import org.junit.Test; /** * @author kevincarlin * */ public class AttributeTest { /** * Test method for {@link org.jboss.security.xacml.sunxacml.ctx.Attribute#Attribute(java.net.URI, java.lang.String, org.jboss.security.xacml.sunxacml.attr.DateTimeAttribute, org.jboss.security.xacml.sunxacml.attr.AttributeValue)}. * @throws Throwable */ @Test public void testAttributeURIStringDateTimeAttributeAttributeValue() throws Throwable { Attribute attribute = new Attribute(new URI("urn:oasis:names:tc:xacml:1.0:resource:resource-id"), "com.bifrost.dnipilot", new DateTimeAttribute(), new StringAttribute("Test")); assertNotNull("Attribute type must be set in the constructor", attribute.getType()); } } Patch: Index: security-xacml/trunk/jboss-sunxacml/src/main/java/org/jboss/security/xacml/sunxacml/ctx/Attribute.java =================================================================== --- . (revision 72241) +++ . (working copy) @@ -99,6 +99,7 @@ if(this.attributeValues == null) this.attributeValues = new HashSet<AttributeValue>(); this.attributeValues.add(value); + this.type = value.getType(); } public Attribute(URI id, URI type, String issuer, DateTimeAttribute issueInstant, was: The constructor public Attribute(URI id, String issuer, DateTimeAttribute issueInstant, AttributeValue value) fails to set the attribute's type. Test case and patch below: JUnit test case. /** * */ package test.attributefinder; import static org.junit.Assert.*; import java.net.URI; import java.net.URISyntaxException; import org.jboss.security.xacml.sunxacml.attr.DateTimeAttribute; import org.jboss.security.xacml.sunxacml.attr.StringAttribute; import org.jboss.security.xacml.sunxacml.ctx.Attribute; import org.junit.Test; /** * @author kevincarlin * */ public class AttributeTest { /** * Test method for {@link org.jboss.security.xacml.sunxacml.ctx.Attribute#Attribute(java.net.URI, java.lang.String, org.jboss.security.xacml.sunxacml.attr.DateTimeAttribute, org.jboss.security.xacml.sunxacml.attr.AttributeValue)}. * @throws Throwable */ @Test public void testAttributeURIStringDateTimeAttributeAttributeValue() throws Throwable { Attribute attribute = new Attribute(new URI("urn:oasis:names:tc:xacml:1.0:resource:resource-id"), "com.enterra.dnipilot", new DateTimeAttribute(), new StringAttribute("Test")); assertNotNull("Attribute type must be set in the constructor", attribute.getType()); } } Patch: Index: security-xacml/trunk/jboss-sunxacml/src/main/java/org/jboss/security/xacml/sunxacml/ctx/Attribute.java =================================================================== --- . (revision 72241) +++ . (working copy) @@ -99,6 +99,7 @@ if(this.attributeValues == null) this.attributeValues = new HashSet<AttributeValue>(); this.attributeValues.add(value); + this.type = value.getType(); } public Attribute(URI id, URI type, String issuer, DateTimeAttribute issueInstant, -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/SECURITY-206?page=comments#action_12410789 ] Anil Saldhana commented on SECURITY-206: ---------------------------------------- Kevin, the sunxacml component is an internal implementation detail (subject to change of course in the life of JBossXACML as a project). We recommend (and certainly hope) that JBossXACML users will try to use the JBossXACML object model. But I will certainly fix what you have asked for. :) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/SECURITY-206?page=com.atlassian.jira.p... ] Anil Saldhana closed SECURITY-206. ---------------------------------- Resolution: Done Fixed in trunk and will be part of releases of 2.0.3 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/SECURITY-206?page=com.atlassian.jira.p... ] Anil Saldhana updated SECURITY-206: ----------------------------------- Fix Version/s: JBossXACML_2.0.3.alpha (was: 2.0.3.Beta1) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira