5:34 a.m.
Dominik Pospisil created AS7-3349:
-------------------------------------
Summary: Data-source add allows adding data sources with non existing JDBC
driver
Key: AS7-3349
URL: https://issues.jboss.org/browse/AS7-3349
Project: Application Server 7
Issue Type: Bug
Components: CLI, Domain Management
Affects Versions: 7.1.0.Final
Reporter: Dominik Pospisil
Assignee: Alexey Loubyansky
Data-source add allows adding data sources with non existing JDBC driver. The data-source
add command should warn / prevent user from doing such thing.
[standalone@localhost:9999 /] ls /subsystem=datasources/data-source
ExampleDS
[standalone@localhost:9999 /] data-source add --jndi-name=java:/TestDS
--connection-url=jdbc:postgresql://localhost/test --driver-name=NON_EXISTING_DRIVER
[standalone@localhost:9999 /] ls /subsystem=datasources/data-source
ExampleDS java:/TestDS
[standalone@localhost:9999 /]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:37 a.m.
[
https://issues.jboss.org/browse/AS7-3349?page=com.atlassian.jira.plugin.s...
]
Alexey Loubyansky commented on AS7-3349:
----------------------------------------
IMO, the add operation handler should validate attributes.
Data-source add allows adding data sources with non existing JDBC
driver
------------------------------------------------------------------------
Key: AS7-3349
URL: https://issues.jboss.org/browse/AS7-3349
Project: Application Server 7
Issue Type: Bug
Components: CLI, Domain Management
Affects Versions: 7.1.0.Final
Reporter: Dominik Pospisil
Assignee: Alexey Loubyansky
Data-source add allows adding data sources with non existing JDBC driver. The data-source
add command should warn / prevent user from doing such thing.
[standalone@localhost:9999 /] ls /subsystem=datasources/data-source
ExampleDS
[standalone@localhost:9999 /] data-source add --jndi-name=java:/TestDS
--connection-url=jdbc:postgresql://localhost/test --driver-name=NON_EXISTING_DRIVER
[standalone@localhost:9999 /] ls /subsystem=datasources/data-source
ExampleDS java:/TestDS
[standalone@localhost:9999 /]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:39 a.m.
[
https://issues.jboss.org/browse/AS7-3349?page=com.atlassian.jira.plugin.s...
]
Alexey Loubyansky reassigned AS7-3349:
--------------------------------------
Assignee: Stefano Maestri (was: Alexey Loubyansky)
Stefano, could you look into this issue, please?
Data-source add allows adding data sources with non existing JDBC
driver
------------------------------------------------------------------------
Key: AS7-3349
URL: https://issues.jboss.org/browse/AS7-3349
Project: Application Server 7
Issue Type: Bug
Components: CLI, Domain Management
Affects Versions: 7.1.0.Final
Reporter: Dominik Pospisil
Assignee: Stefano Maestri
Data-source add allows adding data sources with non existing JDBC driver. The data-source
add command should warn / prevent user from doing such thing.
[standalone@localhost:9999 /] ls /subsystem=datasources/data-source
ExampleDS
[standalone@localhost:9999 /] data-source add --jndi-name=java:/TestDS
--connection-url=jdbc:postgresql://localhost/test --driver-name=NON_EXISTING_DRIVER
[standalone@localhost:9999 /] ls /subsystem=datasources/data-source
ExampleDS java:/TestDS
[standalone@localhost:9999 /]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:40 p.m.
[
https://issues.jboss.org/browse/AS7-3349?page=com.atlassian.jira.plugin.s...
]
Rajesh Rajasekaran updated AS7-3349:
------------------------------------
Fix Version/s: 7.1.1.Final
Data-source add allows adding data sources with non existing JDBC
driver
------------------------------------------------------------------------
Key: AS7-3349
URL: https://issues.jboss.org/browse/AS7-3349
Project: Application Server 7
Issue Type: Bug
Components: CLI, Domain Management
Affects Versions: 7.1.0.Final
Reporter: Dominik Pospisil
Assignee: Stefano Maestri
Labels: eap6-ux
Fix For: 7.1.1.Final
Data-source add allows adding data sources with non existing JDBC driver. The data-source
add command should warn / prevent user from doing such thing.
[standalone@localhost:9999 /] ls /subsystem=datasources/data-source
ExampleDS
[standalone@localhost:9999 /] data-source add --jndi-name=java:/TestDS
--connection-url=jdbc:postgresql://localhost/test --driver-name=NON_EXISTING_DRIVER
[standalone@localhost:9999 /] ls /subsystem=datasources/data-source
ExampleDS java:/TestDS
[standalone@localhost:9999 /]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:08 a.m.
[
https://issues.jboss.org/browse/AS7-3349?page=com.atlassian.jira.plugin.s...
]
Stefano Maestri commented on AS7-3349:
--------------------------------------
It's arguable, because until the datasource hasn't enabled driver can be add. IOW
you could add the datasource, then deploy the driver and finally enable the datasource and
everything will work.
For sure it's happening during parse, so I'm rejecting this issue.
Data-source add allows adding data sources with non existing JDBC
driver
------------------------------------------------------------------------
Key: AS7-3349
URL: https://issues.jboss.org/browse/AS7-3349
Project: Application Server 7
Issue Type: Bug
Components: CLI, Domain Management
Affects Versions: 7.1.0.Final
Reporter: Dominik Pospisil
Assignee: Stefano Maestri
Labels: eap6-ux
Fix For: 7.1.1.Final
Data-source add allows adding data sources with non existing JDBC driver. The data-source
add command should warn / prevent user from doing such thing.
[standalone@localhost:9999 /] ls /subsystem=datasources/data-source
ExampleDS
[standalone@localhost:9999 /] data-source add --jndi-name=java:/TestDS
--connection-url=jdbc:postgresql://localhost/test --driver-name=NON_EXISTING_DRIVER
[standalone@localhost:9999 /] ls /subsystem=datasources/data-source
ExampleDS java:/TestDS
[standalone@localhost:9999 /]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:08 a.m.
[
https://issues.jboss.org/browse/AS7-3349?page=com.atlassian.jira.plugin.s...
]
Stefano Maestri resolved AS7-3349.
----------------------------------
Resolution: Rejected
see my previous comment
Data-source add allows adding data sources with non existing JDBC
driver
------------------------------------------------------------------------
Key: AS7-3349
URL: https://issues.jboss.org/browse/AS7-3349
Project: Application Server 7
Issue Type: Bug
Components: CLI, Domain Management
Affects Versions: 7.1.0.Final
Reporter: Dominik Pospisil
Assignee: Stefano Maestri
Labels: eap6-ux
Fix For: 7.1.1.Final
Data-source add allows adding data sources with non existing JDBC driver. The data-source
add command should warn / prevent user from doing such thing.
[standalone@localhost:9999 /] ls /subsystem=datasources/data-source
ExampleDS
[standalone@localhost:9999 /] data-source add --jndi-name=java:/TestDS
--connection-url=jdbc:postgresql://localhost/test --driver-name=NON_EXISTING_DRIVER
[standalone@localhost:9999 /] ls /subsystem=datasources/data-source
ExampleDS java:/TestDS
[standalone@localhost:9999 /]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:27 a.m.
[
https://issues.jboss.org/browse/AS7-3349?page=com.atlassian.jira.plugin.s...
]
Dominik Pospisil commented on AS7-3349:
---------------------------------------
And do you really consider this as a valid use case? Is there any reason why a user should
not be forced to install the driver first so this validation could be performed? I think
that this is counter intuitive and also adding data source without validation pretty error
prone.
Is there any other management operation which would allow you to pass reference to
non-existing resource?
Data-source add allows adding data sources with non existing JDBC
driver
------------------------------------------------------------------------
Key: AS7-3349
URL: https://issues.jboss.org/browse/AS7-3349
Project: Application Server 7
Issue Type: Bug
Components: CLI, Domain Management
Affects Versions: 7.1.0.Final
Reporter: Dominik Pospisil
Assignee: Stefano Maestri
Labels: eap6-ux
Fix For: 7.1.1.Final
Data-source add allows adding data sources with non existing JDBC driver. The data-source
add command should warn / prevent user from doing such thing.
[standalone@localhost:9999 /] ls /subsystem=datasources/data-source
ExampleDS
[standalone@localhost:9999 /] data-source add --jndi-name=java:/TestDS
--connection-url=jdbc:postgresql://localhost/test --driver-name=NON_EXISTING_DRIVER
[standalone@localhost:9999 /] ls /subsystem=datasources/data-source
ExampleDS java:/TestDS
[standalone@localhost:9999 /]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:05 a.m.
[
https://issues.jboss.org/browse/AS7-3349?page=com.atlassian.jira.plugin.s...
]
Stefano Maestri reopened AS7-3349:
----------------------------------
Reconsidering it because it can be error prone for user.
What I'm going to do is to add validation when user is adding ds from console (IOW
forcing to add or deploy driver before create the DS). Note that there isn't this kind
of validation when DSes are defined in xml, but a dependency is created waiting for driver
deployment/creation to start the DS.
Data-source add allows adding data sources with non existing JDBC
driver
------------------------------------------------------------------------
Key: AS7-3349
URL: https://issues.jboss.org/browse/AS7-3349
Project: Application Server 7
Issue Type: Bug
Components: CLI, Domain Management
Affects Versions: 7.1.0.Final
Reporter: Dominik Pospisil
Assignee: Stefano Maestri
Labels: eap6-ux
Fix For: 7.1.1.Final
Data-source add allows adding data sources with non existing JDBC driver. The data-source
add command should warn / prevent user from doing such thing.
[standalone@localhost:9999 /] ls /subsystem=datasources/data-source
ExampleDS
[standalone@localhost:9999 /] data-source add --jndi-name=java:/TestDS
--connection-url=jdbc:postgresql://localhost/test --driver-name=NON_EXISTING_DRIVER
[standalone@localhost:9999 /] ls /subsystem=datasources/data-source
ExampleDS java:/TestDS
[standalone@localhost:9999 /]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:02 p.m.
[
https://issues.jboss.org/browse/AS7-3349?page=com.atlassian.jira.plugin.s...
]
Rajesh Rajasekaran commented on AS7-3349:
-----------------------------------------
Is 7.1.1 the right fix version?
Data-source add allows adding data sources with non existing JDBC
driver
------------------------------------------------------------------------
Key: AS7-3349
URL: https://issues.jboss.org/browse/AS7-3349
Project: Application Server 7
Issue Type: Bug
Components: CLI, Domain Management
Affects Versions: 7.1.0.Final
Reporter: Dominik Pospisil
Assignee: Stefano Maestri
Labels: eap6-ux
Fix For: 7.1.1.Final
Data-source add allows adding data sources with non existing JDBC driver. The data-source
add command should warn / prevent user from doing such thing.
[standalone@localhost:9999 /] ls /subsystem=datasources/data-source
ExampleDS
[standalone@localhost:9999 /] data-source add --jndi-name=java:/TestDS
--connection-url=jdbc:postgresql://localhost/test --driver-name=NON_EXISTING_DRIVER
[standalone@localhost:9999 /] ls /subsystem=datasources/data-source
ExampleDS java:/TestDS
[standalone@localhost:9999 /]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:17 a.m.
[
https://issues.jboss.org/browse/AS7-3349?page=com.atlassian.jira.plugin.s...
]
Brian Stansberry reopened AS7-3349:
-----------------------------------
Data-source add allows adding data sources with non existing JDBC
driver
------------------------------------------------------------------------
Key: AS7-3349
URL: https://issues.jboss.org/browse/AS7-3349
Project: Application Server 7
Issue Type: Bug
Components: CLI, Domain Management
Affects Versions: 7.1.0.Final
Reporter: Dominik Pospisil
Assignee: Stefano Maestri
Labels: eap6-ux
Fix For: 7.1.1.Final
Data-source add allows adding data sources with non existing JDBC driver. The data-source
add command should warn / prevent user from doing such thing.
[standalone@localhost:9999 /] ls /subsystem=datasources/data-source
ExampleDS
[standalone@localhost:9999 /] data-source add --jndi-name=java:/TestDS
--connection-url=jdbc:postgresql://localhost/test --driver-name=NON_EXISTING_DRIVER
[standalone@localhost:9999 /] ls /subsystem=datasources/data-source
ExampleDS java:/TestDS
[standalone@localhost:9999 /]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:17 a.m.
[
https://issues.jboss.org/browse/AS7-3349?page=com.atlassian.jira.plugin.s...
]
Brian Stansberry resolved AS7-3349.
-----------------------------------
Fix Version/s: 7.1.0.Final
(was: 7.1.1.Final)
Resolution: Done
Data-source add allows adding data sources with non existing JDBC
driver
------------------------------------------------------------------------
Key: AS7-3349
URL: https://issues.jboss.org/browse/AS7-3349
Project: Application Server 7
Issue Type: Bug
Components: CLI, Domain Management
Affects Versions: 7.1.0.Final
Reporter: Dominik Pospisil
Assignee: Stefano Maestri
Labels: eap6-ux
Fix For: 7.1.0.Final
Data-source add allows adding data sources with non existing JDBC driver. The data-source
add command should warn / prevent user from doing such thing.
[standalone@localhost:9999 /] ls /subsystem=datasources/data-source
ExampleDS
[standalone@localhost:9999 /] data-source add --jndi-name=java:/TestDS
--connection-url=jdbc:postgresql://localhost/test --driver-name=NON_EXISTING_DRIVER
[standalone@localhost:9999 /] ls /subsystem=datasources/data-source
ExampleDS java:/TestDS
[standalone@localhost:9999 /]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4660
days inactive
4682
days old
10 comments
5 participants
participants (5)
-
Alexey Loubyansky (JIRA) -
Brian Stansberry (JIRA)
-
Dominik Pospisil (JIRA)
-
Rajesh Rajasekaran (JIRA)
-
Stefano Maestri (JIRA)