[
https://issues.jboss.org/browse/JGRP-1749?page=com.atlassian.jira.plugin....
]
Bela Ban updated JGRP-1749:
---------------------------
Description:
If we have
{code:xml}
<UDP bind_addr="${myapp.bind_addr:127.0.0.1}".../>
{code}
, then the default bind_addr is {{127.0.0.1}}.
If we set {{-Dmyapp.bind_addr=1.2.3.4}} but also set {{-Djgroups.bind_addr=5.6.7.8}}, then
*the latter system property always overrides the former*.
This is bad, e.g. when we have multiple channels in the same JVM, where one channel uses
{{myapp1.bind_addr}} and the other {{myapp2.bind_addr}}. If {{-Djgroups.bind_addr}} is set
(e.g. by JBoss EAP), then we'll always use it rather than the different bind addresses
!
Investigate whether we still need to use those overrides. Contact Brian Stansberry, IIRC
he's the one who suggested this.
SOLUTION:
* If a property is set in the XML, either directly or via property substitution (e.g.
{{myapp.bind_addr}}, then use that value
* If the value is not set and a system property (e.g. {{jgroups.bind_addr}}) has been set,
set the value from that system property
was:
If we have
{code:xml}
<UDP bind_addr="${myapp.bind_addr:127.0.0.1}".../>
{code}
, then the default bind_addr is {{127.0.0.1}}.
If we set {{-Dmyapp.bind_addr=1.2.3.4}} but also set {{-Djgroups.bind_addr=5.6.7.8}}, then
*the latter system property always overrides the former*.
This is bad, e.g. when we have multiple channels in the same JVM, where one channel uses
{{myapp1.bind_addr}} and the other {{myapp2.bind_addr}}. If {{-Djgroups.bind_addr}} is set
(e.g. by JBoss EAP), then we'll always use it rather than the different bind addresses
!
Investigate whether we still need to use those overrides. Contact Brian Stansberry, IIRC
he's the one who suggested this.
SOLUTION: remove the _global_ system properties such as {{jgroups.bind_addr}}.
Remove override for jgroups.bind_addr, jgroups.udp.mcast_addr,
jgroups.udp.mcast_port
-------------------------------------------------------------------------------------
Key: JGRP-1749
URL:
https://issues.jboss.org/browse/JGRP-1749
Project: JGroups
Issue Type: Task
Reporter: Bela Ban
Assignee: Bela Ban
Priority: Minor
Fix For: 3.4.2, 3.5
If we have
{code:xml}
<UDP bind_addr="${myapp.bind_addr:127.0.0.1}".../>
{code}
, then the default bind_addr is {{127.0.0.1}}.
If we set {{-Dmyapp.bind_addr=1.2.3.4}} but also set {{-Djgroups.bind_addr=5.6.7.8}},
then *the latter system property always overrides the former*.
This is bad, e.g. when we have multiple channels in the same JVM, where one channel uses
{{myapp1.bind_addr}} and the other {{myapp2.bind_addr}}. If {{-Djgroups.bind_addr}} is set
(e.g. by JBoss EAP), then we'll always use it rather than the different bind addresses
!
Investigate whether we still need to use those overrides. Contact Brian Stansberry, IIRC
he's the one who suggested this.
SOLUTION:
* If a property is set in the XML, either directly or via property substitution (e.g.
{{myapp.bind_addr}}, then use that value
* If the value is not set and a system property (e.g. {{jgroups.bind_addr}}) has been
set, set the value from that system property
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira