6:57 p.m.
Code Review with Tim Fox
------------------------
Key: JBMESSAGING-1458
URL: https://jira.jboss.org/jira/browse/JBMESSAGING-1458
Project: JBoss Messaging
Issue Type: Task
Reporter: Clebert Suconic
Assignee: Clebert Suconic
Fix For: 2.0.0 Beta
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:57 p.m.
New subject: [JBoss JIRA] Updated: (JBMESSAGING-1458) Code Review with Tim Fox
[
https://jira.jboss.org/jira/browse/JBMESSAGING-1458?page=com.atlassian.ji...
]
Clebert Suconic updated JBMESSAGING-1458:
-----------------------------------------
Results of first review:
I - ignore the whole file case is damaged on PageImpl::read and throw a big warning.
(Maybe I should also look for possible transactions on that file)
II - Move onDepage from PagingManagerImpl to PageStoreImpl
III - move the private addsize to PageStore
IV: PagingStoreImpl constructor has a check on PagingManager, which can never be null
V - double check if a page could be zeroed... and depaging.size == 0 -> return null on
readPage
VI - Rethink the need of GlobalDepager during the Executor task (Added a comment on JIRA)
Code Review with Tim Fox
------------------------
Key: JBMESSAGING-1458
URL: https://jira.jboss.org/jira/browse/JBMESSAGING-1458
Project: JBoss Messaging
Issue Type: Task
Reporter: Clebert Suconic
Assignee: Clebert Suconic
Fix For: 2.0.0 Beta
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:34 a.m.
New subject: [JBoss JIRA] Updated: (JBMESSAGING-1458) Code Review with Tim Fox
[
https://jira.jboss.org/jira/browse/JBMESSAGING-1458?page=com.atlassian.ji...
]
Tim Fox updated JBMESSAGING-1458:
---------------------------------
JBoss Forum Reference:
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4191154#...
Description: See linked forum thread for more complete write up of review
Code Review with Tim Fox
------------------------
Key: JBMESSAGING-1458
URL: https://jira.jboss.org/jira/browse/JBMESSAGING-1458
Project: JBoss Messaging
Issue Type: Task
Reporter: Clebert Suconic
Assignee: Clebert Suconic
Fix For: 2.0.0 Beta
See linked forum thread for more complete write up of review
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:11 p.m.
New subject: [JBoss JIRA] Closed: (JBMESSAGING-1458) Code Review with Tim Fox
[
https://jira.jboss.org/jira/browse/JBMESSAGING-1458?page=com.atlassian.ji...
]
Clebert Suconic closed JBMESSAGING-1458.
----------------------------------------
Resolution: Done
Code Review with Tim Fox
------------------------
Key: JBMESSAGING-1458
URL: https://jira.jboss.org/jira/browse/JBMESSAGING-1458
Project: JBoss Messaging
Issue Type: Task
Reporter: Clebert Suconic
Assignee: Clebert Suconic
Fix For: 2.0.0 Beta
See linked forum thread for more complete write up of review
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:56 a.m.
New subject: [JBoss JIRA] Reopened: (JBMESSAGING-1458) Code Review with Tim Fox
[
https://jira.jboss.org/jira/browse/JBMESSAGING-1458?page=com.atlassian.ji...
]
Clebert Suconic reopened JBMESSAGING-1458:
------------------------------------------
Code Review with Tim Fox
------------------------
Key: JBMESSAGING-1458
URL: https://jira.jboss.org/jira/browse/JBMESSAGING-1458
Project: JBoss Messaging
Issue Type: Task
Reporter: Clebert Suconic
Assignee: Clebert Suconic
Fix For: 2.0.0 Beta
See linked forum thread for more complete write up of review
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:56 a.m.
New subject: [JBoss JIRA] Updated: (JBMESSAGING-1458) Code Review on Paging
[
https://jira.jboss.org/jira/browse/JBMESSAGING-1458?page=com.atlassian.ji...
]
Clebert Suconic updated JBMESSAGING-1458:
-----------------------------------------
Summary: Code Review on Paging (was: Code Review on AIO)
Code Review on Paging
---------------------
Key: JBMESSAGING-1458
URL: https://jira.jboss.org/jira/browse/JBMESSAGING-1458
Project: JBoss Messaging
Issue Type: Task
Reporter: Clebert Suconic
Assignee: Clebert Suconic
Fix For: 2.0.0 Beta
See linked forum thread for more complete write up of review
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:56 a.m.
New subject: [JBoss JIRA] Updated: (JBMESSAGING-1458) Code Review on AIO
[
https://jira.jboss.org/jira/browse/JBMESSAGING-1458?page=com.atlassian.ji...
]
Clebert Suconic updated JBMESSAGING-1458:
-----------------------------------------
Summary: Code Review on AIO (was: Code Review with Tim Fox)
Code Review on AIO
------------------
Key: JBMESSAGING-1458
URL: https://jira.jboss.org/jira/browse/JBMESSAGING-1458
Project: JBoss Messaging
Issue Type: Task
Reporter: Clebert Suconic
Assignee: Clebert Suconic
Fix For: 2.0.0 Beta
See linked forum thread for more complete write up of review
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:56 a.m.
New subject: [JBoss JIRA] Closed: (JBMESSAGING-1458) Code Review on Paging
[
https://jira.jboss.org/jira/browse/JBMESSAGING-1458?page=com.atlassian.ji...
]
Clebert Suconic closed JBMESSAGING-1458.
----------------------------------------
Resolution: Done
Code Review on Paging
---------------------
Key: JBMESSAGING-1458
URL: https://jira.jboss.org/jira/browse/JBMESSAGING-1458
Project: JBoss Messaging
Issue Type: Task
Reporter: Clebert Suconic
Assignee: Clebert Suconic
Fix For: 2.0.0 Beta
See linked forum thread for more complete write up of review
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5643
days inactive
5833
days old
7 comments
2 participants
participants (2)
-
Clebert Suconic (JIRA) -
Tim Fox (JIRA)