1:12 p.m.
Logic for selecting a provider is too fragile
---------------------------------------------
Key: JBLOGGING-57
URL: https://issues.jboss.org/browse/JBLOGGING-57
Project: JBoss Logging
Issue Type: Bug
Security Level: Public (Everyone can see)
Affects Versions: 3.0.0.Beta4-jboss-logging
Reporter: Dan Allen
Assignee: David Lloyd
Fix For: 3.0.0.Beta5-jboss-logging
The logic used to select the logging provider is too fragile. It should never throw an
exception while selecting a provider, because JDK logging is guaranteed to be available
and should be the fallback choice. When JBoss Logging fails to select a provider, it
causes deployment to fail, which violates my rule #1 of a logging framework (don't
fail a build because of a failure to setup logging).
The fragile logic is the reason we get JBLOGGING-47.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:19 p.m.
New subject: [JBoss JIRA] Resolved: (JBLOGGING-57) Logic for selecting a provider is too fragile
[
https://issues.jboss.org/browse/JBLOGGING-57?page=com.atlassian.jira.plug...
]
David Lloyd resolved JBLOGGING-57.
----------------------------------
Resolution: Rejected
JBoss Logging never fails to select a provider. If one is not found, it defaults to JDK
logging. There are other JIRAs open to track problems with using specific logging
frameworks.
Logic for selecting a provider is too fragile
---------------------------------------------
Key: JBLOGGING-57
URL: https://issues.jboss.org/browse/JBLOGGING-57
Project: JBoss Logging
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.0.0.Beta4-jboss-logging
Reporter: Dan Allen
Assignee: David Lloyd
Fix For: 3.0.0.Beta5-jboss-logging
The logic used to select the logging provider is too fragile. It should never throw an
exception while selecting a provider, because JDK logging is guaranteed to be available
and should be the fallback choice. When JBoss Logging fails to select a provider, it
causes deployment to fail, which violates my rule #1 of a logging framework (don't
fail a build because of a failure to setup logging).
The fragile logic is the reason we get JBLOGGING-47.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:53 p.m.
New subject: [JBoss JIRA] Commented: (JBLOGGING-57) Logic for selecting a provider is too fragile
[
https://issues.jboss.org/browse/JBLOGGING-57?page=com.atlassian.jira.plug...
]
Dan Allen commented on JBLOGGING-57:
------------------------------------
Um, JBLOGGING-47 is failing to select a provider. So yes, the logic is currently too
fragile.
Logic for selecting a provider is too fragile
---------------------------------------------
Key: JBLOGGING-57
URL: https://issues.jboss.org/browse/JBLOGGING-57
Project: JBoss Logging
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.0.0.Beta4-jboss-logging
Reporter: Dan Allen
Assignee: David Lloyd
Fix For: 3.0.0.Beta5-jboss-logging
The logic used to select the logging provider is too fragile. It should never throw an
exception while selecting a provider, because JDK logging is guaranteed to be available
and should be the fallback choice. When JBoss Logging fails to select a provider, it
causes deployment to fail, which violates my rule #1 of a logging framework (don't
fail a build because of a failure to setup logging).
The fragile logic is the reason we get JBLOGGING-47.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:55 p.m.
New subject: [JBoss JIRA] Commented: (JBLOGGING-57) Logic for selecting a provider is too fragile
[
https://issues.jboss.org/browse/JBLOGGING-57?page=com.atlassian.jira.plug...
]
Dan Allen commented on JBLOGGING-57:
------------------------------------
I'm just pointing that out. If you want to deal with it solely in JBLOGGING-47,
that's fine.
Logic for selecting a provider is too fragile
---------------------------------------------
Key: JBLOGGING-57
URL: https://issues.jboss.org/browse/JBLOGGING-57
Project: JBoss Logging
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.0.0.Beta4-jboss-logging
Reporter: Dan Allen
Assignee: David Lloyd
Fix For: 3.0.0.Beta5-jboss-logging
The logic used to select the logging provider is too fragile. It should never throw an
exception while selecting a provider, because JDK logging is guaranteed to be available
and should be the fallback choice. When JBoss Logging fails to select a provider, it
causes deployment to fail, which violates my rule #1 of a logging framework (don't
fail a build because of a failure to setup logging).
The fragile logic is the reason we get JBLOGGING-47.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2 p.m.
New subject: [JBoss JIRA] Commented: (JBLOGGING-57) Logic for selecting a provider is too fragile
[
https://issues.jboss.org/browse/JBLOGGING-57?page=com.atlassian.jira.plug...
]
Dan Allen commented on JBLOGGING-57:
------------------------------------
https://github.com/jbossas/jboss-logging/blob/master/src/main/java/org/jb...
Why not just put the whole thing in a try/catch block just in case? The separate try/catch
blocks just seem too tentative to me. Though, only the first check is truly fragile atm.
Logic for selecting a provider is too fragile
---------------------------------------------
Key: JBLOGGING-57
URL: https://issues.jboss.org/browse/JBLOGGING-57
Project: JBoss Logging
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.0.0.Beta4-jboss-logging
Reporter: Dan Allen
Assignee: David Lloyd
Fix For: 3.0.0.Beta5-jboss-logging
The logic used to select the logging provider is too fragile. It should never throw an
exception while selecting a provider, because JDK logging is guaranteed to be available
and should be the fallback choice. When JBoss Logging fails to select a provider, it
causes deployment to fail, which violates my rule #1 of a logging framework (don't
fail a build because of a failure to setup logging).
The fragile logic is the reason we get JBLOGGING-47.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:20 p.m.
New subject: [JBoss JIRA] Commented: (JBLOGGING-57) Logic for selecting a provider is too fragile
[
https://issues.jboss.org/browse/JBLOGGING-57?page=com.atlassian.jira.plug...
]
David Lloyd commented on JBLOGGING-57:
--------------------------------------
Just in case of what? Functionally it is identical. The exception in JBLOGGING-47 simply
does not arise from this logic. This logic correctly identifies the JBoss LogManager as
being present. The problem is that it doesn't detect whether the version found is
actually compatible.
Generally I don't approve of superstition-oriented programming. :-)
Logic for selecting a provider is too fragile
---------------------------------------------
Key: JBLOGGING-57
URL: https://issues.jboss.org/browse/JBLOGGING-57
Project: JBoss Logging
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.0.0.Beta4-jboss-logging
Reporter: Dan Allen
Assignee: David Lloyd
Fix For: 3.0.0.Beta5-jboss-logging
The logic used to select the logging provider is too fragile. It should never throw an
exception while selecting a provider, because JDK logging is guaranteed to be available
and should be the fallback choice. When JBoss Logging fails to select a provider, it
causes deployment to fail, which violates my rule #1 of a logging framework (don't
fail a build because of a failure to setup logging).
The fragile logic is the reason we get JBLOGGING-47.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:33 p.m.
New subject: [JBoss JIRA] Commented: (JBLOGGING-57) Logic for selecting a provider is too fragile
[
https://issues.jboss.org/browse/JBLOGGING-57?page=com.atlassian.jira.plug...
]
Dan Allen commented on JBLOGGING-57:
------------------------------------
I just think it would be cleaner to have a single try/catch, but I guess that is a style
choice.
In general, though, the check for the class alone is really not sufficient, as you pointed
out. I think returning an incompatible version is itself a failure (enough to force the
use of the JDK14 logger). So I stick to my original guns and say that this logic is too
frail in it's current form. And that goes for even the slf4j and log4j checks
(assuming API incompatibilities are a possibility there too).
Logic for selecting a provider is too fragile
---------------------------------------------
Key: JBLOGGING-57
URL: https://issues.jboss.org/browse/JBLOGGING-57
Project: JBoss Logging
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.0.0.Beta4-jboss-logging
Reporter: Dan Allen
Assignee: David Lloyd
Fix For: 3.0.0.Beta5-jboss-logging
The logic used to select the logging provider is too fragile. It should never throw an
exception while selecting a provider, because JDK logging is guaranteed to be available
and should be the fallback choice. When JBoss Logging fails to select a provider, it
causes deployment to fail, which violates my rule #1 of a logging framework (don't
fail a build because of a failure to setup logging).
The fragile logic is the reason we get JBLOGGING-47.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:33 p.m.
New subject: [JBoss JIRA] Commented: (JBLOGGING-57) Logic for selecting a provider is too fragile
[
https://issues.jboss.org/browse/JBLOGGING-57?page=com.atlassian.jira.plug...
]
Dan Allen commented on JBLOGGING-57:
------------------------------------
I just think it would be cleaner to have a single try/catch, but I guess that is a style
choice.
In general, though, the check for the class alone is really not sufficient, as you pointed
out. I think returning an incompatible version is itself a failure (enough to force the
use of the JDK14 logger). So I stick to my original guns and say that this logic is too
frail in it's current form. And that goes for even the slf4j and log4j checks
(assuming API incompatibilities are a possibility there too).
Logic for selecting a provider is too fragile
---------------------------------------------
Key: JBLOGGING-57
URL: https://issues.jboss.org/browse/JBLOGGING-57
Project: JBoss Logging
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.0.0.Beta4-jboss-logging
Reporter: Dan Allen
Assignee: David Lloyd
Fix For: 3.0.0.Beta5-jboss-logging
The logic used to select the logging provider is too fragile. It should never throw an
exception while selecting a provider, because JDK logging is guaranteed to be available
and should be the fallback choice. When JBoss Logging fails to select a provider, it
causes deployment to fail, which violates my rule #1 of a logging framework (don't
fail a build because of a failure to setup logging).
The fragile logic is the reason we get JBLOGGING-47.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:35 p.m.
New subject: [JBoss JIRA] Updated: (JBLOGGING-57) Logic for selecting a provider is too fragile
[
https://issues.jboss.org/browse/JBLOGGING-57?page=com.atlassian.jira.plug...
]
Dan Allen updated JBLOGGING-57:
-------------------------------
Comment: was deleted
(was: I just think it would be cleaner to have a single try/catch, but I guess that is a
style choice.
In general, though, the check for the class alone is really not sufficient, as you pointed
out. I think returning an incompatible version is itself a failure (enough to force the
use of the JDK14 logger). So I stick to my original guns and say that this logic is too
frail in it's current form. And that goes for even the slf4j and log4j checks
(assuming API incompatibilities are a possibility there too).)
Logic for selecting a provider is too fragile
---------------------------------------------
Key: JBLOGGING-57
URL: https://issues.jboss.org/browse/JBLOGGING-57
Project: JBoss Logging
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.0.0.Beta4-jboss-logging
Reporter: Dan Allen
Assignee: David Lloyd
Fix For: 3.0.0.Beta5-jboss-logging
The logic used to select the logging provider is too fragile. It should never throw an
exception while selecting a provider, because JDK logging is guaranteed to be available
and should be the fallback choice. When JBoss Logging fails to select a provider, it
causes deployment to fail, which violates my rule #1 of a logging framework (don't
fail a build because of a failure to setup logging).
The fragile logic is the reason we get JBLOGGING-47.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:37 p.m.
New subject: [JBoss JIRA] Issue Comment Edited: (JBLOGGING-57) Logic for selecting a provider is too fragile
[
https://issues.jboss.org/browse/JBLOGGING-57?page=com.atlassian.jira.plug...
]
Dan Allen edited comment on JBLOGGING-57 at 3/23/11 3:37 PM:
-------------------------------------------------------------
I just think it would be cleaner to have a single try/catch, but I guess that is a style
choice.
In general, though, the check for the class alone is really not sufficient, as you pointed
out. I think returning an incompatible version is itself a failure (enough to force the
use of the JDK14 logger). So I stick to my original guns and say that this logic is too
frail in its current form. And that goes for even the slf4j and log4j checks (assuming API
incompatibilities are a possibility there too).
was (Author: dan.j.allen):
I just think it would be cleaner to have a single try/catch, but I guess that is a
style choice.
In general, though, the check for the class alone is really not sufficient, as you pointed
out. I think returning an incompatible version is itself a failure (enough to force the
use of the JDK14 logger). So I stick to my original guns and say that this logic is too
frail in it's current form. And that goes for even the slf4j and log4j checks
(assuming API incompatibilities are a possibility there too).
Logic for selecting a provider is too fragile
---------------------------------------------
Key: JBLOGGING-57
URL: https://issues.jboss.org/browse/JBLOGGING-57
Project: JBoss Logging
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.0.0.Beta4-jboss-logging
Reporter: Dan Allen
Assignee: David Lloyd
Fix For: 3.0.0.Beta5-jboss-logging
The logic used to select the logging provider is too fragile. It should never throw an
exception while selecting a provider, because JDK logging is guaranteed to be available
and should be the fallback choice. When JBoss Logging fails to select a provider, it
causes deployment to fail, which violates my rule #1 of a logging framework (don't
fail a build because of a failure to setup logging).
The fragile logic is the reason we get JBLOGGING-47.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3 p.m.
New subject: [JBoss JIRA] Commented: (JBLOGGING-57) Logic for selecting a provider is too fragile
[
https://issues.jboss.org/browse/JBLOGGING-57?page=com.atlassian.jira.plug...
]
David Lloyd commented on JBLOGGING-57:
--------------------------------------
The multiple try blocks here are not a style choice - they exist so that each framework
can be detected separately; that is, they have a functional purpose. If I went to one,
then log4j and logback would be undetectable.
The risk of detecting an incompatible version of log4j is exceedingly low since that
framework has existed for a very long time. I'm not concerned about an incompatible
log4j API change. And logback is special in that it uses slf4j as the API, and Ceki has,
as far as I understand, committed to long-term compatibility of the slf4j API. The worst
that could happen would be that logback would change incompatibly and thus it would fail
to be detected, but this won't really cause any serious functional detriment.
This issue is invalid primarily due to the subjective nature of the word
"Fragile". If you can't measure it then I can't fix it. JBLOGGING-47
on the other hand is a quantifiable problem with a specific solution. Feeling leery about
something is not something I can fix.
Logic for selecting a provider is too fragile
---------------------------------------------
Key: JBLOGGING-57
URL: https://issues.jboss.org/browse/JBLOGGING-57
Project: JBoss Logging
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.0.0.Beta4-jboss-logging
Reporter: Dan Allen
Assignee: David Lloyd
Fix For: 3.0.0.Beta5-jboss-logging
The logic used to select the logging provider is too fragile. It should never throw an
exception while selecting a provider, because JDK logging is guaranteed to be available
and should be the fallback choice. When JBoss Logging fails to select a provider, it
causes deployment to fail, which violates my rule #1 of a logging framework (don't
fail a build because of a failure to setup logging).
The fragile logic is the reason we get JBLOGGING-47.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:07 p.m.
New subject: [JBoss JIRA] Commented: (JBLOGGING-57) Logic for selecting a provider is too fragile
[
https://issues.jboss.org/browse/JBLOGGING-57?page=com.atlassian.jira.plug...
]
Dan Allen commented on JBLOGGING-57:
------------------------------------
The multiple try blocks here are not a style choice - they exist so
that each framework can be detected separately
I meant having an outer try/catch block. Looking again, I see you are catching Throwable
(as opposed to a specific exception like ClassNotFoundException), so then the outer block
would indeed be redundant. It would only be needed if something could slip through, which
it can't.
This issue is invalid primarily due to the subjective nature of the
word "Fragile". If you can't measure it then I can't fix it.
Fair enough.
Logic for selecting a provider is too fragile
---------------------------------------------
Key: JBLOGGING-57
URL: https://issues.jboss.org/browse/JBLOGGING-57
Project: JBoss Logging
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.0.0.Beta4-jboss-logging
Reporter: Dan Allen
Assignee: David Lloyd
Fix For: 3.0.0.Beta5-jboss-logging
The logic used to select the logging provider is too fragile. It should never throw an
exception while selecting a provider, because JDK logging is guaranteed to be available
and should be the fallback choice. When JBoss Logging fails to select a provider, it
causes deployment to fail, which violates my rule #1 of a logging framework (don't
fail a build because of a failure to setup logging).
The fragile logic is the reason we get JBLOGGING-47.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5026
days inactive
5028
days old
11 comments
2 participants
participants (2)
-
Dan Allen (JIRA) -
David Lloyd (JIRA)