[ https://jira.jboss.org/jira/browse/JBMETA-208?page=com.atlassian.jira.plu... ] Alexey Loubyansky commented on JBMETA-208: ------------------------------------------ The namespace is what distinguishes EJB2 descriptor from EJB3. DTDs don't have a namespace. EJB2 and EJB1 schemas are based on DTDs, so when a descriptor w/o a namespace is found it assumed to be EJB2.x one. This is also how the metadata classes are bound with JAXB/JBossXB annotations. EJB3 metadata classes (as any Java class in principle) are bound to a specific namespace, which is http://java.sun.com/xml/ns/javaee in case of EJB3. Although, we could make it work w/o a namespace (by copying EjbJar30MetaData class, binding it to an empty namespace and adjusting metadata version resolution logic (which will be now done outside of XB's SchemaResolver impl, but by a deployer probably)), I am so far not in favor of supporting this. If you are writing an XML based on an XSD it is a given to include the namespace from the XSD. So, I would fix the EJB3 docs instead. PS: the forum link is not really about this issue. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBMETA-208?page=com.atlassian.jira.plu... ] Alexey Loubyansky commented on JBMETA-208: ------------------------------------------ An EJB-JAR with EJB2 ejb-jar.xml and EJB3 annotations should fail to deploy. I'll have a look. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBMETA-208?page=com.atlassian.jira.plu... ] Alexey Loubyansky commented on JBMETA-208: ------------------------------------------ Emanuel is right. What happens in your case is that the ejb-jar.xml is parsed first. Since it doesn't have a namespace, it's assumed to follow a DTD which means it'll be treated as EJB2. EJB2 don't use annotations, so annotation processing is skipped. And since ejb-jar.xml in your case doesn't describe any beans there is nothing to bind to the JNDI. If you try describing EJB3 bean in EJB2 ejb-jar.xml you should get an error during deployment. So, I am going to close it as "won't fix". You can try to convince the EJB3 team on the forums to make the namespace optional. But IMO that's not a good idea. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBMETA-208?page=com.atlassian.jira.plu... ] Richard Kennard reopened JBMETA-208: ------------------------------------ Yes you should, but you don't. Please reopen this issue. If you DID get an error during deployment, I would agree the current 'namespace versus DTD' handling is fine. As it is, you get an obscure JBMETA-4 warning and everything fails silently. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBMETA-208?page=com.atlassian.jira.plu... ] Richard Kennard commented on JBMETA-208: ---------------------------------------- Fair enough. But in general EJB3 beans are not described in the deployment descriptor: they are described with an annotation on the class. If you have a bean annotated @Stateful or @Stateless in your JAR, but your JAR has an EJB2 deployment descriptor, you should get an error. But you don't. You DO get a JBMETA-4 warning, but this is not very clear as to what the problem is. I am sorry I haven't been explaining myself very well. I hope the problem is now clear. What happened was I upgraded a JBoss 4.2.3.GA app to JBoss 5.1.0. The app used EJB3 annotations but forgot the namespace on the ejb-jar.xml (hence accidentally making it an EJB2 descriptor). This worked fine on JBoss 4.2.3.GA, but JBoss 5.1.0 is clearly stricter. This is a good thing, but throwing an error would be useful for stupid people like me! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBMETA-208?page=com.atlassian.jira.plu... ] Alexey Loubyansky commented on JBMETA-208: ------------------------------------------ For the record, I am adding a check to Ejb3AnnotationHandler (right before the possible JBMETA-4 warning) whether the metadata is version 3.x and if it's not an exception is thrown: "Attempt to process non-EJB3.x EJB-JAR metadata as EJB3.x for deployment " + deployment.getName() But then again I am fixing other parts in the deployers where EJB2 metadata should not pass through. So, EJB2 metadata won't reach Ejb3AnnotationHandler. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBMETA-208?page=com.atlassian.jira.plu... ] Alexey Loubyansky commented on JBMETA-208: ------------------------------------------ This is what Richard is asking for: "If you have a bean annotated @Stateful or @Stateless in your JAR, but your JAR has an EJB2 deployment descriptor, you should get an error." It is now. See related issues. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBMETA-208?page=com.atlassian.jira.plu... ] Richard Kennard commented on JBMETA-208: ---------------------------------------- Thank you all for the time and thought you have put into this. I think everybody's position is very reasonable. In particular, I understand... "When a JAR is deployed, we first look whether there is an ejb-jar.xml. And if it's there we can tell by its version which EJB version this deployment is. And if it's EJB2 then does it make sense to look into each class in the JAR to make sure there are no EJB3 annotations? Because this is what you are asking for. It's rather expensive performance-wise." At the same time, though, I would counsel that "the deployment should have been completely skipped from the EJB3 processing", without any warning, is rather dangerous. Even though the EJB 3.0 spec might mandate "all EJB deployment descriptors must indicate the ejb-jar schema by using the Java EE namespace" plenty of examples and tutorials on the Web, for reasons of brevity or simply laziness, omit it. For example: http://docs.jboss.org/ejb3/app-server/reference/build/reference/en/html/p... You can fix the JBoss ones, but not all the third-party ones. If I may humbly suggest a solution: 1. Scan the ejb-jar.xml 2. If it contains a DTD, treat it as EJB 2.x (or 1.x) and don't scan for annotations 3. If it contains a namespace, treat it as EJB 3.x (or above) and scan for annotations 4. If it contains neither a DTD nor a namespace, display a warning that you are entering 'compatibility mode' where you both process the ejb-jar.xml and scan for annotations (at the expense of reduced startup time). The warning should advise the developer 'either add a DTD or a namespace to avoid this warning' In some ways this is more accurate, because if there is no DTD or namespace you really can't say what version it is. Regards, Richard. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBMETA-208?page=com.atlassian.jira.plu... ] Alexey Loubyansky commented on JBMETA-208: ------------------------------------------ You'd have to do it for every EJB2 deployment. In that case it's better just to log the EJB version of the deployment. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBMETA-208?page=com.atlassian.jira.plugin.s... ] Alexey Loubyansky reassigned JBMETA-208: ---------------------------------------- Assignee: Ondrej Žižka (was: Alexey Loubyansky) This has to be re-assigned to somebody from the doc team. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBMETA-208?page=com.atlassian.jira.plugin.s... ] Carlo de Wolf updated JBMETA-208: --------------------------------- JBoss Forum Reference: http://community.jboss.org/thread/121582 (was: http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4237550#...) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira