[ http://jira.jboss.com/jira/browse/JBAS-3686?page=comments#action_12343809 ] Galder Zamarreno commented on JBAS-3686: ---------------------------------------- But it leads to an attempt to deploy a *-ds.xml as if it were a sub deployment of deploy. If it attempts to deploy it and it can't it should say something, otherwise, don't even start the deployment. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAS-3686?page=comments#action_12343814 ] Adrian Brock commented on JBAS-3686: ------------------------------------ The issue is caused by the following code in MainDeployer:deploy(URL) if( sdi.state != DeploymentState.STARTED ) checkIncompleteDeployments(); In this case, the top level deployment is started (the deploy folder) so no check is made. Since there are no other deployments, it never does this code in URLDeploymentScanner: // Validate that there are still incomplete deployments if (lastIncompleteDeploymentException != null) { try { Object[] args = {}; String[] sig = {}; getServer().invoke(getDeployer(), "checkIncompleteDeployments", args, sig); } catch (Exception e) { Throwable t = JMXExceptionDecoder.decode(e); log.error(t); } } This just looks broken to me. In this case, there is nothing wrong with the deployment, the issue is with the MBeans created as part of the deployment process not having dependencies satisfied. In my opinion, the MainDeployer should not be automatically doing any checks for incomplete deployments it should be invoked by the caller since only it knows whether there are multiple urls that could have some relation. main.deploy(url1); // creates mbean1 main.deploy(url2); // creates mbean2 that depends on mbean1 main.checkIncompleteDeployments(); In this way, the URLDeploymentScanner should always check for incompleteness after every scan that deploys or undeploys something. You could have a helper method in MainDeployer for simple cases, which is also what should be used by the testsuite (in most cases). e.g. MainDeployer::deployAndCheck(URL url) { deploy(url); checkIncompleteDeployments(); } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira