[ https://issues.jboss.org/browse/JBJCA-847?page=com.atlassian.jira.plugin.... ] Logan McGrath commented on JBJCA-847: ------------------------------------- I'm working on a fix. Here's the specific problems I've confirmed with how they're being addressed: * Executing "mvn test" gives java.lang.ClassNotFoundException. ** Could not reproduce, instead, the deployment failed with org.jboss.jca.common.metadata.ParserException: "IJ010065: Missing mandatory jndi-name attribute: connection-definition" * Build errors due to package names starting with "java" rather than the TLPN given when generating the code (com, org, net, etc.) ** Cause: generated pom.xml designates the source directory as src/main rather than src/main/java. ** Resolution: remove source directory and test directory declarations from pom.xml. * "The method XXX must override a superclass method" error: ** Cause: Maven compiler plugin is configured to for Java 1.5 source and target. ** Resolution: Configure the Maven compiler plugin for Java 1.6 source and target. The generated POM is pretty hard to read, and it doesn't exactly follow a lot of the "standard" Maven conventions. Here's the enumerated changes: * I changed the declared version from 0.1 to 0.0.1-SNAPSHOT: the generated project is a development version, after all, and this is the "default version" created in many Maven archetypes * Changed packaging to RAR from JAR: Maven projects should not produce primary artifacts that are different from their declared packaging, and the generated POM tries to do just that (bad!) * Removed JAR and RAR plugins: Maven will use the default configurations for these plugins, and also because of the above item It may actually make sense to create a Maven archetype for use in place of the code generator. The reason being that Maven can itself operate as a code generator, and you get a much cleaner output. Here's the diff: http://pastebin.com/Va8AD2cY -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBJCA-847?page=com.atlassian.jira.plugin.... ] Murray Todd Williams commented on JBJCA-847: -------------------------------------------- Logan, question for clarification: your new POM builds a JAR instead of RAR now? I'm confused... I thought the whole purpose was to build a resource adapter. Granted, my own (manual) attempt at this has involved creating a Maven project with two sub-modules: one that builds the JAR and the other that packages the RAR. (And it seems like it might make sense to make a third that breaks the Connection and ConnectionFactory interfaces into a separate JAR that could be used by the end-users' applications.) But I had also read somewhere that it was possible (although apparently not considered fully "proper") to write a slightly contorted Maven POM that would construct a RAR, itself containing the classes in a compiled JAR. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBJCA-847?page=com.atlassian.jira.plugin.... ] Logan McGrath commented on JBJCA-847: ------------------------------------- Oops I goofed up. It just builds a RAR, not a JAR. My above arguments are still very valid, though. The classes will be compiled into a classes/ folder like in a WAR, so the generated project is (almost) immediately deployable. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBJCA-847?page=com.atlassian.jira.plugin.... ] Jesper Pedersen commented on JBJCA-847: --------------------------------------- Having .class directly in the .rar isn't spec compliant - see http://docs.jboss.org/ironjacamar/userguide/1.1/en-US/html/deployment.htm... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBJCA-847?page=com.atlassian.jira.plugin.... ] Logan McGrath commented on JBJCA-847: ------------------------------------- No it's not, so the POM probably needs to be changed to be just a JAR. I'm still wondering if a Maven archetype would work better than the code generator because you could create the necessary composite project containing both JAR and RAR projects. The only other solution is to do the "slightly contorted Maven POM", but that'll leave a lot of Maven users scratching their heads. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBJCA-847?page=com.atlassian.jira.plugin.... ] Murray Todd Williams commented on JBJCA-847: -------------------------------------------- The Maven archetype wouldn't give all the goodies that the CodeGenerator offers in terms of choosing outbound/inbound/bi-directional, transactional support, admin objects, etc. Also, the CodeGenerator is nice enough to support Ant, Ivy and Maven, which is rather impressive. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBJCA-847?page=com.atlassian.jira.plugin.... ] Murray Todd Williams commented on JBJCA-847: -------------------------------------------- Actually, the *proper* approach would be to just fix the darned Maven RAR Plugin. I took at look at it's JIRA page (http://jira.codehaus.org/browse/MRAR) and it's pretty obvious that there's nobody at the helm. This amazes me since RAR is one of the eight native Maven <packaging> types! (http://stackoverflow.com/questions/5544019/what-are-all-the-default-maven...) and is part of Maven's default built-in functionality! But I don't happen to have oodles of time to take on another Open Source volunteer effort (working on JBoss stuff is much more exciting and fruitful) so the best thing I think is to "work around" the Maven RAR plugin that is so long-in-the-tooth. (5 years since its last major update!) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBJCA-847?page=com.atlassian.jira.plugin.... ] Jeff Zhang commented on JBJCA-847: ---------------------------------- Hi Logan, I had looked your patch. 1. Java 1.6 source and target. OK 2. 0.1 to 0.0.1-SNAPSHOT OK 3. Changed packaging to RAR from JAR Use RAR as default package type, maven is still to use maven-rar-plugin. We use maven-jar-plugin and maven-rar-plugin both, that could package rar file as we want. So I think currently it works well. 4. Change the src/main to src/main/java and src/test to src/test/java ? We use maven layout now "src/main/java" BTW: our eclipse plugin for ironjacamar can import generated maven style project. I will look to import into eclipse by "mvn eclipse:eclipse" please comment if I miss something -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBJCA-847?page=com.atlassian.jira.plugin.... ] Jeff Zhang resolved JBJCA-847. ------------------------------ Fix Version/s: 1.1.0.Beta3 Resolution: Done mvn eclipse:eclipse and m2e import are both work well -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira