[
https://issues.redhat.com/browse/DROOLS-5517?page=com.atlassian.jira.plug...
]
Toshiya Kobayashi edited comment on DROOLS-5517 at 9/11/20 12:48 AM:
---------------------------------------------------------------------
Ideas:
- -Add a method to get OutputSet from DMNContext impl (and want isTypeSafe() method in
Interface?)-
- -Option A)-
-- -Share DMNContextFPAImpl for both InputSet and OutputSet-
-- -DMNContextFPAImpl.clone() will return DMNContextFPAImpl instance-
-- -DMNContextFPAImpl will delegate operations to DMNContextImpl in order to avoid
complexity-
- -Option B)-
-- -Map and Recreate DMNContext right before returning evaluateXXX().-
-[https://github.com/kiegroup/drools/blob/7.40.0.Final/kie-dmn/kie-dmn-core/src/main/java/org/kie/dmn/core/impl/DMNRuntimeImpl.java#L116]-
- Option C)
** Create DMNContextFPAImpl with OutputSet instance first (the values can be populated
from InputSet)
** Before DMNRuntime execution, convert from DMNContextFPAImpl to DMNContextImpl (So the
internal execution logic doesn't change)
** After evaluation, client can convert from result DMNContextImpl to DMNContextFPAImpl
with OutputSet.
was (Author: tkobayashi):
-Ideas:-
- -Add a method to get OutputSet from DMNContext impl (and want isTypeSafe() method in
Interface?)-
- -Option A)-
-- -Share DMNContextFPAImpl for both InputSet and OutputSet-
-- -DMNContextFPAImpl.clone() will return DMNContextFPAImpl instance-
-- -DMNContextFPAImpl will delegate operations to DMNContextImpl in order to avoid
complexity-
- -Option B)-
-- -Map and Recreate DMNContext right before returning evaluateXXX().-
-[https://github.com/kiegroup/drools/blob/7.40.0.Final/kie-dmn/kie-dmn-core/src/main/java/org/kie/dmn/core/impl/DMNRuntimeImpl.java#L116]-
- Option C)
** Create DMNContextFPAImpl with OutputSet instance first (the values can be populated
from InputSet)
** Before DMNRuntime execution, convert from DMNContextFPAImpl to DMNContextImpl (So the
internal execution logic doesn't change)
** After evaluation, client can convert from result DMNContextImpl to DMNContextFPAImpl
with OutputSet.
Enhance DMNResult/DMNContext to be able to return strongly typed
OutputSet
--------------------------------------------------------------------------
Key: DROOLS-5517
URL:
https://issues.redhat.com/browse/DROOLS-5517
Project: Drools
Issue Type: Enhancement
Components: dmn engine
Affects Versions: 7.40.0.Final
Reporter: Toshiya Kobayashi
Assignee: Toshiya Kobayashi
Priority: Major
DROOLS-5502 was to generate OutputSet class and convert DMNResult.getContext().getAll()
to the OutputSet externally. This JIRA aims to convert it inside DMNRuntime so that we can
get the OutputSet from DMNResult.getContext().getXXX() directly.
https://github.com/kiegroup/drools/pull/2993#pullrequestreview-451150317
--
This message was sent by Atlassian Jira
(v7.13.8#713008)