JBoss Tools SVN: r21894 - branches/modular_build/build.
by jbosstools-commits@lists.jboss.org
Author: nickboldt
Date: 2010-05-04 12:56:24 -0400 (Tue, 04 May 2010)
New Revision: 21894
Modified:
branches/modular_build/build/build.xml
Log:
failonerror rsynching
Modified: branches/modular_build/build/build.xml
===================================================================
--- branches/modular_build/build/build.xml 2010-05-04 16:18:00 UTC (rev 21893)
+++ branches/modular_build/build/build.xml 2010-05-04 16:56:24 UTC (rev 21894)
@@ -910,7 +910,7 @@
<available file="${sourceDir}" type="dir" />
<then>
<echo message="${deployCmd}" />
- <exec executable="bash">
+ <exec executable="bash" failonerror="true">
<arg line=" -c "${deployCmd}"" />
</exec>
</then>
14 years, 8 months
JBoss Tools SVN: r21893 - branches/modular_build/build.
by jbosstools-commits@lists.jboss.org
Author: nickboldt
Date: 2010-05-04 12:18:00 -0400 (Tue, 04 May 2010)
New Revision: 21893
Modified:
branches/modular_build/build/build.xml
Log:
fix missing defn of update.site.path
Modified: branches/modular_build/build/build.xml
===================================================================
--- branches/modular_build/build/build.xml 2010-05-04 14:53:32 UTC (rev 21892)
+++ branches/modular_build/build/build.xml 2010-05-04 16:18:00 UTC (rev 21893)
@@ -623,26 +623,28 @@
<!-- Used to build the overall update site for all components; requires a custom site.xml (generated from category.*.xml) and previously checked in pom.xml -->
<target name="create.overall.update.site" depends="init">
+ <property name="update.site.path" value="site" />
<!-- Clean up from last time, then fetch fresh sources (checkout or update) -->
- <delete dir="${WORKINGDIR}/site/target" quiet="true" />
+ <!-- TODO: don't overwrite the build.cfg file the second time we call get.sources -->
+ <delete dir="${WORKINGDIR}/${update.site.path}/target" quiet="true" />
<antcall target="get.sources">
<param name="COMPONENT" value="site" />
</antcall>
<!-- Get correct version of site.xml + resolve variables -->
- <loadfile property="site.xml.transformed" srcfile="${WORKINGDIR}/site/category.${product.id}.xml">
+ <loadfile property="site.xml.transformed" srcfile="${WORKINGDIR}/${update.site.path}/category.${product.id}.xml">
<filterchain>
<expandproperties />
</filterchain>
</loadfile>
- <echo file="${WORKINGDIR}/site/site.xml" message="${site.xml.transformed}" />
+ <echo file="${WORKINGDIR}/${update.site.path}/site.xml" message="${site.xml.transformed}" />
<var name="site.xml.transformed" unset="true" />
<!-- Build update site -->
<antcall target="build.update.site">
<param name="COMPONENTS.to.build" value="site" />
- <param name="update.site.path" value="site" />
+ <param name="update.site.path" value="${update.site.path}" />
</antcall>
<!-- Copy overall site into workspace so it can be archived by Hudson -->
@@ -657,7 +659,6 @@
</copy>
</then>
</if>
-
</target>
<target name="build.update.site">
14 years, 8 months
JBoss Tools SVN: r21892 - trunk/cdi/tests/org.jboss.tools.cdi.core.test/resources/tck/tests/jbt/validation/disposers.
by jbosstools-commits@lists.jboss.org
Author: akazakov
Date: 2010-05-04 10:53:32 -0400 (Tue, 04 May 2010)
New Revision: 21892
Added:
trunk/cdi/tests/org.jboss.tools.cdi.core.test/resources/tck/tests/jbt/validation/disposers/TimestampLogger_Broken.java
Log:
https://jira.jboss.org/jira/browse/JBIDE-2708
Added: trunk/cdi/tests/org.jboss.tools.cdi.core.test/resources/tck/tests/jbt/validation/disposers/TimestampLogger_Broken.java
===================================================================
--- trunk/cdi/tests/org.jboss.tools.cdi.core.test/resources/tck/tests/jbt/validation/disposers/TimestampLogger_Broken.java (rev 0)
+++ trunk/cdi/tests/org.jboss.tools.cdi.core.test/resources/tck/tests/jbt/validation/disposers/TimestampLogger_Broken.java 2010-05-04 14:53:32 UTC (rev 21892)
@@ -0,0 +1,18 @@
+package org.jboss.jsr299.tck.tests.jbt.validation.disposers;
+
+import javax.enterprise.inject.Disposes;
+import javax.enterprise.inject.Produces;
+
+public class TimestampLogger_Broken {
+
+ @Produces
+ public static Spider getSpider() {
+ return new Spider();
+ }
+
+ public static void destorySpider(@Disposes Spider spider) {
+ }
+
+ public static void destorySpiderAgain(@Disposes Spider spider) {
+ }
+}
\ No newline at end of file
Property changes on: trunk/cdi/tests/org.jboss.tools.cdi.core.test/resources/tck/tests/jbt/validation/disposers/TimestampLogger_Broken.java
___________________________________________________________________
Name: svn:mime-type
+ text/plain
14 years, 8 months
JBoss Tools SVN: r21891 - trunk/drools/docs/guvnor_ref/en-US.
by jbosstools-commits@lists.jboss.org
Author: abogachuk
Date: 2010-05-04 10:52:27 -0400 (Tue, 04 May 2010)
New Revision: 21891
Modified:
trunk/drools/docs/guvnor_ref/en-US/conclusion.xml
trunk/drools/docs/guvnor_ref/en-US/functionality_overview.xml
trunk/drools/docs/guvnor_ref/en-US/guvnor_preferences.xml
trunk/drools/docs/guvnor_ref/en-US/introduction.xml
trunk/drools/docs/guvnor_ref/en-US/master.xml
Log:
https://jira.jboss.org/jira/browse/TOOLSDOC-6 Show java-doc is shown for EL content assist item. Screenshot has been made.
TOOLSDOC-63 Eclipse Guvnor Tools Reference Guide restructureing and update. The Guide has been restructured.
Modified: trunk/drools/docs/guvnor_ref/en-US/conclusion.xml
===================================================================
--- trunk/drools/docs/guvnor_ref/en-US/conclusion.xml 2010-05-04 14:52:04 UTC (rev 21890)
+++ trunk/drools/docs/guvnor_ref/en-US/conclusion.xml 2010-05-04 14:52:27 UTC (rev 21891)
@@ -16,7 +16,39 @@
aspects of the current tooling that require revision going forward, we feel that the current
state of the <property>EGT</property> is sufficient for the major use cases.</para>
- <para>If you have some questions, comments or suggestions on the topic, please feel free to ask in the
+ <section>
+ <title>Other relevant resources on the topic</title>
+
+ <itemizedlist>
+ <listitem>
+ <para>Guvnor <ulink url="http://www.jboss.org/community/wiki/Guvnor">wiki page</ulink></para>
+ </listitem>
+
+ <listitem>
+ <para>Drools on <ulink url="http://www.jboss.org/drools/">JBoss.org</ulink></para>
+ </listitem>
+
+ <listitem>
+ <para>
+ <ulink url="http://www.jboss.org/tools/">JBoss Tools Home Page</ulink>
+ </para>
+ </listitem>
+
+ <listitem>
+ <para>
+ <ulink url="http://download.jboss.org/jbosstools/nightly-docs/">The latest
+ JBossTools/JBDS documentation builds</ulink>
+ </para>
+ </listitem>
+
+ <listitem>
+ <para>
+ <ulink url="http://docs.jboss.org/tools/">JBossTools/JBDS
+ release documentation</ulink></para>
+ </listitem>
+ </itemizedlist>
+ <para>If you have some questions, comments or suggestions on the topic, please feel free to ask in the
<ulink url="http://www.jboss.org/index.html?module=bb&op=viewforum&f=201"
>Jboss Tools Forum</ulink>.</para>
+ </section>
</chapter>
Modified: trunk/drools/docs/guvnor_ref/en-US/functionality_overview.xml
===================================================================
--- trunk/drools/docs/guvnor_ref/en-US/functionality_overview.xml 2010-05-04 14:52:04 UTC (rev 21890)
+++ trunk/drools/docs/guvnor_ref/en-US/functionality_overview.xml 2010-05-04 14:52:27 UTC (rev 21891)
@@ -8,265 +8,22 @@
</keywordset>
</chapterinfo>
- <title>Functionality Overview</title>
+ <title>Tasks</title>
- <para>This chapter will introduce you to the <property>Guvnor Repository Exploring
- perspective</property> and give an overview on all functionality the <property>Guvnor Tools</property> provides.</para>
-
- <section id="guvnor_perspective">
- <title>Guvnor Perspective</title>
-
- <para>The <property>Guvnor Repository Exploring perspective</property> contains two views
- supplied by <property>EGT</property> – <property>Repository Explorer</property> and
- <property>Version History</property>, that will be the center of most interaction
- with Guvnor, and Eclipse standard views such as <property>Properties</property> and
- <property>Resource Navigator</property> that are also useful.</para>
-
- <para>While each of these views can be opened and positioned independently within an Eclipse
- workbench, the <property>Guvnor perspective</property> provides a convenient method of
- getting a suggested layout. In the Eclipse workbench menu, choose <emphasis>
- <property>Window > Open Perspective > Other</property>
- </emphasis> to get the perspective list:</para>
-
- <figure>
- <title>Enabling the Guvnor Repository Perspective</title>
- <mediaobject>
- <imageobject>
- <imagedata fileref="images/functionality_overview/open_guvnor_perspectine.png"/>
- </imageobject>
- </mediaobject>
- </figure>
-
- <para>And then choose <emphasis>
- <property>Guvnor Repository Exploring</property>.</emphasis> This opens the
- <property>Guvnor perspective</property>.</para>
- </section>
-
- <section id="connection_wizard">
- <title>Guvnor Connection Wizard</title>
-
- <para>After opening the <property>Guvnor perspective</property>, the first task is to make a
- connection to a Guvnor repository. This is handled by the <property>Guvnor Connection
- wizard</property>. This wizard appears in a number of places within the
- <property>EGT</property> (as detailed below), but in this section we will cover only
- the two most basic entry points.</para>
-
- <para>The <property>Guvnor Connection wizard</property> can be started in the following
- ways:</para>
-
- <itemizedlist>
- <listitem>
- <para>using the Eclipse menu <emphasis>
- <property>File > New > Other > Guvnor > Guvnor
- repository location</property>
- </emphasis></para>
-
- <figure>
- <title>New Guvnor Repository Location</title>
- <mediaobject>
- <imageobject>
- <imagedata fileref="images/functionality_overview/start_guvnor_connection1.png"/>
- </imageobject>
- </mediaobject>
- </figure>
- </listitem>
-
- <listitem>
- <para>in the <property>Guvnor Repositories view</property> using the drop-down menu</para>
-
- <figure>
- <title>Adding New Guvnor Connection</title>
- <mediaobject>
- <imageobject>
- <imagedata fileref="images/functionality_overview/start_guvnor_connection2.png"/>
- </imageobject>
- </mediaobject>
- </figure>
- </listitem>
-
- <listitem>
- <para>using the menu button
- ( <inlinemediaobject>
- <imageobject>
- <imagedata fileref="images/functionality_overview/guvnor_connection_button.png"/>
- </imageobject>
- </inlinemediaobject> )
- </para>
- </listitem>
- </itemizedlist>
-
- <para>Choosing either of these will start the <property>Guvnor Connection
- wizard</property>.</para>
-
- <figure id="guvnor_connection_wizard">
- <title>Guvnor Connection Wizard</title>
- <mediaobject>
- <imageobject>
- <imagedata fileref="images/functionality_overview/guvnor_connection_wizard.png"/>
- </imageobject>
- </mediaobject>
- </figure>
-
- <para>Default values appear in the <emphasis>
- <property>Location</property>,</emphasis>
- <emphasis>
- <property>Port</property>,</emphasis> and <emphasis>
- <property>Repository</property>
- </emphasis> fields (See the <link linkend="guvnor_preferences">“Guvnor Preferences”</link> section below for details about how to
- change these default values.) Of course, any of these fields can be edited by typing in
- the corresponding text box. Drag-and-drop or paste into the <emphasis>
- <property>Location</property>
- </emphasis> field of a typical Guvnor repository URL such as:</para>
-
- <para>
- <emphasis>
- <property>http://localhost:8080/drools-guvnor/org.drools.guvnor.Guvnor/webdav</property>
- </emphasis>
- </para>
-
- <para>Results in the URL being parsed into the respective fields as well. The authentication
- information (user name and password) can optionally be stored in the Eclipse
- workbench's key-ring file based on the selection of <emphasis>
- <property>Save user name and password</property>.</emphasis></para>
-
- <note>
- <title>Note:</title>
- <para>If the authentication information is not stored in the key-ring, then the
- <property>EGT</property> uses a session authentication, what means that the
- credentials supplied are used only for the lifetime of the Eclipse workbench
- instance.</para>
- </note>
-
- <para>If authentication information is not stored in the key-ring or the authentication
- information (key-ring or session) is not valid, the <property>EGT</property> will prompt
- for authentication information when it has to access the Guvnor repository.</para>
-
- <para>If authentication fails, the <property>EGT</property> will retry once and then issue
- an authentication failure error.</para>
-
- <tip>
- <title>Tip:</title>
- <para>If an authentication failure error occurs, you can retry the same operation and
- supply different authentication information.</para>
- </tip>
-
- <para>Note that the <property>EGT</property> calls the Guvnor repository at various times,
- such as when determining if resource updates are available. Thus if you use session
- authentication, the authentication dialog will appear at different times during the
- Eclipse workbench session, depending on what actions you take. For ease of use, we
- recommend saving the authentication information in the Eclipse key-ring.</para>
-
- <note>
- <title>Note:</title>
- <para>The Eclipse key-ring file is distinct from key-ring files found in some platforms
- such as Mac OS X and many forms of Linux. Thus, sometimes if you access a Guvnor
- repository outside the <property>EGT</property>, the key-ring files might become
- unsynchronized and you will be unexpectedly prompted for authentication in Eclipse.
- This is nuisance, but your usual credentials should apply in this case.</para>
- </note>
- </section>
-
- <section id="guvnor_repositories_view">
- <title>Guvnor Repositories View</title>
-
- <para>The <property>Guvnor Repositories view</property> contains tree structures for Guvnor
- repository contents.</para>
-
- <figure>
- <title>Guvnor Repositories View</title>
- <mediaobject>
- <imageobject>
- <imagedata fileref="images/functionality_overview/guvnor_repository.png"/>
- </imageobject>
- </mediaobject>
- </figure>
-
- <para>You can perform the following actions under the resources in the
- <property>Guvnor Repositories view</property>:</para>
-
- <itemizedlist>
- <listitem>
- <para>create a new Guvnor repository connection. How to do this is describe above in the <link linkend="connection_wizard">"Guvnor Connection Wizard"</link> section.</para>
- </listitem>
-
- <listitem>
- <para>remove a Guvnor repository connection. Use the Delete button
- ( <inlinemediaobject>
- <imageobject>
- <imagedata fileref="images/functionality_overview/delete_connection_button.png"/>
- </imageobject>
- </inlinemediaobject> ) in the tool-bar or the <emphasis>
- <property>Delete</property></emphasis> option in the context menu to remove a repository connection.</para>
- </listitem>
-
- <listitem>
- <para>refresh Guvnor repository resorces. Use the <emphasis>
- <property>Refresh</property></emphasis> context menu item to reload a tree content for the selected node.</para>
- </listitem>
-
- <listitem>
- <para>make use of "drill-into" functionality. It's represented by a number of tool-bar/context menu items such as <emphasis><property>Go Home</property></emphasis>
- ( <inlinemediaobject>
- <imageobject>
- <imagedata fileref="images/functionality_overview/go_home_button.png"/>
- </imageobject>
- </inlinemediaobject> ), <emphasis><property>Go Back</property></emphasis>
- ( <inlinemediaobject>
- <imageobject>
- <imagedata fileref="images/functionality_overview/go_back_button.png"/>
- </imageobject>
- </inlinemediaobject> ) and <emphasis>
- <property>Go Into</property></emphasis>
- ( <inlinemediaobject>
- <imageobject>
- <imagedata fileref="images/functionality_overview/go_into_button.png"/>
- </imageobject>
- </inlinemediaobject> ).</para>
- </listitem>
- </itemizedlist>
-
- <para>Drill-down is useful when working with deeply nested tree structures and when you wish to concentrate on only branch of the tree. For example, drilling into the <emphasis>
- <property>"defaultPackage"</property></emphasis> node changes the tree view to:</para>
-
- <figure>
- <title>Going Into the <emphasis>"defaultPackage"</emphasis></title>
- <mediaobject>
- <imageobject>
- <imagedata fileref="images/functionality_overview/go_into_defaultPackage.png"/>
- </imageobject>
- </mediaobject>
- </figure>
-
- <para>Clicking on the Go Home button ( <inlinemediaobject>
- <imageobject>
- <imagedata fileref="images/functionality_overview/go_home_button.png"/>
- </imageobject>
- </inlinemediaobject> ) or selecting <emphasis>
- <property>Go Home</property></emphasis> in the context menu returns the tree to the top-level structure shown in the previous picture above.
- </para>
-
- <para>There are a number of operations that can be performed on Guvnor repository files. Selecting a file in
-the Guvnor repository causes the Eclipse <property>Properties view</property> to update with details about that file:
-</para>
-
- <figure>
- <title>Guvnor Repository Files Properties</title>
- <mediaobject>
- <imageobject>
- <imagedata fileref="images/functionality_overview/repository_files_properties.png"/>
- </imageobject>
- </mediaobject>
- </figure>
-
- <para></para>
- </section>
-
+ <para>This chapter will give an overview on all functionality the <property>Guvnor Tools</property> provides.</para>
+
+ <section > <!-- id="new_connection" -->
+ <title>Creating a New Guvnor Connection</title>
+ <para>As mentioned in the <link linkend="introduction">"Introduction"</link>, the main purpose
+ of the <property>EGT</property> is to allow development using resources held in a Guvnor
+ repository. The first task is to make a connection to a Guvnor repository.
+ This is handled by the <link linkend="connection_wizard">Guvnor Connection
+ wizard</link>. </para>
+ </section>
+
<section id="local_copies">
- <title>Local Copies of Guvnor Files</title>
-
- <para>As mentioned in the <link linkend="introduction">"Introduction"</link>, the main purpose
- of the <property>EGT</property> is to allow development using resources held in a Guvnor
- repository. There are two methods of getting local copies of Guvnor repository
+ <title>Getting Local Copies of Guvnor Files</title>
+ <para>There are two methods of getting local copies of Guvnor repository
resources:</para>
<orderedlist>
@@ -329,8 +86,76 @@
the revision number.</para>
</section>
+ <section id="resources_from_guvnor">
+ <title>Importing Guvnor Repository Resources</title>
+
+ <para>In addition to the single file drag-and-drop from the <property>Guvnor Repositories
+ view</property>, the <property>EGT</property> also includes a wizard for copying one
+ or more files from a Guvnor repository to the local workspace (and setting the
+ association with the Guvnor repository). This wizard is available from the <emphasis>
+ <property>File > Import > Guvnor > Resource from
+ Guvnor</property>
+ </emphasis> and the <emphasis>
+ <property>File > New > Other > Guvnor > Resource from
+ Guvnor</property>
+ </emphasis> menu items.</para>
+ <note>
+ <title>Note:</title>
+
+ <para>Note that the wizard is identical but appears in both locations to accommodate
+ users who tend to view this functionality as being in either category.</para>
+ </note>
+
+ <para>The first page of the wizard asks for the selection of the source Guvnor repository
+ and gives the choice to create a new Guvnor repository connection (in which case the
+ second page is the same as the <link linkend="guvnor_connection_wizard">Guvnor Connection wizard</link>).</para>
+
+ <figure>
+ <title>Resource from Guvnor Wizard</title>
+ <mediaobject>
+ <imageobject>
+ <imagedata fileref="images/functionality_overview/add_toGuvnor_wizard.png"/>
+ </imageobject>
+ </mediaobject>
+ </figure>
+
+ <para>Once the source Guvnor repository is chosen, the wizard prompts for resource selection:</para>
+
+ <figure>
+ <title>Resource Selection</title>
+ <mediaobject>
+ <imageobject>
+ <imagedata fileref="images/functionality_overview/resource_from_guvnor.png"/>
+ </imageobject>
+ </mediaobject>
+ </figure>
+
+ <para>Finally, the target location in the local workspace should be chosen:</para>
+ <figure>
+ <title>Choosing the Target Location</title>
+ <mediaobject>
+ <imageobject>
+ <imagedata fileref="images/functionality_overview/resource_from_guvnor2.png"/>
+ </imageobject>
+ </mediaobject>
+ </figure>
+
+ <para>On completion the wizard copies the selected files from the Guvnor repository to the local workspace.
+ If a file with the same name already exists in the destination, the wizard uses the Eclipse standard
+ "prompt for rename" dialog:</para>
+
+ <figure>
+ <title>Prompt for Rename Dialog</title>
+ <mediaobject>
+ <imageobject>
+ <imagedata fileref="images/functionality_overview/resource_from_guvnor3.png"/>
+ </imageobject>
+ </mediaobject>
+ </figure>
+ </section>
+
<section id="actions">
- <title>Actions for Local Guvnor Resources</title>
+ <title>Managing Guvnor Resources</title>
<para>The <property>EGT</property> provides a number of actions (available through the
<emphasis><property>Guvnor</property></emphasis> context menu on files) for working with files, both those associated with
@@ -598,130 +423,6 @@
and removes local metadata for the Guvnor repository association.</para>
</section>
</section>
-
- <section id="guvnor_history_view">
- <title>Guvnor Resource History View</title>
-
- <para>The <property>Guvnor Resource History view</property> should details about revision
- history for selected files, both local and those in Guvnor repositories. The initial
- state of this view is shown on the figure below.</para>
-
- <figure>
- <title>Initial State of the Guvnor Resource History View</title>
- <mediaobject>
- <imageobject>
- <imagedata fileref="images/functionality_overview/resource_history_view.png"/>
- </imageobject>
- </mediaobject>
- </figure>
-
- <para>The <property>Guvnor Resource History view</property> is populated by <emphasis>
- <property>Show History</property>
- </emphasis> actions in either the local <emphasis>
- <property>Guvnor</property></emphasis> context menu or in the context menu for
- a Guvnor repository file in the <link linkend="guvnor_repositories_view">Guvnor
- Repositories view</link>. Once this action is performed, the <property>Guvnor
- Resource History view</property> updates to show the revision history:</para>
-
- <figure>
- <title>IGuvnor Resource History View</title>
- <mediaobject>
- <imageobject>
- <imagedata fileref="images/functionality_overview/resource_history_view2.png"/>
- </imageobject>
- </mediaobject>
- </figure>
-
- <para>Here we see that the file <emphasis>
- <property>test.txt</property>
- </emphasis> has seven revisions. Double clicking on a revision row (or the context menu <emphasis>
- <property>Open (Read only)</property>)</emphasis> opens an Eclipse read-only editor
- with the revision contents.</para>
-
- <figure>
- <title>Eclipse Read-only Editor with the Revision Contents</title>
- <mediaobject>
- <imageobject>
- <imagedata fileref="images/functionality_overview/resource_history_view3.png"/>
- </imageobject>
- </mediaobject>
- </figure>
- <note>
- <title>Note:</title>
- <para>You can also use the <emphasis>
- <property>Save As...</property>
- </emphasis> option when a file is open in a read-only editor to save a local
- writable copy of the contents. Doing so, however, will not associate the file
- created with its Guvnor source.</para>
- </note>
-
- </section>
-
- <section id="resources_from_guvnor">
- <title>Importing Guvnor Repository Resources</title>
-
- <para>In addition to the single file drag-and-drop from the <property>Guvnor Repositories
- view</property>, the <property>EGT</property> also includes a wizard for copying one
- or more files from a Guvnor repository to the local workspace (and setting the
- association with the Guvnor repository). This wizard is available from the <emphasis>
- <property>File > Import > Guvnor > Resource from
- Guvnor</property>
- </emphasis> and the <emphasis>
- <property>File > New > Other > Guvnor > Resource from
- Guvnor</property>
- </emphasis> menu items.</para>
- <note>
- <title>Note:</title>
-
- <para>Note that the wizard is identical but appears in both locations to accommodate
- users who tend to view this functionality as being in either category.</para>
- </note>
-
- <para>The first page of the wizard asks for the selection of the source Guvnor repository
- and gives the choice to create a new Guvnor repository connection (in which case the
- second page is the same as the <link linkend="guvnor_connection_wizard">Guvnor Connection wizard</link>).</para>
-
- <figure>
- <title>Resource from Guvnor Wizard</title>
- <mediaobject>
- <imageobject>
- <imagedata fileref="images/functionality_overview/add_toGuvnor_wizard.png"/>
- </imageobject>
- </mediaobject>
- </figure>
-
- <para>Once the source Guvnor repository is chosen, the wizard prompts for resource selection:</para>
-
- <figure>
- <title>Resource Selection</title>
- <mediaobject>
- <imageobject>
- <imagedata fileref="images/functionality_overview/resource_from_guvnor.png"/>
- </imageobject>
- </mediaobject>
- </figure>
-
- <para>Finally, the target location in the local workspace should be chosen:</para>
- <figure>
- <title>Choosing the Target Location</title>
- <mediaobject>
- <imageobject>
- <imagedata fileref="images/functionality_overview/resource_from_guvnor2.png"/>
- </imageobject>
- </mediaobject>
- </figure>
-
- <para>On completion the wizard copies the selected files from the Guvnor repository to the local workspace.
- If a file with the same name already exists in the destination, the wizard uses the Eclipse standard
- "prompt for rename" dialog:</para>
-
- <figure>
- <title>Prompt for Rename Dialog</title>
- <mediaobject>
- <imageobject>
- <imagedata fileref="images/functionality_overview/resource_from_guvnor3.png"/>
- </imageobject>
- </mediaobject>
- </figure>
- </section>
+
+
</chapter>
Modified: trunk/drools/docs/guvnor_ref/en-US/guvnor_preferences.xml
===================================================================
--- trunk/drools/docs/guvnor_ref/en-US/guvnor_preferences.xml 2010-05-04 14:52:04 UTC (rev 21890)
+++ trunk/drools/docs/guvnor_ref/en-US/guvnor_preferences.xml 2010-05-04 14:52:27 UTC (rev 21891)
@@ -8,83 +8,390 @@
</keywordset>
</chapterinfo>
- <title>Guvnor Preferences</title>
-
- <para>The <property>EGT</property> provides a preference page in the <emphasis>
- <property>Guvnor</property>
- </emphasis> category:</para>
-
- <figure>
- <title>Resource Selection</title>
- <mediaobject>
- <imageobject>
- <imagedata fileref="images/guvnor_preferences/guvnor_preferences.png"/>
- </imageobject>
- </mediaobject>
- </figure>
-
- <para>The preferences cover two categories:</para>
- <itemizedlist>
- <listitem><para>Guvnor repository connections</para></listitem>
-
- <listitem><para>Local Guvnor
- repository resource decorations.</para></listitem>
- </itemizedlist>
-
- <section id="repo_connection_preferences">
- <title>Guvnor Repository Connection Preferences</title>
- <para>There are two preferences that can be set for Guvnor repository connections, that are
- used when creating new connections:</para>
-
+ <title>Reference</title>
+ <para>This chapter includes detailed reference information about Views and Wizards used to manage Guvnor Tools.</para>
+
+ <section id="guvnor_perspective">
+ <title>Guvnor Repository Exploring Perspective</title>
+
+ <para>The <property>Guvnor Repository Exploring perspective</property> contains two views
+ supplied by <property>EGT</property> – <property>Repository Explorer</property> and
+ <property>Version History</property>, that will be the center of most interaction
+ with Guvnor, and Eclipse standard views such as <property>Properties</property> and
+ <property>Resource Navigator</property> that are also useful.</para>
+
+ <para>While each of these views can be opened and positioned independently within an Eclipse
+ workbench, the <property>Guvnor perspective</property> provides a convenient method of
+ getting a suggested layout. In the Eclipse workbench menu, choose <emphasis>
+ <property>Window > Open Perspective > Other</property>
+ </emphasis> to get the perspective list:</para>
+
+ <figure>
+ <title>Enabling the Guvnor Repository Perspective</title>
+ <mediaobject>
+ <imageobject>
+ <imagedata fileref="images/functionality_overview/open_guvnor_perspectine.png"/>
+ </imageobject>
+ </mediaobject>
+ </figure>
+
+ <para>And then choose <emphasis>
+ <property>Guvnor Repository Exploring</property>.</emphasis> This opens the
+ <property>Guvnor perspective</property>.</para>
+ </section>
+ <section id="connection_wizard">
+ <title>Guvnor Connection Wizard</title>
+
+ <para>This wizard appears in a number of places within the
+ <property>EGT</property> (as detailed below), but in this section we will cover only
+ the two most basic entry points.</para>
+
+ <para>The <property>Guvnor Connection wizard</property> can be started in the following
+ ways:</para>
+
<itemizedlist>
<listitem>
- <para>The first is a default Guvnor repository URL template, which can make it
- easier to create multiple similar connections by simply changing part of the
- field, such as the host name.</para>
+ <para>using the Eclipse menu <emphasis>
+ <property>File > New > Other > Guvnor > Guvnor
+ repository location</property>
+ </emphasis></para>
+
+ <figure>
+ <title>New Guvnor Repository Location</title>
+ <mediaobject>
+ <imageobject>
+ <imagedata fileref="images/functionality_overview/start_guvnor_connection1.png"/>
+ </imageobject>
+ </mediaobject>
+ </figure>
</listitem>
+
<listitem>
- <para>The second is whether saving of authentication information in the Eclipse
- platform key-ring should be enabled by default.</para>
+ <para>in the <property>Guvnor Repositories view</property> using the drop-down menu</para>
+
+ <figure>
+ <title>Adding New Guvnor Connection</title>
+ <mediaobject>
+ <imageobject>
+ <imagedata fileref="images/functionality_overview/start_guvnor_connection2.png"/>
+ </imageobject>
+ </mediaobject>
+ </figure>
</listitem>
+
+ <listitem>
+ <para>using the menu button
+ ( <inlinemediaobject>
+ <imageobject>
+ <imagedata fileref="images/functionality_overview/guvnor_connection_button.png"/>
+ </imageobject>
+ </inlinemediaobject> )
+ </para>
+ </listitem>
</itemizedlist>
-
- <para>As with the Guvnor repository URL template, actually whether to save a specific
- instance of authentication information in the Eclipse platform key-ring can be
- determined when actually creating the connection. That is, both of these preferences are
- simply convenience values set to reasonable defaults.</para>
+
+ <para>Choosing either of these will start the <property>Guvnor Connection
+ wizard</property>.</para>
+
+ <figure id="guvnor_connection_wizard">
+ <title>Guvnor Connection Wizard</title>
+ <mediaobject>
+ <imageobject>
+ <imagedata fileref="images/functionality_overview/guvnor_connection_wizard.png"/>
+ </imageobject>
+ </mediaobject>
+ </figure>
+
+ <para>Default values appear in the <emphasis>
+ <property>Location</property>,</emphasis>
+ <emphasis>
+ <property>Port</property>,</emphasis> and <emphasis>
+ <property>Repository</property>
+ </emphasis> fields (See the <link linkend="guvnor_preferences">“Guvnor Preferences”</link> section below for details about how to
+ change these default values.) Of course, any of these fields can be edited by typing in
+ the corresponding text box. Drag-and-drop or paste into the <emphasis>
+ <property>Location</property>
+ </emphasis> field of a typical Guvnor repository URL such as:</para>
+
+ <para>
+ <emphasis>
+ <property>http://localhost:8080/drools-guvnor/org.drools.guvnor.Guvnor/webdav</property>
+ </emphasis>
+ </para>
+
+ <para>Results in the URL being parsed into the respective fields as well. The authentication
+ information (user name and password) can optionally be stored in the Eclipse
+ workbench's key-ring file based on the selection of <emphasis>
+ <property>Save user name and password</property>.</emphasis></para>
+
+ <note>
+ <title>Note:</title>
+ <para>If the authentication information is not stored in the key-ring, then the
+ <property>EGT</property> uses a session authentication, what means that the
+ credentials supplied are used only for the lifetime of the Eclipse workbench
+ instance.</para>
+ </note>
+
+ <para>If authentication information is not stored in the key-ring or the authentication
+ information (key-ring or session) is not valid, the <property>EGT</property> will prompt
+ for authentication information when it has to access the Guvnor repository.</para>
+
+ <para>If authentication fails, the <property>EGT</property> will retry once and then issue
+ an authentication failure error.</para>
+
+ <tip>
+ <title>Tip:</title>
+ <para>If an authentication failure error occurs, you can retry the same operation and
+ supply different authentication information.</para>
+ </tip>
+
+ <para>Note that the <property>EGT</property> calls the Guvnor repository at various times,
+ such as when determining if resource updates are available. Thus if you use session
+ authentication, the authentication dialog will appear at different times during the
+ Eclipse workbench session, depending on what actions you take. For ease of use, we
+ recommend saving the authentication information in the Eclipse key-ring.</para>
+
+ <note>
+ <title>Note:</title>
+ <para>The Eclipse key-ring file is distinct from key-ring files found in some platforms
+ such as Mac OS X and many forms of Linux. Thus, sometimes if you access a Guvnor
+ repository outside the <property>EGT</property>, the key-ring files might become
+ unsynchronized and you will be unexpectedly prompted for authentication in Eclipse.
+ This is nuisance, but your usual credentials should apply in this case.</para>
+ </note>
</section>
-
- <section id="resource_decoration_preferences">
- <title>Local Guvnor Repository Resource Decoration Preferences</title>
-
- <para>The second category of preferences provided by the <property>EGT</property> deals with how the decoration of
- local resources associated with Guvnor repository resources is presented. Since the
- Guvnor repository is not a substitute for a SCM, and since SCM tools in Eclipse tend to
- decorate local resources, it is useful to be able to control just how the <property>EGT</property> decorate
- its local resources to avoid messy conflicts with SCM packages.</para>
-
- <para>In the <emphasis>
- <property>File Decoration</property></emphasis>
- section of the preference page, you can choose the location (Top right, Top left, Bottom right,
- Bottom left) of the decoration icon, or you can choose not to display it. In
- the <emphasis>
- <property>Text</property></emphasis> section, you can format the Guvnor metadata that is appended to the file
- names:</para>
+ <section id="guvnor_repositories_view">
+ <title>Guvnor Repositories View</title>
+
+ <para>The <property>Guvnor Repositories view</property> contains tree structures for Guvnor
+ repository contents.</para>
+
+ <figure>
+ <title>Guvnor Repositories View</title>
+ <mediaobject>
+ <imageobject>
+ <imagedata fileref="images/functionality_overview/guvnor_repository.png"/>
+ </imageobject>
+ </mediaobject>
+ </figure>
+
+ <para>You can perform the following actions under the resources in the
+ <property>Guvnor Repositories view</property>:</para>
+
<itemizedlist>
<listitem>
- <para>Whether to show an indicator (>) when the local file has changes not committed back to the
- Guvnor repository</para>
+ <para>create a new Guvnor repository connection. How to do this is describe above in the <link linkend="connection_wizard">"Guvnor Connection Wizard"</link> section.</para>
</listitem>
+
<listitem>
- <para>Whether to show the revision number</para>
+ <para>remove a Guvnor repository connection. Use the Delete button
+ ( <inlinemediaobject>
+ <imageobject>
+ <imagedata fileref="images/functionality_overview/delete_connection_button.png"/>
+ </imageobject>
+ </inlinemediaobject> ) in the tool-bar or the <emphasis>
+ <property>Delete</property></emphasis> option in the context menu to remove a repository connection.</para>
</listitem>
+
<listitem>
- <para>Whether to show the date/time stamp</para>
- </listitem>
- </itemizedlist>
-
- <para>Any changes to these preferences take effect immediately upon clicking the <emphasis>
- <property>Apply</property></emphasis> and then <emphasis>
- <property>Ok</property></emphasis> buttons.</para>
+ <para>refresh Guvnor repository resorces. Use the <emphasis>
+ <property>Refresh</property></emphasis> context menu item to reload a tree content for the selected node.</para>
+ </listitem>
+
+ <listitem>
+ <para>make use of "drill-into" functionality. It's represented by a number of tool-bar/context menu items such as <emphasis><property>Go Home</property></emphasis>
+ ( <inlinemediaobject>
+ <imageobject>
+ <imagedata fileref="images/functionality_overview/go_home_button.png"/>
+ </imageobject>
+ </inlinemediaobject> ), <emphasis><property>Go Back</property></emphasis>
+ ( <inlinemediaobject>
+ <imageobject>
+ <imagedata fileref="images/functionality_overview/go_back_button.png"/>
+ </imageobject>
+ </inlinemediaobject> ) and <emphasis>
+ <property>Go Into</property></emphasis>
+ ( <inlinemediaobject>
+ <imageobject>
+ <imagedata fileref="images/functionality_overview/go_into_button.png"/>
+ </imageobject>
+ </inlinemediaobject> ).</para>
+ </listitem>
+ </itemizedlist>
+
+ <para>Drill-down is useful when working with deeply nested tree structures and when you wish to concentrate on only branch of the tree. For example, drilling into the <emphasis>
+ <property>"defaultPackage"</property></emphasis> node changes the tree view to:</para>
+
+ <figure>
+ <title>Going Into the <emphasis>"defaultPackage"</emphasis></title>
+ <mediaobject>
+ <imageobject>
+ <imagedata fileref="images/functionality_overview/go_into_defaultPackage.png"/>
+ </imageobject>
+ </mediaobject>
+ </figure>
+
+ <para>Clicking on the Go Home button ( <inlinemediaobject>
+ <imageobject>
+ <imagedata fileref="images/functionality_overview/go_home_button.png"/>
+ </imageobject>
+ </inlinemediaobject> ) or selecting <emphasis>
+ <property>Go Home</property></emphasis> in the context menu returns the tree to the top-level structure shown in the previous picture above.
+ </para>
+
+ <para>There are a number of operations that can be performed on Guvnor repository files. Selecting a file in
+ the Guvnor repository causes the Eclipse <property>Properties view</property> to update with details about that file:
+ </para>
+
+ <figure>
+ <title>Guvnor Repository Files Properties</title>
+ <mediaobject>
+ <imageobject>
+ <imagedata fileref="images/functionality_overview/repository_files_properties.png"/>
+ </imageobject>
+ </mediaobject>
+ </figure>
+
+ <para></para>
</section>
+ <section id="guvnor_history_view">
+ <title>Guvnor Resource History View</title>
+
+ <para>The <property>Guvnor Resource History view</property> should details about revision
+ history for selected files, both local and those in Guvnor repositories. The initial
+ state of this view is shown on the figure below.</para>
+
+ <figure>
+ <title>Initial State of the Guvnor Resource History View</title>
+ <mediaobject>
+ <imageobject>
+ <imagedata fileref="images/functionality_overview/resource_history_view.png"/>
+ </imageobject>
+ </mediaobject>
+ </figure>
+
+ <para>The <property>Guvnor Resource History view</property> is populated by <emphasis>
+ <property>Show History</property>
+ </emphasis> actions in either the local <emphasis>
+ <property>Guvnor</property></emphasis> context menu or in the context menu for
+ a Guvnor repository file in the <link linkend="guvnor_repositories_view">Guvnor
+ Repositories view</link>. Once this action is performed, the <property>Guvnor
+ Resource History view</property> updates to show the revision history:</para>
+
+ <figure>
+ <title>IGuvnor Resource History View</title>
+ <mediaobject>
+ <imageobject>
+ <imagedata fileref="images/functionality_overview/resource_history_view2.png"/>
+ </imageobject>
+ </mediaobject>
+ </figure>
+
+ <para>Here we see that the file <emphasis>
+ <property>test.txt</property>
+ </emphasis> has seven revisions. Double clicking on a revision row (or the context menu <emphasis>
+ <property>Open (Read only)</property>)</emphasis> opens an Eclipse read-only editor
+ with the revision contents.</para>
+
+ <figure>
+ <title>Eclipse Read-only Editor with the Revision Contents</title>
+ <mediaobject>
+ <imageobject>
+ <imagedata fileref="images/functionality_overview/resource_history_view3.png"/>
+ </imageobject>
+ </mediaobject>
+ </figure>
+ <note>
+ <title>Note:</title>
+ <para>You can also use the <emphasis>
+ <property>Save As...</property>
+ </emphasis> option when a file is open in a read-only editor to save a local
+ writable copy of the contents. Doing so, however, will not associate the file
+ created with its Guvnor source.</para>
+ </note>
+
+ </section>
+
+ <section id="preferences">
+ <title>Guvnor Preferences</title>
+
+
+ <para>The <property>EGT</property> provides a preference page in the <emphasis>
+ <property>Guvnor</property>
+ </emphasis> category:</para>
+
+ <figure>
+ <title>Resource Selection</title>
+ <mediaobject>
+ <imageobject>
+ <imagedata fileref="images/guvnor_preferences/guvnor_preferences.png"/>
+ </imageobject>
+ </mediaobject>
+ </figure>
+
+ <para>The preferences cover two categories:</para>
+ <itemizedlist>
+ <listitem><para>Guvnor repository connections</para></listitem>
+
+ <listitem><para>Local Guvnor
+ repository resource decorations.</para></listitem>
+ </itemizedlist>
+
+ <section id="repo_connection_preferences">
+ <title>Guvnor Repository Connection Preferences</title>
+ <para>There are two preferences that can be set for Guvnor repository connections, that are
+ used when creating new connections:</para>
+
+ <itemizedlist>
+ <listitem>
+ <para>The first is a default Guvnor repository URL template, which can make it
+ easier to create multiple similar connections by simply changing part of the
+ field, such as the host name.</para>
+ </listitem>
+ <listitem>
+ <para>The second is whether saving of authentication information in the Eclipse
+ platform key-ring should be enabled by default.</para>
+ </listitem>
+ </itemizedlist>
+
+ <para>As with the Guvnor repository URL template, actually whether to save a specific
+ instance of authentication information in the Eclipse platform key-ring can be
+ determined when actually creating the connection. That is, both of these preferences are
+ simply convenience values set to reasonable defaults.</para>
+ </section>
+
+ <section id="resource_decoration_preferences">
+ <title>Local Guvnor Repository Resource Decoration Preferences</title>
+
+ <para>The second category of preferences provided by the <property>EGT</property> deals with how the decoration of
+ local resources associated with Guvnor repository resources is presented. Since the
+ Guvnor repository is not a substitute for a SCM, and since SCM tools in Eclipse tend to
+ decorate local resources, it is useful to be able to control just how the <property>EGT</property> decorate
+ its local resources to avoid messy conflicts with SCM packages.</para>
+
+ <para>In the <emphasis>
+ <property>File Decoration</property></emphasis>
+ section of the preference page, you can choose the location (Top right, Top left, Bottom right,
+ Bottom left) of the decoration icon, or you can choose not to display it. In
+ the <emphasis>
+ <property>Text</property></emphasis> section, you can format the Guvnor metadata that is appended to the file
+ names:</para>
+ <itemizedlist>
+ <listitem>
+ <para>Whether to show an indicator (>) when the local file has changes not committed back to the
+ Guvnor repository</para>
+ </listitem>
+ <listitem>
+ <para>Whether to show the revision number</para>
+ </listitem>
+ <listitem>
+ <para>Whether to show the date/time stamp</para>
+ </listitem>
+ </itemizedlist>
+
+ <para>Any changes to these preferences take effect immediately upon clicking the <emphasis>
+ <property>Apply</property></emphasis> and then <emphasis>
+ <property>Ok</property></emphasis> buttons.</para>
+ </section>
+ </section>
</chapter>
Modified: trunk/drools/docs/guvnor_ref/en-US/introduction.xml
===================================================================
--- trunk/drools/docs/guvnor_ref/en-US/introduction.xml 2010-05-04 14:52:04 UTC (rev 21890)
+++ trunk/drools/docs/guvnor_ref/en-US/introduction.xml 2010-05-04 14:52:27 UTC (rev 21891)
@@ -8,15 +8,7 @@
comprehensive reference, there should be enough detail included for early adopters using
these tools.</para>
- <para>The <property>Guvnor repository</property> is not intended as a Source Code Management
- (SCM) solution, and the <property>EGT</property> are not intended to be Eclipse “team
- provider” extensions or replacements. Rather, the Guvnor repository is a location where
- certain artifacts (such as rules and SOA policy definitions) are controlled (“governed”) by
- policies defined by the deployment environment. The purpose of the <property>EGT</property>
- is then to enable access to resources held by the Guvnor repository, so
- they can be used in development. Thus, limited capabilities for reading, writing, adding,
- and removing Guvnor repository resources are provided in the
- <property>EGT</property>.</para>
+ <para>First, have a look at the key features of <property>Guvnor Tools:</property></para>
<section id="drools_key_features">
<title>Guvnor Tools Key Features</title>
@@ -114,9 +106,20 @@
</tgroup>
</table>
</section>
-
+ <section id="what_is_guvnor_tools">
+ <title>What is Guvnor Tools?</title>
+ <para>The <property>Guvnor repository</property> is not intended as a Source Code Management
+ (SCM) solution, and the <property>EGT</property> are not intended to be Eclipse “team
+ provider” extensions or replacements. Rather, the Guvnor repository is a location where
+ certain artifacts (such as rules and SOA policy definitions) are controlled (“governed”) by
+ policies defined by the deployment environment. The purpose of the <property>EGT</property>
+ is then to enable access to resources held by the Guvnor repository, so
+ they can be used in development. Thus, limited capabilities for reading, writing, adding,
+ and removing Guvnor repository resources are provided in the
+ <property>EGT</property>.</para>
+ </section>
<section id="how_to_start">
- <title>How to start with Guvnor Tools</title>
+ <title>Requirements and Installation</title>
<para><property>Guvnor Tools</property> is a part of the <property>JBoss Tools</property>
project. Thus to get started with Guvnor Tools, you should have the following:</para>
@@ -162,37 +165,4 @@
Eclipse synchronisation tool.</para>
</section>
- <section>
- <title>Other relevant resources on the topic</title>
-
- <itemizedlist>
- <listitem>
- <para>Guvnor <ulink url="http://www.jboss.org/community/wiki/Guvnor">wiki page</ulink></para>
- </listitem>
-
- <listitem>
- <para>Drools on <ulink url="http://www.jboss.org/drools/">JBoss.org</ulink></para>
- </listitem>
-
- <listitem>
- <para>
- <ulink url="http://www.jboss.org/tools/">JBoss Tools Home Page</ulink>
- </para>
- </listitem>
-
- <listitem>
- <para>
- <ulink url="http://download.jboss.org/jbosstools/nightly-docs/">The latest
- JBossTools/JBDS documentation builds</ulink>
- </para>
- </listitem>
-
- <listitem>
- <para>
- <ulink url="http://docs.jboss.org/tools/">JBossTools/JBDS
- release documentation</ulink></para>
- </listitem>
- </itemizedlist>
-
- </section>
</chapter>
Modified: trunk/drools/docs/guvnor_ref/en-US/master.xml
===================================================================
--- trunk/drools/docs/guvnor_ref/en-US/master.xml 2010-05-04 14:52:04 UTC (rev 21890)
+++ trunk/drools/docs/guvnor_ref/en-US/master.xml 2010-05-04 14:52:27 UTC (rev 21891)
@@ -2,7 +2,7 @@
<!DOCTYPE book PUBLIC "-//OASIS//DTD DocBook XML V4.3//EN"
"http://www.docbook.org/xml/4.3/docbookx.dtd"
-[<!ENTITY introduction SYSTEM "introduction.xml">
+[ <!ENTITY introduction SYSTEM "introduction.xml">
<!ENTITY functionality_overview SYSTEM "functionality_overview.xml">
<!ENTITY guvnor_preferences SYSTEM "guvnor_preferences.xml">
<!ENTITY conclusion SYSTEM "conclusion.xml">
@@ -40,7 +40,7 @@
<author><firstname>Olga</firstname><surname>Chikvina</surname></author>
<copyright>
- <year>2009</year>
+ <year>2009</year>
<year>2010</year>
<holder>JBoss by Red Hat</holder>
</copyright>
@@ -61,6 +61,5 @@
&introduction;
&functionality_overview;
&guvnor_preferences;
- &conclusion;
-
+ &conclusion;
</book>
14 years, 8 months
JBoss Tools SVN: r21890 - trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/web/validation/jsf2.
by jbosstools-commits@lists.jboss.org
Author: yzhishko
Date: 2010-05-04 10:52:04 -0400 (Tue, 04 May 2010)
New Revision: 21890
Modified:
trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/web/validation/jsf2/JSF2SourceValidator.java
Log:
Fixed VPE tests failing.
Modified: trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/web/validation/jsf2/JSF2SourceValidator.java
===================================================================
--- trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/web/validation/jsf2/JSF2SourceValidator.java 2010-05-04 14:47:34 UTC (rev 21889)
+++ trunk/jsf/plugins/org.jboss.tools.jsf/src/org/jboss/tools/jsf/web/validation/jsf2/JSF2SourceValidator.java 2010-05-04 14:52:04 UTC (rev 21890)
@@ -61,7 +61,11 @@
if (project == null) {
return;
}
- String filePath = helper.getURIs()[0];
+ String[] uris = helper.getURIs();
+ if (uris == null || uris.length < 1) {
+ return;
+ }
+ String filePath = uris[0];
if (filePath == null) {
return;
}
@@ -101,7 +105,11 @@
if (project == null) {
return;
}
- String filePath = helper.getURIs()[0];
+ String[] uris = helper.getURIs();
+ if (uris == null || uris.length < 1) {
+ return;
+ }
+ String filePath = uris[0];
if (filePath == null) {
return;
}
14 years, 8 months
JBoss Tools SVN: r21889 - in trunk/cdi: plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/impl and 3 other directories.
by jbosstools-commits@lists.jboss.org
Author: akazakov
Date: 2010-05-04 10:47:34 -0400 (Tue, 04 May 2010)
New Revision: 21889
Modified:
trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/core/IBeanManager.java
trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/core/IProducer.java
trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/impl/CDIProject.java
trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/impl/ProducerField.java
trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/impl/ProducerMethod.java
trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/validation/CDICoreValidator.java
trunk/cdi/plugins/org.jboss.tools.cdi.ui/src/org/jboss/tools/cdi/ui/preferences/CDIConfigurationBlock.java
trunk/cdi/tests/org.jboss.tools.cdi.core.test/src/org/jboss/tools/cdi/core/test/tck/ValidationTest.java
Log:
https://jira.jboss.org/jira/browse/JBIDE-2708 Added new CDI validation rules:
1. There is no producer method declared by the (same) bean class that is assignable to the disposed parameter of a disposer method.
2. There are multiple disposer methods for a single producer method
Modified: trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/core/IBeanManager.java
===================================================================
--- trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/core/IBeanManager.java 2010-05-04 14:12:34 UTC (rev 21888)
+++ trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/core/IBeanManager.java 2010-05-04 14:47:34 UTC (rev 21889)
@@ -232,6 +232,16 @@
Set<IBean> resolve(Set<IBean> beans);
/**
+ * Return the disposer methods which are bound to the producer method.
+ *
+ * @param producer
+ * a producer method
+ *
+ * @return bound disposer methods
+ */
+ Set<IBeanMethod> resolveDisposers(IProducerMethod producer);
+
+ /**
* Tests the given annotation type to determine if it is a scope type.
*
* @param annotationType
Modified: trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/core/IProducer.java
===================================================================
--- trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/core/IProducer.java 2010-05-04 14:12:34 UTC (rev 21888)
+++ trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/core/IProducer.java 2010-05-04 14:47:34 UTC (rev 21889)
@@ -17,4 +17,11 @@
*/
public interface IProducer extends IBean, IBeanMember {
+ /**
+ * Returns the @Produces annotation of this producer.
+ *
+ * @return the @Produces annotation of this producer
+ */
+ IAnnotationDeclaration getProducesAnnotation();
+
}
\ No newline at end of file
Modified: trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/impl/CDIProject.java
===================================================================
--- trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/impl/CDIProject.java 2010-05-04 14:12:34 UTC (rev 21888)
+++ trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/impl/CDIProject.java 2010-05-04 14:47:34 UTC (rev 21889)
@@ -35,12 +35,14 @@
import org.jboss.tools.cdi.core.IAnnotationDeclaration;
import org.jboss.tools.cdi.core.IBean;
import org.jboss.tools.cdi.core.IBeanMember;
+import org.jboss.tools.cdi.core.IBeanMethod;
import org.jboss.tools.cdi.core.ICDIProject;
import org.jboss.tools.cdi.core.IClassBean;
import org.jboss.tools.cdi.core.IInjectionPoint;
import org.jboss.tools.cdi.core.IObserverMethod;
import org.jboss.tools.cdi.core.IParametedType;
import org.jboss.tools.cdi.core.IProducer;
+import org.jboss.tools.cdi.core.IProducerMethod;
import org.jboss.tools.cdi.core.IQualifierDeclaration;
import org.jboss.tools.cdi.core.IStereotype;
import org.jboss.tools.cdi.internal.core.impl.definition.AnnotationDefinition;
@@ -558,6 +560,11 @@
return new HashSet<IObserverMethod>();
}
+ public Set<IBeanMethod> resolveDisposers(IProducerMethod producer) {
+ // TODO
+ return new HashSet<IBeanMethod>();
+ }
+
public CDIProject getCDIProject() {
return this;
}
Modified: trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/impl/ProducerField.java
===================================================================
--- trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/impl/ProducerField.java 2010-05-04 14:12:34 UTC (rev 21888)
+++ trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/impl/ProducerField.java 2010-05-04 14:47:34 UTC (rev 21889)
@@ -171,4 +171,8 @@
}
return getCDIProject().getScope(CDIConstants.DEPENDENT_ANNOTATION_TYPE_NAME);
}
+
+ public IAnnotationDeclaration getProducesAnnotation() {
+ return getDefinition().getProducesAnnotation();
+ }
}
\ No newline at end of file
Modified: trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/impl/ProducerMethod.java
===================================================================
--- trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/impl/ProducerMethod.java 2010-05-04 14:12:34 UTC (rev 21888)
+++ trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/impl/ProducerMethod.java 2010-05-04 14:47:34 UTC (rev 21889)
@@ -211,4 +211,7 @@
return getCDIProject().getScope(CDIConstants.DEPENDENT_ANNOTATION_TYPE_NAME);
}
-}
+ public IAnnotationDeclaration getProducesAnnotation() {
+ return produces;
+ }
+}
\ No newline at end of file
Modified: trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/validation/CDICoreValidator.java
===================================================================
--- trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/validation/CDICoreValidator.java 2010-05-04 14:12:34 UTC (rev 21888)
+++ trunk/cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/validation/CDICoreValidator.java 2010-05-04 14:47:34 UTC (rev 21889)
@@ -310,6 +310,32 @@
private void validateDisposers(IClassBean bean) {
Set<IBeanMethod> disposers = bean.getDisposers();
+ if(disposers.isEmpty()) {
+ return;
+ }
+
+ Set<IBeanMethod> boundDisposers = new HashSet<IBeanMethod>();
+ Set<IProducer> producers = bean.getProducers();
+ for (IProducer producer : producers) {
+ if(producer instanceof IProducerMethod) {
+ IProducerMethod producerMethod = (IProducerMethod)producer;
+ Set<IBeanMethod> disposerMethods = producer.getCDIProject().resolveDisposers(producerMethod);
+ boundDisposers.addAll(disposerMethods);
+ if(disposerMethods.size()>1) {
+ /*
+ * 3.3.7. Disposer method resolution
+ * - there are multiple disposer methods for a single producer method
+ */
+ for (IBeanMethod disposerMethod : disposerMethods) {
+ Set<ITextSourceReference> disposerDeclarations = getAnnotationPossitions(disposerMethod, CDIConstants.DISPOSES_ANNOTATION_TYPE_NAME);
+ for (ITextSourceReference declaration : disposerDeclarations) {
+ addError(CDIValidationMessages.MULTIPLE_DISPOSERS_FOR_PRODUCER, CDIPreferences.MULTIPLE_DISPOSERS_FOR_PRODUCER, declaration, bean.getResource());
+ }
+ }
+ }
+ }
+ }
+
for (IBeanMethod disposer : disposers) {
List<IParameter> params = disposer.getParameters();
@@ -399,9 +425,34 @@
addError(CDIValidationMessages.DISPOSER_IN_INTERCEPTOR, CDIPreferences.DISPOSER_IN_INTERCEPTOR_OR_DECORATOR, declaration, bean.getResource());
}
}
+
+ /*
+ * 3.3.7. Disposer method resolution
+ * - there is no producer method declared by the (same) bean class that is assignable to the disposed parameter of a disposer method
+ */
+ for (IBeanMethod disposerMethod : disposers) {
+ if(!boundDisposers.contains(disposerMethod)) {
+ for (ITextSourceReference declaration : disposerDeclarations) {
+ // TODO uncomment it when https://jira.jboss.org/jira/browse/JBIDE-6252 is resolved
+// addError(CDIValidationMessages.NO_PRODUCER_MATCHING_DISPOSER, CDIPreferences.NO_PRODUCER_MATCHING_DISPOSER, declaration, bean.getResource());
+ }
+ }
+ }
}
}
+ private Set<ITextSourceReference> getAnnotationPossitions(IBeanMethod method, String annotationTypeName) {
+ List<IParameter> params = method.getParameters();
+ Set<ITextSourceReference> declarations = new HashSet<ITextSourceReference>();
+ for (IParameter param : params) {
+ ITextSourceReference declaration = param.getAnnotationPosition(annotationTypeName);
+ if(declaration!=null) {
+ declarations.add(declaration);
+ }
+ }
+ return declarations;
+ }
+
/**
* If the method is not a static method and is not a business method of the session bean and is observer or disposer then mark it as incorrect.
*
Modified: trunk/cdi/plugins/org.jboss.tools.cdi.ui/src/org/jboss/tools/cdi/ui/preferences/CDIConfigurationBlock.java
===================================================================
--- trunk/cdi/plugins/org.jboss.tools.cdi.ui/src/org/jboss/tools/cdi/ui/preferences/CDIConfigurationBlock.java 2010-05-04 14:12:34 UTC (rev 21888)
+++ trunk/cdi/plugins/org.jboss.tools.cdi.ui/src/org/jboss/tools/cdi/ui/preferences/CDIConfigurationBlock.java 2010-05-04 14:47:34 UTC (rev 21889)
@@ -84,8 +84,8 @@
{CDIPreferences.MULTIPLE_DISPOSING_PARAMETERS, CDIPreferencesMessages.CDIValidatorConfigurationBlock_pb_multipleDisposingParameters_label},
{CDIPreferences.DISPOSER_ANNOTATED_INJECT, CDIPreferencesMessages.CDIValidatorConfigurationBlock_pb_disposerAnnotatedInject_label},
{CDIPreferences.ILLEGAL_DISPOSER_IN_SESSION_BEAN, CDIPreferencesMessages.CDIValidatorConfigurationBlock_pb_illegalDisposerInSessionBean_label},
-// {CDIPreferences.NO_PRODUCER_MATCHING_DISPOSER, CDIPreferencesMessages.CDIValidatorConfigurationBlock_pb_noProducerMatchingDisposer_label},
-// {CDIPreferences.MULTIPLE_DISPOSERS_FOR_PRODUCER, CDIPreferencesMessages.CDIValidatorConfigurationBlock_pb_multipleDisposersForProducer_label},
+ {CDIPreferences.NO_PRODUCER_MATCHING_DISPOSER, CDIPreferencesMessages.CDIValidatorConfigurationBlock_pb_noProducerMatchingDisposer_label},
+ {CDIPreferences.MULTIPLE_DISPOSERS_FOR_PRODUCER, CDIPreferencesMessages.CDIValidatorConfigurationBlock_pb_multipleDisposersForProducer_label},
// {CDIPreferences.ILLEGAL_PRODUCER_FIELD_IN_SESSION_BEAN, CDIPreferencesMessages.CDIValidatorConfigurationBlock_pb_illegalProducerFieldInSessionBean_label},
// {CDIPreferences.MULTIPLE_INJECTION_CONSTRUCTORS, CDIPreferencesMessages.CDIValidatorConfigurationBlock_pb_multipleInjectionConstructors_label},
// {CDIPreferences.CONSTRUCTOR_PARAMETER_ILLEGALLY_ANNOTATED, CDIPreferencesMessages.CDIValidatorConfigurationBlock_pb_constructorParameterIllegallyAnnotated_label},
Modified: trunk/cdi/tests/org.jboss.tools.cdi.core.test/src/org/jboss/tools/cdi/core/test/tck/ValidationTest.java
===================================================================
--- trunk/cdi/tests/org.jboss.tools.cdi.core.test/src/org/jboss/tools/cdi/core/test/tck/ValidationTest.java 2010-05-04 14:12:34 UTC (rev 21888)
+++ trunk/cdi/tests/org.jboss.tools.cdi.core.test/src/org/jboss/tools/cdi/core/test/tck/ValidationTest.java 2010-05-04 14:47:34 UTC (rev 21889)
@@ -240,15 +240,27 @@
/**
* 3.3.7. Disposer method resolution
- * TODO
+ * - there is no producer method declared by the (same) bean class that is assignable to the disposed parameter of a disposer method
*
* @throws Exception
*/
public void testUnresolvedDisposalMethod() throws Exception {
- //TODO
+ IFile file = tckProject.getFile("JavaSource/org/jboss/jsr299/tck/tests/implementation/disposal/method/definition/broken/unresolvedMethod/SpiderProducer_Broken.java");
+ AbstractResourceMarkerTest.assertMarkerIsCreated(file, AbstractResourceMarkerTest.MARKER_TYPE, CDIValidationMessages.NO_PRODUCER_MATCHING_DISPOSER, 35);
}
-
+
/**
+ * 3.3.7. Disposer method resolution
+ * - there are multiple disposer methods for a single producer method
+ *
+ * @throws Exception
+ */
+ public void testMultipleDisposersForProducer() throws Exception {
+ IFile file = tckProject.getFile("JavaSource/org/jboss/jsr299/tck/tests/jbt/validation/disposers/TimestampLogger_Broken.java");
+ AbstractResourceMarkerTest.assertMarkerIsCreated(file, AbstractResourceMarkerTest.MARKER_TYPE, CDIValidationMessages.MULTIPLE_DISPOSERS_FOR_PRODUCER, 13, 16);
+ }
+
+ /**
* 3.9.1. Declaring an initializer method
* - an initializer method has a parameter annotated @Disposes
*
14 years, 8 months
JBoss Tools SVN: r21888 - trunk/documentation/guides/JBDS_Release_Notes/en-US.
by jbosstools-commits@lists.jboss.org
Author: irooskov(a)redhat.com
Date: 2010-05-04 10:12:34 -0400 (Tue, 04 May 2010)
New Revision: 21888
Modified:
trunk/documentation/guides/JBDS_Release_Notes/en-US/Fixed_Issues.xml
Log:
updated with added JIRA
Modified: trunk/documentation/guides/JBDS_Release_Notes/en-US/Fixed_Issues.xml
===================================================================
--- trunk/documentation/guides/JBDS_Release_Notes/en-US/Fixed_Issues.xml 2010-05-04 13:35:07 UTC (rev 21887)
+++ trunk/documentation/guides/JBDS_Release_Notes/en-US/Fixed_Issues.xml 2010-05-04 14:12:34 UTC (rev 21888)
@@ -52,12 +52,11 @@
<ulink url="http://jira.jboss.com/jira/browse/JBIDE-6075">JBIDE-6075</ulink>: In the Hibernate reverse engineering editor it was impossible to add a parameter as the button to do so was missing. This update corrects the user interface to include the <guibutton>Add parameter</guibutton> button under the <guilabel>Id Generator details</guilabel> <guilabel>Class</guilabel> section.
</para>
</listitem>
- <!-- info still needed for issue listed below -->
- <!-- <listitem>
+ <listitem>
<para>
- <ulink url="http://jira.jboss.com/jira/browse/JBIDE-5960">JBIDE-5960</ulink>: A new <guibutton>Details ...</guibutton> button has been added to the <guilabel>Hibernate Settings</guilabel> section within the project properties. This added button displays....
+ <ulink url="http://jira.jboss.com/jira/browse/JBIDE-5960">JBIDE-5960</ulink>: A new <guibutton>Details ...</guibutton> button has been added to the <guilabel>Hibernate Settings</guilabel> section within the project properties. This added button displays the configuration wizard for the selected console (this wizard is also still available through the <guilabel>Console Configuration</guilabel> view). With the addition of this new button, a consoles configuration wizard is now more easily accessable to the user.
</para>
- </listitem> -->
+ </listitem>
</itemizedlist>
</para>
</formalpara>
14 years, 8 months
JBoss Tools SVN: r21887 - trunk/jsf/docs/jsf_tools_tutorial/en-US/images/jsf_application.
by jbosstools-commits@lists.jboss.org
Author: smukhina
Date: 2010-05-04 09:35:07 -0400 (Tue, 04 May 2010)
New Revision: 21887
Modified:
trunk/jsf/docs/jsf_tools_tutorial/en-US/images/jsf_application/jsf_application_5.png
Log:
TOOLSDOC-69-figure 4.1 should show added property - figure is updated
Modified: trunk/jsf/docs/jsf_tools_tutorial/en-US/images/jsf_application/jsf_application_5.png
===================================================================
(Binary files differ)
14 years, 8 months
JBoss Tools SVN: r21886 - trunk/esb/docs/esb_ref_guide/en-US.
by jbosstools-commits@lists.jboss.org
Author: smukhina
Date: 2010-05-04 09:32:03 -0400 (Tue, 04 May 2010)
New Revision: 21886
Modified:
trunk/esb/docs/esb_ref_guide/en-US/esb_support.xml
Log:
TOOLSDOC-66-Broken "IntsallingJBossTools" in esb tools ref guide - fixed
Modified: trunk/esb/docs/esb_ref_guide/en-US/esb_support.xml
===================================================================
--- trunk/esb/docs/esb_ref_guide/en-US/esb_support.xml 2010-05-04 11:26:47 UTC (rev 21885)
+++ trunk/esb/docs/esb_ref_guide/en-US/esb_support.xml 2010-05-04 13:32:03 UTC (rev 21886)
@@ -25,7 +25,7 @@
<para>ESB Tools come as one module of JBoss Tools project. Since ESB Tools have a
dependence on other JBoss Tools modules we recommend you to install a bundle
of all <ulink url="http://labs.jboss.com/tools/download.html">JBoss
- Tools plug-ins</ulink>. You can find all necessary installation instructions on JBoss Wiki in the <ulink url="http://labs.jboss.com/wiki/InstallingJBossTools"
+ Tools plug-ins</ulink>. You can find all necessary installation instructions on JBoss Wiki in the <ulink url="http://www.jboss.org/tools/download/installation"
>InstallingJBossTools</ulink> section.</para>
</section>
14 years, 8 months
JBoss Tools SVN: r21885 - branches/hibernatetools-multiversion/hibernatetools/plugins/org.hibernate.mediator/META-INF.
by jbosstools-commits@lists.jboss.org
Author: vyemialyanchyk
Date: 2010-05-04 07:26:47 -0400 (Tue, 04 May 2010)
New Revision: 21885
Modified:
branches/hibernatetools-multiversion/hibernatetools/plugins/org.hibernate.mediator/META-INF/MANIFEST.MF
Log:
https://jira.jboss.org/jira/browse/JBIDE-6070 - fix manifest.mf
Modified: branches/hibernatetools-multiversion/hibernatetools/plugins/org.hibernate.mediator/META-INF/MANIFEST.MF
===================================================================
--- branches/hibernatetools-multiversion/hibernatetools/plugins/org.hibernate.mediator/META-INF/MANIFEST.MF 2010-05-04 11:17:31 UTC (rev 21884)
+++ branches/hibernatetools-multiversion/hibernatetools/plugins/org.hibernate.mediator/META-INF/MANIFEST.MF 2010-05-04 11:26:47 UTC (rev 21885)
@@ -49,6 +49,7 @@
Bundle-Vendor: %Bundle-Vendor.0
Bundle-Localization: plugin
Export-Package: org.hibernate.mediator,
+ org.hibernate.mediator.base,
org.hibernate.mediator.execution,
org.hibernate.mediator.logging,
org.hibernate.mediator.preferences,
14 years, 8 months