Re: [jbosstools-dev] the "infamous" "does not have JSF code completion and validation enabled completed" dialog

actually - they got Dynamic web module, java and javascript facets. no jboss tools knowledge base.

actually - they got Dynamic web module, java and javascript facets. no jboss tools knowledge base. /max On Sep 13, 2011, at 19:16, Denis Golovin wrote: > Max, > > could you explain what you did step by step? > I tested M3 and M4 yesterday and never saw this dialog. > > Thanks > Denis > > On 09/13/2011 10:04 AM, Max Rydahl Andersen wrote: >>> Now we show this dialog only when KB nature is required, and there is a marker on the project that warns about that. When 'Enable JSF Code Completion' option in dialog is run, it just suggest the quick fix resolution of that marker (by adding KB nature/builder), nothing more. >> that's fine but the since it has nothing to do with JSF it shouldn't ask about JSF which is misleading to the user. >> >>> Marker is created in these cases only: >>> 1. Project has CDI or Seam or JSF nature but misses KB nature and/or builder. >>> 2. Project is a Java project used by another KB project. >>> The first case can never happen for newly created/imported/converted projects as KB nature is added automatically with CDI/Seam/JSF natures; this case can be reproduced only by manual removing KB nature/builder from such a project. >>> The second case is more common in a workspace with many dependent projects, but as we agreed, marker is added to the project with KB nature, and warns that it uses Java projects without KB nature. For resources on those Java project, no dialog will be run, because there is no marker on them. >>> >>> There is one funny exception for the developer environment, if you run JBDS with all available plugins, particularly with org.jboss.tools.jst.web.kb.test. This test plugin declares for the tests sake one more case: >>> 3. Project is any faceted project. >>> As currently most of projects are faceted, in the test environment you will have the annoying dialog almost everywhere. >> I just run JBoss Tools - it was the first dialog showing up to me when editing an xhmtl file I created. >> >> /max >> >>> Slava >>> >>> On 09/13/2011 06:10 AM, Max Rydahl Andersen wrote: >>>> Hey, >>>> >>>> I'm still getting it on new xhtml files in non-wtp projects. >>>> >>>> Didn't we remove this dialog or at least reword it since for many projects JSF is *not* relevant ? >>>> >>>> /max >>>> http://about.me/maxandersen >>>> >>>> >>>> >>>> >>>> _______________________________________________ >>>> jbosstools-dev mailing list >>>> jbosstools-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev >> /max >> http://about.me/maxandersen >> >> >> >> >> _______________________________________________ >> jbosstools-dev mailing list >> jbosstools-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/jbosstools-dev /max http://about.me/maxandersen