Re: [jbosstools-dev] Regarding copyright dates
On 19 Aug 2014, at 11:22, Rob Stryker wrote:
https://issues.jboss.org/browse/JBIDE-18014
I have some problems with this issue, and I think it needs to be
clarified. All of my complaints, though, all basically come down to
one
idea: I think it's inappropriate to bump the copyrights of files
that
have not changed.
I do to, but legal in past said it was necessary. I unfortunately cannot
find
that mail so I pinged Richard again to be sure this is a requirement.
I'll let you know when I have answer.
Are there any tools or easy git commands to tell what files have
been
changed and thus need updated copyrights?
Yes, git diff. What do you want to know specficaly ?
i.e. git diff --name-only "master@{360 day ago}" master
shows which files changes the last 360 days.
I have no intention on updating copyrights in the dozens of wildfly
/
jboss-as schema, since I have not modified them at all.
These are not part of what you should change. Those are bundled as
direct copies.
Not part of your projects copyright.
So those are not relevant to change and I don't believe that is what is
asked for in the jira.
This issue is really poorly defined, and I find it a little
annoying.
More thought needs to be spent on HOW to accomplish this goal, rather
than just pushing off to every developer the task of updating all
their
headers regardless of whether a file has changed in any way, or the
file
should be changed, or how to detect changed files.
I agree - I don't really understand why Nick decided this was better
done by having everyone
check this as opposed to just open PR to fix the trivial issue and just
leave the
tricky ones to each dev.
Furthermore, if you really do intend us all to update all files to
unify
/ standardize, then now would be a good time to tell us what header we
should be using across the board, since I still see various headers in
use in various places.
It actually is/was standardized long ago when we incorporated Exadel
studio.
For EPL its:
/*******************************************************************************
* Copyright (c) {year} Exadel, Inc. and Red Hat, Inc.
* Distributed under license by Red Hat, Inc. All rights reserved.
* This program is made available under the terms of the
* Eclipse Public License v1.0 which accompanies this distribution,
* and is available at http://www.eclipse.org/legal/epl-v10.html
*
* Contributors:
* {copyright owner} - initial API and implementation
******************************************************************************/
This was applied to all projects ages ago. If you see differences it is
probably
because of different license (i.e. AS hibernate still have LGPL) and/or
someone
not using the right header.
If we can standardize this stuff, then next time we can ensure
simple
greps can do the work for us. Ideally we'd be able to (for next major)
make a utility that can find all changed files since the end of last
year, perform the copyright update for us by replacing 20xx-2013 with
20xx-2014. We could then run this script every year. But this
depends
on all files having the same headers or at least the same header
format,
and that means we need to standardize 100% on this.
The jira is about standardizing it.
But now I'm seeing that this is stomping alot of work and also direct
mistruths (like it is okey
to remove original contributors).
I'm going to reject these jiras and we'll do this properly.
Lets not spend wasted energy on something not even yet required.
/max
http://about.me/maxandersen