The magic is simply "use the correct folder". We can't build the
unified tp unless the multiple one already exists. That's how it's
constructed. Only workarounds are the ones I documented in the devdoc:
build them at the same time but tell the unified to use the
locally-built multiple TP's URL, or don't build the unified one since
you don't need it anyway.
Is your complaint that we have a reactor pom in the root of
jbosstools/ and jbdevstudio/ which tries to build BOTH multiple and
unified at the same time, rather than in two steps?
If so I could remove unified from that pom on line 16:
Then you could verify from the jbosstools/ folder instead of the
jbosstools/multiple folder.
On Fri, Feb 19, 2016 at 12:39 PM, Max Rydahl Andersen
<manderse(a)redhat.com> wrote:
On 19 Feb 2016, at 15:31, Nick Boldt wrote:
Incomplete doc which made you run mvn from the wrong folder.
so my question still stands - why is it that we cannot just run mvn verify
in TP anymore ?
Just wondering since we normally do whatever we can to make builds not
require "to know magic" to build.
/max
Updated to include more info about multiple/pom.xml vs. unified/pom.xml.
https://github.com/jbosstools/jbosstools-devdoc/commit/1add2ef73a540983f8...
On Fri, Feb 19, 2016 at 2:24 AM, Max Rydahl Andersen
manderse(a)redhat.com wrote:
Yes - these docs says you can do "mvn clean verify" but that was not the
case for the Pr.
So that is why I'm asking - why didn't mvn clean verify work ? Incomplete PR
or outofdate docs ?
/max
http://about.me/maxandersen
On 19 Feb 2016, at 06:28, Nick Boldt nboldt(a)redhat.com wrote:
Building locally:
https://github.com/jbosstools/jbosstools-devdoc/blob/master/building/targ...
Verifying local changes to repo references to ensure IU versions are
updated too:
https://github.com/jbosstools/jbosstools-devdoc/blob/master/building/targ...
More:
https://github.com/jbosstools/jbosstools-devdoc/blob/master/building/targ...
On Fri, Feb 19, 2016 at 12:24 AM, Max Rydahl Andersen
manderse(a)redhat.com wrote:
Adding back the list.
I suspect you were in the wrong folder. When I build it, I only build
the multiple/pom.xml, not the unified one.
Gotcha. My bad. I missed the cd. Been too long since I build the tp locally.
Can you Remind me what is needed to build the full TP for these PRs ? i
thought once once could build these with a mvn verify.
/max
N
On Thu, Feb 18, 2016 at 5:47 PM, Max Rydahl Andersen
manderse(a)redhat.com wrote:
On 18 Feb 2016, at 20:07, Nick Boldt wrote:
Build target-platform:
$ cd /path/to/jbosstools-target-platforms/jbosstools/multiple
$ git fetch origin pull/195/head && git checkout FETCH\_HEAD
$ mvn clean install
I tried this and I got:
[INFO]
[INFO] --- build-helper-maven-plugin:1.3:attach-artifact (attach-artifacts)
@ jbdevstudio-unified ---
[INFO]
[INFO] --- target-platform-validation-plugin:0.23.1:validate-target-platform
(default) @ jbdevstudio-unified ---
[INFO] Validating
/Users/max/code/jbosstools/jbosstools-target-platforms/jbdevstudio/unified/target/jbdevstudio-unified.target...
[INFO] Adding repository
https://devstudio.redhat.com/targetplatforms/jbdevstudiotarget/4.52.0.CR1...
[INFO] Failed, see Error log below
[ERROR] Validation found errors in 1 .target files:
Could not resolve content of jbdevstudio-unified.target
Known issue ?
so in short, i'm all for getting the changes in but I cannot build any of
the suggested PR's
so I can't verify them. :/
/max
Then, to test the new "multiple" target platform against your component's
build:
$ cd /path/to/your/jbosstools-component
$ mvn clean verify -Dtpc.version=4.52.0.CR1-SNAPSHOT
-Dtpc.targetKind=multiple
/max
http://about.me/maxandersen
--
Nick Boldt :: JBoss by Red Hat
Productization Lead :: JBoss Tools & Dev Studio
http://nick.divbyzero.com
--
Nick Boldt :: JBoss by Red Hat
Productization Lead :: JBoss Tools & Dev Studio
http://nick.divbyzero.com
--
Nick Boldt :: JBoss by Red Hat
Productization Lead :: JBoss Tools & Dev Studio
http://nick.divbyzero.com
/max
http://about.me/maxandersen
--
Nick Boldt :: JBoss by Red Hat
Productization Lead :: JBoss Tools & Dev Studio