Re: [jbosstools-dev] Re: [Fwd: [Soa-tools-list] a rough esb project wizard is ready]

The runtime version is determined primarily in my code, the AS adapter, where I declare server / runtime types conforming with WTP. One of the issues here obviously is that I haven't added all the new possibilities and declared them. One thing we could do is put something like JBoss ESB 4.x as the runtime type name. The runtime types I currently have declared are: AS 3.2 AS 4.0 AS 4.2 AS 5.0 Obviously this leaves gaps and minor increments (4.2.2 etc), however I could not determine a reliable way to figure out what runtime version I had based on a server install location or a server configuration location. If I knew there was a reliable way to do that, I could have only ONE jboss server / runtime type and let it figure out what version it is, what jars to add, what start arguments to provide, and all other manners of logic dynamically. Unfortunately, since I couldn't find anything like that, I've declared those 4 runtime types above... and will obviously need to start adding ESB ones as well. I have an abstract class for JBoss Server types in general and then different instances extend to provide things such as start arguments, startup classpaths, and project classpaths.

I'm a little curious what Denny has done here, since I haven't looked at his code. One of the first things to note is that there are actually two different WTP types of "Runtime" classes. One is in org.eclipse.wst.common.project.facet.core.blahblah, and the other is in org.eclipse.wst.server. I'm actually not sure which of these two the wizard draws from. I see that his plugin.xml has declared facet versions, module factories, and org.eclipse.wst.common.project.facet.core.runtimes extensions, but he has not added an org.eclipse.wst.server.core.runtimeType or serverType extension point. I'm curious as to whether he has it able to start or stop the ESB or where that code should actually belong... as technically the ESB is really just a type of AS. Ideally we wouldn't be duplicating code all over the place... Just thought I'd elaborate a bit. As for whether it looks good, well, it looks just fine if we intend to stick with WTP, and it seems like we do intend to stick with WTP, and so in that case John Graham wrote: > I'd like to get some impressions about the usability of this wizard. > > First, however, a note: Denny is building this wizard within the > structures defined by WTP, and so the options are somewhat constrained. > > The first wizard page (attachment: esb-wizard-1.jpg) asks for a "Target > Runtime" and a "JBoss ESB Version." Unless we're expecting that multiple > ESB instances (and versions) can run in one AS configuration, then > ideally I think the ESB version should be determined automatically by > the wizard, based on the target runtime. Also, it seems that we are hard > coding the runtime values (4.2 and 4.3), whereas it would be better to > determine the version based on the target runtime (for instance, I had > JBoss ESB 4.4 installed, and it was confusing to have to select 4.3 for > it.) > > The second wizard page (attachment: esb-wizard-2.jpg) configures the > project structure and other meta-data (e.g. the facet). It asks for the > "JBoss ESB Runtime," but that was provided on the first page. I don't > see a use case where a different runtime value on the second page would > make sense, so I suggest that the wizard should just take the value from > the first page, and not show this detail on the second page. > > Don't know if this is related to the appearance of the Rosetta jar in > the project classpath or not: On my system (FC8), the drop down for > "JBoss ESB Runtime" did not work (attachement: esb-wizard-2-err.jpg); > instead a thin line appeared. > > -- John > > > > On Tue, 2008-09-09 at 16:37 +0800, Denny Xu wrote: > >> Hi Jeff >> I include some mail-lists, someone in the list may be interested in >> it too. >> >> >>> 1) The project wizard did not add jbossesb-rossetta.jar to the >>> classpath, I had to do this myself. >>> >> Did you specify a esb runtime when creating the project? I tested it >> and the jar is included in the classpath under "JBoss ESB Runtime" >> container. >> >>> 2) Providers shows up below services in the xml source, and the >>> providers element is red x and red underline with the message: >>> invalid content was found, no child elements expected. >>> 3) Filter would not always show up right away when creating a JMS >>> Provider Bus (thought we were going to name these channels?). If I >>> moved the "bus" up or down, or otherwise then it showed up. >>> 4) Should id be busid in the name (it is in the xml)? >>> 5) Under providers, JMS Provider, name should be selectable from a >>> list, e.g., JBossMQ? >>> >> about 2, 3, 4 and 5, it seems that it's something related to >> jboss-esb.xml editor, right? Max , do you have any comments? >> >>> It does not appear that you can create an esb archive or deploy yet, >>> so I did try that. >>> >> You can find the esb archive under jboss esb server deployment folder, >> such as: >> /home/fugang/jboss-all/jbossesb-server-4.3.GA/server/default/deploy >> it's a *.esb folder contains all stuff that a esb need. >> >> >> Denny >> >> >>> Jeff >>> >>> >>> >>> ----- Original Message ----- >>> From: "Denny Xu" <dxu(a)redhat.com&gt; >>> To: "Jeffrey Delong" <jdelong(a)redhat.com&gt; >>> Sent: Sunday, September 7, 2008 8:55:59 PM GMT -07:00 US/Canada >>> Mountain >>> Subject: Re: Fwd: [Fwd: [Soa-tools-list] a rough esb project wizard >>> is ready] >>> >>> Hi Jeff >>> >>> Jeffrey Delong wrote: >>> >>>> Hi Danny, >>>> >>>> Is this plugin compatible with Eclipse 3.4 (Ganymede) or 3.3 >>>> (Europa)? >>>> >>> Eclipse 3.4 is fine >>> >>>> Where specifically can I access the plugin? I would like to test it >>>> out? Is there a list of required dependencies? >>>> >>> the plugin has been added to nightly build, so you can get it from >>> jboss tools nightly build: >>> http://download.jboss.org/jbosstools/builds/nightly/, it requires >>> WTP 3.0. >>> >>> thanks very much to test it, if you have any suggestion and >>> requirement and any problem, please fell free to let me know. >>> >>> Thanks >>> Denny >>> >> _______________________________________________ >> Soa-tools-list mailing list >> Soa-tools-list(a)redhat.com >> https://www.redhat.com/mailman/listinfo/soa-tools-list >> >> ------------------------------------------------------------------------ >> >> >> ------------------------------------------------------------------------ >> >> >> ------------------------------------------------------------------------ >> >> ------------------------------------------------------------------------ >> >> _______________________________________________ >> jbosstools-dev mailing list >> jbosstools-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/jbosstools-dev _______________________________________________ Soa-tools-list mailing list Soa-tools-list(a)redhat.com https://www.redhat.com/mailman/listinfo/soa-tools-list