Hi, Max
The problem is that common isn't just common.
I suggest to split common. "True" common will contain only
org.jboss.tools.common
org.jboss.tools.common.model
org.jboss.tools.common.model.ui
org.jboss.tools.common.text.xml
part of org.jboss.tools.common.text.ext
Other plugins may be moved to org.jboss.tools.jst...
Or, may we physically leave plugins where they are, but for build and installation
purposes apply this logic separation 'virtually' by defining other set of
features?
Next, I will clean common.model from unnecessary references using new extension points.
As to what we have now, installing Hibernate Tools + common will not add jsf, jsp, etc
editors; and though common includes some excessive knowledge of jsp, jsf, struts, it does
not add any functionality.
Slava
----- Original Message -----
From: Max Rydahl Andersen
To: Viacheslav Kabanovich
Cc: vyemialyanchyk(a)exadel.com ; Exadel List ; jbosstools-dev(a)lists.jboss.org
Sent: Thursday, September 10, 2009 2:15 PM
Subject: Re: [jbosstools-dev] "Hibernate Configuration 3.0 XML Editor"
Viacheslav Kabanovich wrote:
Hi, Vitali,
I want to enhance this editor ("Hibernate Configuration 3.0 XML
Editor")
to make it more useful and I want to integrate it into Hibernate
Tools.
For this it is necessary to separate org.jboss.tools.hibernate.xml
and org.jboss.tools.hibernate.xml.ui, make it detached from XModel.
In my opinion that just means implementing new editor from scratch. In doing so, you
will develop components that you may wish to put to common. We have many xml editors,
there ui has a lot in common, so why not share new approaches between them? And that is
exactly what XModel framework does. Plugins .hibernate.xml and .hibernate.xml.ui include
just few lines of code customizing components developed in common. Why 'integrating
editor into Hibernate Tools' should mean separating it from common?
The problem is that common isn't just common. It includes ton's of jsf, xhtml,
jsp and even struts references. That is what we need separated before I'm ok having
Hibernate tools feature depend on it.
i.e. if I *only* install Hibernate tools feature it should *not* result in other
additional editors such as jsf, jsp, xhtml etc. to be installed.
That were the case last time I tried it - if that has changed we should look at it
again.
/max