[jbosstools-dev] Errors in org.jboss.ide.eclipse.as.test

1) ProjectRuntimeTest.testProjectRuntime() - java.lang.UnsupportedOperationException The verifyClasspathEntries method converts an array into a list as follows: List<String> list = Arrays.asList(required); This line creates a read-only list and the verifyClasspathEntries method tries to remove an item from the list. 2) JBIDE2512aTest.testJBIDE2512a() - NPE The AbstractDeploymentTest.copy method , line 146 tmp = getFileLocation("projects/TempProject/" + sourceProjectName); The tmp file doesn't exist because sourceProjectName is an array variable. Attached is a patch that fixes these errors. I haven't checked test failures. Snjeza PS These tests make changes in the org.jboss.ide.eclipse.as.test plugin that can break SVN (subclipse) when running in the PDE Runtime workbench. Index: E:/workspace-3.4M7-JBoss/plugins/org.jboss.ide.eclipse.as.test/src/org/jboss/ide/eclipse/as/test/classpath/ProjectRuntimeTest.java =================================================================== --- E:/workspace-3.4M7-JBoss/plugins/org.jboss.ide.eclipse.as.test/src/org/jboss/ide/eclipse/as/test/classpath/ProjectRuntimeTest.java (revision 11016) +++ E:/workspace-3.4M7-JBoss/plugins/org.jboss.ide.eclipse.as.test/src/org/jboss/ide/eclipse/as/test/classpath/ProjectRuntimeTest.java (working copy) @@ -21,7 +21,7 @@ */ package org.jboss.ide.eclipse.as.test.classpath; -import java.util.Arrays; +import java.util.ArrayList; import java.util.List; import junit.framework.TestCase; @@ -93,7 +93,10 @@ } protected void verifyClasspathEntries(IClasspathEntry[] entries, String[] required) { - List<String> list = Arrays.asList(required); + List<String> list = new ArrayList<String>(); + for (int i = 0; i < required.length; i++) { + list.add(required[i]); + } for( int i = 0; i < entries.length; i++ ) { if( list.contains(entries[i].getPath().segment(0))) list.remove(entries[i].getPath().segment(0)); Index: E:/workspace-3.4M7-JBoss/plugins/org.jboss.ide.eclipse.as.test/src/org/jboss/ide/eclipse/as/test/publishing/AbstractDeploymentTest.java =================================================================== --- E:/workspace-3.4M7-JBoss/plugins/org.jboss.ide.eclipse.as.test/src/org/jboss/ide/eclipse/as/test/publishing/AbstractDeploymentTest.java (revision 11016) +++ E:/workspace-3.4M7-JBoss/plugins/org.jboss.ide.eclipse.as.test/src/org/jboss/ide/eclipse/as/test/publishing/AbstractDeploymentTest.java (working copy) @@ -123,7 +123,7 @@ while( !done ) { srcKey = "copy" + i + "src"; destKey = "copy" + i + "dest"; - done = copy(props.getProperty(srcKey), props.getProperty(destKey)); + done = copy(props.getProperty(srcKey), props.getProperty(destKey),i); i++; } } catch (FileNotFoundException e) { @@ -134,14 +134,14 @@ } } - protected boolean copy(String src, String dest) throws CoreException { + protected boolean copy(String src, String dest,int i) throws CoreException { if( src == null || dest == null ) return true; // do the copy File srcFile, destFile, tmp; srcFile = getFileLocation("projectPieces/" + src); - tmp = getFileLocation("projects/TempProject/" + sourceProjectName); + tmp = getFileLocation("projects/TempProject/" + sourceProjectName[i-1]); destFile = new File(tmp, dest); FileUtil.fileSafeCopy(srcFile, destFile);