On 29 Apr 2015, at 17:45, Denis Golovin <dgolovin(a)exadel.com&gt; wrote: I suggested tagging modules that had no changes a while ago and was told no tagging required. That explains for example jbosstools-freemarker is missing 12 tags.

I would tag every module w/ and w/o changes, it can be done for all ow them using repo with submodules, becuase we are releasing them all together anyway.

Denis > On Wed, Apr 29, 2015 at 12:51 AM, Max Rydahl Andersen <manderse(a)redhat.com&gt; wrote: > I wrote a script to check how good/bad we were on actually having tags > for the various releases. > > First I found the ones missing the recent Alpha2 tag: > > jbosstools-arquillian > jbosstools-livereload > jbosstools-aerogear > jbosstools-hibernate > jbosstools-freemarker > jbosstools-webservices > jbosstools-server > jbosstools-portlet > jbosstools-download.jboss.org > jbosstools-central > jbosstools-build-ci > jbosstools-birt > > Then I thought about how it was looking for other releases so I made the > script a bit more advanced > (https://github.com/jbosstools/jbosstools-build/pull/182/files). > > It loads all historical tags of jbosstools-base and with a "since" > marker to not get false positives: > https://github.com/jbosstools/jbosstools-build/pull/182/files#diff-015178... > > With this the list is a tad longer (full details at: > https://gist.github.com/maxandersen/8e5c311b7b0f18c95e88) > > jbosstools-download.jboss.org missing 13 tags > jbosstools-freemarker missing 12 tags > jbosstools-server missing 13 tags > jbosstools-build-ci missing 8 tags > jbosstools-aerogear missing 6 tags > jbosstools-hibernate missing 6 tags > jbosstools-birt missing 5 tags > jbosstools-central missing 5 tags > jbosstools-portlet missing 5 tags > jbosstools-forge missing 4 tags > jbosstools-webservices missing 4 tags > jbosstools-build missing 3 tags > jbosstools-openshift missing 3 tags > jbosstools-build-sites missing 3 tags > jbosstools-vpe missing 2 tags > jbosstools-livereload missing 2 tags > jbosstools-arquillian missing 2 tags > jbosstools-jst missing 1 tags > jbosstools-discovery missing 1 tags > jbosstools-browsersim missing 1 tags > > If you believe my script reported wrongly on this please let me know and > otherwise i'll create a task jira for these next week. > > Thanks, > /max > http://about.me/maxandersen > > _______________________________________________ > jbosstools-dev mailing list > jbosstools-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jbosstools-dev

On 29 Apr 2015, at 19:34, Denis Golovin <dgolovin(a)exadel.com&gt; wrote: with https://github.com/dgolovin/jbosstools-releng.git tagging of everything at once would look like: git submodule foreach 'git checkout jbosstools-4.3.0.Alpha2x; git pull origin jbosstools-4.3.0.Alpha2x; git tag jbosstools-4.3.0.Alpha2; git push origin jbosstools-4.3.0.Alpha2;' The same can be done with shell or any script we want to use.

Denis > On Wed, Apr 29, 2015 at 9:57 AM, Max Rydahl Andersen <manderse(a)redhat.com&gt; wrote: > >> On 29 Apr 2015, at 17:45, Denis Golovin <dgolovin(a)exadel.com&gt; wrote: >> >> I suggested tagging modules that had no changes a while ago and was told no tagging required. That explains for example jbosstools-freemarker is missing 12 tags. > > Did I say that ? Then I was for sure wrong Imo with our current setup. > > Should be easy to fix then too :) > >> I would tag every module w/ and w/o changes, it can be done for all ow them using repo with submodules, becuase we are releasing them all together anyway. > > Sorry - not following how sub modules relate here ? > >> >> Denis >> >>> On Wed, Apr 29, 2015 at 12:51 AM, Max Rydahl Andersen <manderse(a)redhat.com&gt; wrote: >>> I wrote a script to check how good/bad we were on actually having tags >>> for the various releases. >>> >>> First I found the ones missing the recent Alpha2 tag: >>> >>> jbosstools-arquillian >>> jbosstools-livereload >>> jbosstools-aerogear >>> jbosstools-hibernate >>> jbosstools-freemarker >>> jbosstools-webservices >>> jbosstools-server >>> jbosstools-portlet >>> jbosstools-download.jboss.org >>> jbosstools-central >>> jbosstools-build-ci >>> jbosstools-birt >>> >>> Then I thought about how it was looking for other releases so I made the >>> script a bit more advanced >>> (https://github.com/jbosstools/jbosstools-build/pull/182/files). >>> >>> It loads all historical tags of jbosstools-base and with a "since" >>> marker to not get false positives: >>> https://github.com/jbosstools/jbosstools-build/pull/182/files#diff-015178... >>> >>> With this the list is a tad longer (full details at: >>> https://gist.github.com/maxandersen/8e5c311b7b0f18c95e88) >>> >>> jbosstools-download.jboss.org missing 13 tags >>> jbosstools-freemarker missing 12 tags >>> jbosstools-server missing 13 tags >>> jbosstools-build-ci missing 8 tags >>> jbosstools-aerogear missing 6 tags >>> jbosstools-hibernate missing 6 tags >>> jbosstools-birt missing 5 tags >>> jbosstools-central missing 5 tags >>> jbosstools-portlet missing 5 tags >>> jbosstools-forge missing 4 tags >>> jbosstools-webservices missing 4 tags >>> jbosstools-build missing 3 tags >>> jbosstools-openshift missing 3 tags >>> jbosstools-build-sites missing 3 tags >>> jbosstools-vpe missing 2 tags >>> jbosstools-livereload missing 2 tags >>> jbosstools-arquillian missing 2 tags >>> jbosstools-jst missing 1 tags >>> jbosstools-discovery missing 1 tags >>> jbosstools-browsersim missing 1 tags >>> >>> If you believe my script reported wrongly on this please let me know and >>> otherwise i'll create a task jira for these next week. >>> >>> Thanks, >>> /max >>> http://about.me/maxandersen >>> >>> _______________________________________________ >>> jbosstools-dev mailing list >>> jbosstools-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev

On 01 May 2015, at 16:51, Rob Stryker <rstryker(a)redhat.com&gt; wrote: > On 04/29/2015 01:54 PM, Max Rydahl Andersen wrote: > I would prefer it actually tagged the sha1 that was used instead of > just assumed used. Are we any closer to this happening? What's still 'missing' to make this a possibility? _______________________________________________ jbosstools-dev mailing list jbosstools-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jbosstools-dev

Maybe I'm missing something, but, how do we go and accurately tag previous releases? Do we have the old SHA tags stored somewhere for old builds? Otherwise I don't see how its possible to go and accurately tag our previous releases.

On 05/01/2015 05:11 PM, Max Rydahl Andersen wrote: > If you want the 100% method we need to build from the tag, meaning > Dev need start doing their tags and declare them into the build. > > But can we tackle one issue at the time, please :) > > I would like to at least have our past final releases tagged > consistently. > > We got it for most - just a few stands out. > > /max > http://about.me/maxandersen > > >> On 01 May 2015, at 16:51, Rob Stryker <rstryker(a)redhat.com&gt; wrote: >> >>> On 04/29/2015 01:54 PM, Max Rydahl Andersen wrote: >>> I would prefer it actually tagged the sha1 that was used instead of >>> just assumed used. >> Are we any closer to this happening? What's still 'missing' to make >> this a possibility? >> _______________________________________________ >> jbosstools-dev mailing list >> jbosstools-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/jbosstools-dev

Whoah, now. Tagging the tip of the 4.2.x branch and calling it something like 4.2.1.Final is a bad, and inaccurate plan.

If you need to dig up the SHAs for a given historical build, they can be found here: http://download.jboss.org/jbosstools/builds/stable For example, the SHAs that went into JBT 4.2.1.Final are here: http://download.jboss.org/jbosstools/builds/stable/jbosstools-4.2.1.Final...

As to the actual steps for tagging from a SHA... I'm no gitsplainer, but I believe this is all you need to do: git tag <tagname> <SHA-of-the-commit> If that's incorrect, I'm sure Max will correct me. Nick On 05/01/2015 09:23 PM, Max Rydahl Andersen wrote: > On 1 May 2015, at 23:33, Rob Stryker wrote: > >> Maybe I'm missing something, but, how do we go and accurately tag >> previous releases? Do we have the old SHA tags stored somewhere for >> old builds? Otherwise I don't see how its possible to go and >> accurately tag our previous releases. > > That is what I asked Nick about since we have been supposed to gather > that for all builds. Waiting for the answer. > > But if not there, then you can start by tagging the tip of the branch > they should have been made on. > > /max > > >> >> On 05/01/2015 05:11 PM, Max Rydahl Andersen wrote: >>> If you want the 100% method we need to build from the tag, meaning >>> Dev need start doing their tags and declare them into the build. >>> >>> But can we tackle one issue at the time, please :) >>> >>> I would like to at least have our past final releases tagged >>> consistently. >>> >>> We got it for most - just a few stands out. >>> >>> /max >>> http://about.me/maxandersen >>> >>> >>>> On 01 May 2015, at 16:51, Rob Stryker <rstryker(a)redhat.com&gt; wrote: >>>> >>>>> On 04/29/2015 01:54 PM, Max Rydahl Andersen wrote: >>>>> I would prefer it actually tagged the sha1 that was used instead >>>>> of >>>>> just assumed used. >>>> Are we any closer to this happening? What's still 'missing' to >>>> make >>>> this a possibility? >>>> _______________________________________________ >>>> jbosstools-dev mailing list >>>> jbosstools-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev > > > /max > http://about.me/maxandersen > _______________________________________________ > jbosstools-dev mailing list > jbosstools-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jbosstools-dev > -- Nick Boldt :: JBoss by Red Hat Productization Lead :: JBoss Tools & Dev Studio http://nick.divbyzero.com _______________________________________________ jbosstools-dev mailing list jbosstools-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jbosstools-dev

``` jbosstools-build missing 1 tags: jbosstools-4.0.0.Final jbosstools-build-ci missing 3 tags: jbosstools-4.0.0.Final, jbosstools-4.1.1.Final, jbosstools-4.2.0.Final jbosstools-build-sites missing 2 tags: jbosstools-4.0.0.Final, jbosstools-4.1.0.Final jbosstools-download.jboss.org missing 6 tags: jbosstools-4.0.0.Final, jbosstools-4.1.0.Final, jbosstools-4.1.1.Final, jbosstools-4.2.0.Final, jbosstools-4.2.1.Final, jbosstools-4.2.2.Final ``` Nick - those are maintained by you. Do you have some way to find the right sha's for these ?

Note: We still are missing the milestones I'm sure we got others missing, but now fixed the ones that are sure. [1] the files are not easily parseable - something we should make sure we have going forward.