2 issues were introduced in JBoss Central with the latest stacks.yaml update : - 2 archetype versions use the same html5-mobile tag : 2.4.0.Final and 2.4.0-build-1. But JBT, using org.apache.maven.artifact.versioning.ComparableVersion, finds 2.4.0-build-1 is higher than 2.4.0.Final and uses it as the most recent version. Since 2.4.0-build-1 dependencies haven't been released as part of WFK 2.4, the generated project fails to build because of missing deps. lastWFKArchetypeRelease should be updated to 2.4.0.Final in https://github.com/jboss-jdf/jdf-stack/blob/1.0.0.Final/stacks.yaml - There's a blank html5 archetype, pointing at the non-blank one, which makes JBoss Central wizards to enable a useless 'use blank' checkbox. Why keep it referenced? Fred _______________________________________________ jdf-dev mailing list jdf-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jdf-dev

Thanks Rafael, that fixed the main issue. However, the essential dependencies are incorrect, here's a PR fixing them : https://github.com/jboss-jdf/jdf-stack/pull/28 Now this lead me to find a severe issue in JBoss Central (https://issues.jboss.org/browse/JBIDE-16170), where we display a warning about these missing dependencies only if the user selects an enterprise runtime which is really really bad. We have 2 solutions : - respin JBT/JBDS for GA with a fix - make stacks.yaml point at the old html5 archetype, with a target:community label, effectively using a different archetype if a non-enterprise runtime is selected. WDYT? Fred Le 29/11/2013 21:14, Rafael Benevides a écrit : > I hope this commit fixes the issues: > https://github.com/jboss-jdf/jdf-stack/commit/49134b900 > > Please, let me know of any additional issues. > > Thanks for the report. > > Em 29/11/13 15:26, Fred Bricon escreveu: >> 2 issues were introduced in JBoss Central with the latest stacks.yaml >> update : >> >> - 2 archetype versions use the same html5-mobile tag : 2.4.0.Final and >> 2.4.0-build-1. But JBT, using >> org.apache.maven.artifact.versioning.ComparableVersion, finds >> 2.4.0-build-1 is higher than 2.4.0.Final and uses it as the most recent >> version. Since 2.4.0-build-1 dependencies haven't been released as part >> of WFK 2.4, the generated project fails to build because of missing >> deps. lastWFKArchetypeRelease should be updated to 2.4.0.Final in >> https://github.com/jboss-jdf/jdf-stack/blob/1.0.0.Final/stacks.yaml >> >> - There's a blank html5 archetype, pointing at the non-blank one, which >> makes JBoss Central wizards to enable a useless 'use blank' checkbox. >> Why keep it referenced? >> >> Fred >> >> _______________________________________________ >> jdf-dev mailing list >> jdf-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/jdf-dev >

Le lundi 2 décembre 2013 21:07:09, Rafael Benevides a écrit : > Hi Fred! > > I merged your PR. > Thanks > I think that the second proposed solution is better because it doesn't > evolve any respin with a fix and the result as I understood is the > same. Do you agree ? +1. Can you do a PR I can try tomorrow morning? > > Em 02/12/13 16:28, Fred Bricon escreveu: >> Thanks Rafael, that fixed the main issue. However, the essential >> dependencies are incorrect, here's a PR fixing them : >> https://github.com/jboss-jdf/jdf-stack/pull/28 >> >> Now this lead me to find a severe issue in JBoss Central >> (https://issues.jboss.org/browse/JBIDE-16170), where we display a >> warning about these missing dependencies only if the user selects an >> enterprise runtime which is really really bad. >> >> We have 2 solutions : >> - respin JBT/JBDS for GA with a fix >> - make stacks.yaml point at the old html5 archetype, with a >> target:community label, effectively using a different archetype if a >> non-enterprise runtime is selected. >> >> WDYT? >> >> Fred >> >> >> >> Le 29/11/2013 21:14, Rafael Benevides a écrit : >>> I hope this commit fixes the issues: >>> https://github.com/jboss-jdf/jdf-stack/commit/49134b900 >>> >>> Please, let me know of any additional issues. >>> >>> Thanks for the report. >>> >>> Em 29/11/13 15:26, Fred Bricon escreveu: >>>> 2 issues were introduced in JBoss Central with the latest stacks.yaml >>>> update : >>>> >>>> - 2 archetype versions use the same html5-mobile tag : 2.4.0.Final and >>>> 2.4.0-build-1. But JBT, using >>>> org.apache.maven.artifact.versioning.ComparableVersion, finds >>>> 2.4.0-build-1 is higher than 2.4.0.Final and uses it as the most >>>> recent >>>> version. Since 2.4.0-build-1 dependencies haven't been released as >>>> part >>>> of WFK 2.4, the generated project fails to build because of missing >>>> deps. lastWFKArchetypeRelease should be updated to 2.4.0.Final in >>>> https://github.com/jboss-jdf/jdf-stack/blob/1.0.0.Final/stacks.yaml >>>> >>>> - There's a blank html5 archetype, pointing at the non-blank one, >>>> which >>>> makes JBoss Central wizards to enable a useless 'use blank' checkbox. >>>> Why keep it referenced? >>>> >>>> Fred >>>> >>>> _______________________________________________ >>>> jdf-dev mailing list >>>> jdf-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/jdf-dev >>> >> > _______________________________________________ jdf-dev mailing list jdf-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jdf-dev

Max, What do you mean by examples ?

If you were talking about the Archetypes, I tried to keep them but it seems that Fred had an issue with duplicated archetypes version. Or am I missing something?

Em 02/12/13 21:07, Max Rydahl Andersen escreveu: >Another issue I see here is why we are *removing* examples from stacks ? > >it should just be adding, not removing examples since that would >invalidate JBDS 7.0 afaics. > >/max > >On Mon, Dec 02, 2013 at 10:59:28PM +0100, Fred Bricon wrote: >>Le lundi 2 décembre 2013 21:07:09, Rafael Benevides a écrit : >>>Hi Fred! >>> >>>I merged your PR. >>> >>Thanks >> >>>I think that the second proposed solution is better because it doesn't >>>evolve any respin with a fix and the result as I understood is the >>>same. Do you agree ? >>+1. Can you do a PR I can try tomorrow morning? >> >>> >>>Em 02/12/13 16:28, Fred Bricon escreveu: >>>>Thanks Rafael, that fixed the main issue. However, the essential >>>>dependencies are incorrect, here's a PR fixing them : >>>>https://github.com/jboss-jdf/jdf-stack/pull/28 >>>> >>>>Now this lead me to find a severe issue in JBoss Central >>>>(https://issues.jboss.org/browse/JBIDE-16170), where we display a >>>>warning about these missing dependencies only if the user selects an >>>>enterprise runtime which is really really bad. >>>> >>>>We have 2 solutions : >>>>- respin JBT/JBDS for GA with a fix >>>>- make stacks.yaml point at the old html5 archetype, with a >>>>target:community label, effectively using a different archetype if a >>>>non-enterprise runtime is selected. >>>> >>>>WDYT? >>>> >>>>Fred >>>> >>>> >>>> >>>>Le 29/11/2013 21:14, Rafael Benevides a écrit : >>>>>I hope this commit fixes the issues: >>>>>https://github.com/jboss-jdf/jdf-stack/commit/49134b900 >>>>> >>>>>Please, let me know of any additional issues. >>>>> >>>>>Thanks for the report. >>>>> >>>>>Em 29/11/13 15:26, Fred Bricon escreveu: >>>>>>2 issues were introduced in JBoss Central with the latest >>>>>>stacks.yaml >>>>>>update : >>>>>> >>>>>>- 2 archetype versions use the same html5-mobile tag : >>>>>>2.4.0.Final and >>>>>>2.4.0-build-1. But JBT, using >>>>>>org.apache.maven.artifact.versioning.ComparableVersion, finds >>>>>>2.4.0-build-1 is higher than 2.4.0.Final and uses it as the most >>>>>>recent >>>>>>version. Since 2.4.0-build-1 dependencies haven't been released as >>>>>>part >>>>>>of WFK 2.4, the generated project fails to build because of missing >>>>>>deps. lastWFKArchetypeRelease should be updated to 2.4.0.Final in >>>>>>https://github.com/jboss-jdf/jdf-stack/blob/1.0.0.Final/stacks.yaml >>>>>> >>>>>>- There's a blank html5 archetype, pointing at the non-blank one, >>>>>>which >>>>>>makes JBoss Central wizards to enable a useless 'use >>>>>>blank' checkbox. >>>>>>Why keep it referenced? >>>>>> >>>>>>Fred >>>>>> >>>>>>_______________________________________________ >>>>>>jdf-dev mailing list >>>>>>jdf-dev(a)lists.jboss.org >>>>>>https://lists.jboss.org/mailman/listinfo/jdf-dev >>>>> >>>> >>> >> >> >>_______________________________________________ >>jdf-dev mailing list >>jdf-dev(a)lists.jboss.org >>https://lists.jboss.org/mailman/listinfo/jdf-dev