Hi Michael,
Great that you are trying to fix JBIDE-611.
Got some comments on that:
1) Any way that this could be done in the hibernate tools plugin
instead of the unrelated diagram plugin ? (I don't see you are using any
new plugins for this so should be in the core of hibernate tools imo)
2) Please don't use bogus id's in our plugin.xml like: com.xyz.runXYZ,
it should be something stable and resembling the other id's.
3) This code looks like it is assuming everything are done in mapping
files and with a cfg.xml file; is that correct ? What about annotated
classes?
4) you have copied a large chunk of code from hibernate tools plugin to
locate the default project; why don't you use the existing code for that ?
/max
Show replies by date