Hi, I think purpose of package org/jboss/tools/ui/bot/ext/test is to offer some tools/utils/templates for test developers. Actually test suite org.jboss.tools.ui.bot.ext.test.config.Suite I think has no sense. This suite is testing templates for tests not real tests which should be implemented as extensions of templates. I will check it with author and let you know If I was right about it tomorrow morning. Vlado. On 04/23/2012 07:14 PM, Mickael Istria wrote: > Hello, > > Working on the 2 following bugs: > * https://issues.jboss.org/browse/JBIDE-11370 : Get all components to > have tests, and get rid of the "in case there is not test" build steps > * https://issues.jboss.org/browse/JBIDE-11600 : > org.jboss.tools.tests.tests.UtilsTest - java.lang.AssertionError: Not > yet implemented > We are trying to set up the necessary stuff to ensure all modules can > easily write tests and get them executed in their builds without effort. > > The issue is that we had to create a dummy test for the tests/ modules > since it did not had test before. The tests modules provides an API to > write tests for JBT/JBDS, so it makes a lot of sense to set up some > tests for this test API, which is used all over the product. But this > dummy test is too dummy. Looking deeper in the content of the tests > module, it looks like there are some automated tests in the plugins/ > folder, those tests are not automatically executed at build time. This > is not a clean layout and behavior. > So I am wondering: *what is the purpose of > org.jboss.tools.ui.bot.ext.test.config.Suite and Annotated* class*? > Can/Should it be used for CI testing? I tried it with surefire and got > 7 of 9 tests successful. > If this can be automated, please find attached a patch containing the > necessary change to follow the "normal" layout and enable those tests. > If this is not meant to be automated, then what is this? > -- > Mickael Istria > Eclipse developer at JBoss, by Red Hat<http://www.jboss.org/tools> > My blog<http://mickaelistria.wordpress.com> - My Tweets > <http://twitter.com/mickaelistria> > > > _______________________________________________ > jbosstools-dev mailing list > jbosstools-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jbosstools-dev _______________________________________________ jbosstools-dev mailing list jbosstools-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jbosstools-dev

` > Tests in org/jboss/tools/ui/bot/ext/test were added only for testing > during development of this package and there is no reason to run these > tests. It's confirmed by author. > > I'm gonna comment out test classes in test suite definition to have > ready this test suite for development of this package in future but not > run any test when package is built. okey - and it does not make sense to move these tests to the right test module instead of within the non-testy parts ? > I will also add some javadoc to have some description of this package > content. yes, please :) /max

guys - please don't put tests inside api/app source code. makes zero sense. don't understand the reason for not having the tests properly setup as everywhere else ? /max On Apr 24, 2012, at 15:46 , Vlado Pakan wrote: > Hi, > > org.jboss.tools.ui.bot.ext.test is moved to tests module. I have updated > related pom files and set skipTests property to true for this plugin > because we do not want to run this tests automatically. There is only > one test left defined within test suite and this one should not create > any problem when run within build in case somebody will run these test > via maven and force them to be executed. All the tests contained in this > plugin are really just for test developers and they will run them > manually if they will want. > > Javadoc added. > > Vlado. > > On 04/24/2012 01:55 PM, Max Rydahl Andersen wrote: >> ` >>> Tests in org/jboss/tools/ui/bot/ext/test were added only for testing >>> during development of this package and there is no reason to run these >>> tests. It's confirmed by author. >>> >>> I'm gonna comment out test classes in test suite definition to have >>> ready this test suite for development of this package in future but not >>> run any test when package is built. >> okey - and it does not make sense to move these tests to the right test module instead of within the non-testy parts ? >> >>> I will also add some javadoc to have some description of this package >>> content. >> yes, please :) >> >> /max >> >> > _______________________________________________ > jbosstools-dev mailing list > jbosstools-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jbosstools-dev