IMHO, icons for JBDS ought to live in a JBDS branding/product plugin, such as com.jboss.jbds.product[1].

> > >> IMHO, icons for JBDS ought to live in a JBDS branding/product plugin, >> such as com.jboss.jbds.product[1]. >> >> > Well then that raises the question as to why the ESB Project is using a > JBDS icon and whether it should use it at all. > > I used the icon just tried to be consistent with the icons used in the ESB editor, and currently, many jboss tools project wizard use the JBDS global icon. for ESB project, maybe we can choose one of the esb project icons to replace them.

Denny > _______________________________________________ > jbosstools-dev mailing list > jbosstools-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jbosstools-dev > > _______________________________________________ jbosstools-dev mailing list jbosstools-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jbosstools-dev

Max Rydahl Andersen wrote: >>> >>> >>> >>>> IMHO, icons for JBDS ought to live in a JBDS branding/product plugin, >>>> such as com.jboss.jbds.product[1]. >>>> >>>> >>>> >>> Well then that raises the question as to why the ESB Project is using a >>> JBDS icon and whether it should use it at all. >>> >>> >>> >> I used the icon just tried to be consistent with the icons used in the >> ESB editor, >> and currently, many jboss tools project wizard use the JBDS global icon. >> for ESB project, maybe we can choose one of the esb project icons to >> replace them. >> >> > The JBDS global icon is just when we don't have any other options - > and using that should be limited > and it should not be done in a way so we create large dependencies. > Copy it over is ok for this. > > Afaik, we did get an icon created specifically for ESB > (https://jira.jboss.org/jira/browse/JBIDE-3040 ?) - we should use that > and if that isn't big enough get one done that are. > yeah, the size of the wizard icon usually is 75 x 66, do you know who can help us to do it, lex Dmitriev? > btw. the big problem here is that common/xmodel drags a *massive* set > of dependencies in...we > really need to fix that since if we had that under control we could > actually have proper shared resources > it seems many projects have dependencies on the common, such as jst.web.ui, isn't the **common* *component *common* for all other jboss tools project? ;-) Denny > -max > > > >> Denny >> >> >> >>> _______________________________________________ >>> jbosstools-dev mailing list >>> jbosstools-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev >>> >>> >>> >> _______________________________________________ >> jbosstools-dev mailing list >> jbosstools-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/jbosstools-dev >> >>

I don't think we should remove the dependency from ESB component, it's very important for ESB editor, the ESB editor and its model are based on common and xmodel, you can see it in the plugin org.jboss.tools.esb.ui,

Denny Rob Stryker wrote: > Currently the ESB project ui plugin contains a dependency on common, > which as we all know is where xmodel and many other things are mashed > together. This dependency is due only to the need for the JBDS icon in > the new ESB wizard. > > Questions: > 1) Is the requirement of using an icon reason enough to have a dependency? > 2) OR should the ESB project just copy this single icon into their own > plugins? > 3) OR should the ESB project have its own icon for the wizards rather > than using the JBDS red globe icon? > 4) Should the JBDS red globe icon belong in a more light-weight "core" > ui plugin which has no dependency on xmodel and all sorts of other large > pieces of our infrastructure? > _______________________________________________ > jbosstools-dev mailing list > jbosstools-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jbosstools-dev > > _______________________________________________ jbosstools-dev mailing list jbosstools-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jbosstools-dev

Max Rydahl Andersen wrote: >> I don't think we should remove the dependency from ESB component, it's >> very important for ESB editor, >> the ESB editor and its model are based on common and xmodel, you can see >> it in the plugin org.jboss.tools.esb.ui, >> >> > I don't understand why you want to keep technical dependency because > of an icon ? > No, I add the dependency not because of the icon, the esb editor is based on the xmodel.