[ https://jira.jboss.org/jira/browse/JBIDE-3211?page=com.atlassian.jira.plu... ] Maxim Areshkau updated JBIDE-3211: ---------------------------------- Fix Version/s: 3.1.0 To next release. We should remake most of dialogs in vpe, remove from this model and add import settings and export possibilities. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3211?page=com.atlassian.jira.plu... ] Maxim Areshkau commented on JBIDE-3211: --------------------------------------- Also when remake dialogs we should take into account JBIDE-3081 and make refactoring of registration actions in jsp and html editor (org.jboss.tool.jst.jsp plugin.xml) to make it's more like to registration events for wtp editors(HTML wtp editor and others). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3211?page=com.atlassian.jira.plu... ] Denis Maliarevich commented on JBIDE-3211: ------------------------------------------ We need to create a mechanism to save VPE settings for a project and for each file to be able to restore it from external not just in current workspace. The solution is: 1) to create runtime and project-scoped preferences to keep VPE setting for a project and for each file in the project. By doing so we will store required information in project metadata. There is a org.eclipse.core.runtime.preferences package that provides infrastructure for storing a plug-in's preferences. 2) to create some import/export wizards to store VPE project information somewhere outside the workspace. For example, we can make somethong familar to Run/Debug Configurations' import/export. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3211?page=com.atlassian.jira.plu... ] Denis Maliarevich commented on JBIDE-3211: ------------------------------------------ Max, what do you mean under "Preference export"? Could you please explain? Now vpe specific preferencies (such as CSS, Taglib, EL variables and its values) for a file, folder or project are stored by IResource.setPersistentProperty(QualifiedName, String) mechanism, so it's stored to internal eclipse representation of the projects and files. After creating new workspace and importing the projects from the hard disc IResources for these projects and files are being created by eclipse from scratch, as a result these brand new resources don't have any persistent properties on them. To solve it we can save settings to eclipse project metadata (that will be obtained on project import) or to some external file that can be exported/imported into the project separately. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3211?page=com.atlassian.jira.plu... ] Denis Golovin commented on JBIDE-3211: -------------------------------------- WDYT about saving resource preferences not in plugin preferences but in local hidded folder, like .settings? That would even not need to export preferences. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3211?page=com.atlassian.jira.plu... ] Denis Golovin commented on JBIDE-3211: -------------------------------------- It is 'default mechanism'. I would try define FolderScope using org.eclipse.core.resources.ProjectScope as example. That would use hidden .settings folder as sore for preferences. Which means: 1. It could be shared between developers 2. There is no needs to export/import that preferences -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3211?page=com.atlassian.jira.plu... ] Max Rydahl Andersen reopened JBIDE-3211: ---------------------------------------- Just opening to get some clarification: How about old preferences ? Are they migrated ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3211?page=com.atlassian.jira.plu... ] Denis Maliarevich commented on JBIDE-3211: ------------------------------------------ Old mechanism of storing (to IResource.setPersistentProperty()) was completele replaced with the new one (storing to project's .setting folder). Old preferences was not migratable from the beginning. They canntot be transfered between workspaces. In the situation when user opens old workspace with the new version of JBDS old preferences won't be picked up. So I can revert old mechanism of restoring, add it to the new one, old prefs will be restored from workspace and then converted and stored to a new location. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3211?page=com.atlassian.jira.plu... ] Denis Maliarevich commented on JBIDE-3211: ------------------------------------------ It affects all preferences from Page Design Options and Global EL variables. It is easy to do. I've done right now, and need to test it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3211?page=com.atlassian.jira.plu... ] Denis Maliarevich commented on JBIDE-3211: ------------------------------------------ Max, I think now this feature is completed and the issue can be closed. True? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3211?page=com.atlassian.jira.plu... ] Denis Maliarevich commented on JBIDE-3211: ------------------------------------------ Yeah, the logic is just like this. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3211?page=com.atlassian.jira.plu... ] Denis Maliarevich resolved JBIDE-3211. -------------------------------------- Resolution: Done Assignee: Yura Zhishko (was: Denis Maliarevich) Resolved. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira