Author: nbelaevski Date: 2007-12-30 15:09:15 -0500 (Sun, 30 Dec 2007) New Revision: 5116 Modified: trunk/sandbox/ui/combobox/src/main/java/org/richfaces/component/UIComboBox.java trunk/sandbox/ui/combobox/src/main/java/org/richfaces/renderkit/ComboBoxBaseRenderer.java trunk/sandbox/ui/progressBAR/src/main/java/org/richfaces/component/UIProgressBar.java trunk/sandbox/ui/progressBAR/src/main/java/org/richfaces/renderkit/AbstractProgressBarRenderer.java Log: code review results committed Modified: trunk/sandbox/ui/combobox/src/main/java/org/richfaces/component/UIComboBox.java =================================================================== --- trunk/sandbox/ui/combobox/src/main/java/org/richfaces/component/UIComboBox.java 2007-12-29 18:51:42 UTC (rev 5115) +++ trunk/sandbox/ui/combobox/src/main/java/org/richfaces/component/UIComboBox.java 2007-12-30 20:09:15 UTC (rev 5116) @@ -12,8 +12,10 @@ * @author Anton Belevich * */ + +//TODO add @since declaration to newly-created classes public abstract class UIComboBox extends UIInput { - + //TODO should be Object, can be Collection of objects or array public abstract List <String> getSuggestionValues(); public abstract void setSuggestionValues( List value); Modified: trunk/sandbox/ui/combobox/src/main/java/org/richfaces/renderkit/ComboBoxBaseRenderer.java =================================================================== --- trunk/sandbox/ui/combobox/src/main/java/org/richfaces/renderkit/ComboBoxBaseRenderer.java 2007-12-29 18:51:42 UTC (rev 5115) +++ trunk/sandbox/ui/combobox/src/main/java/org/richfaces/renderkit/ComboBoxBaseRenderer.java 2007-12-30 20:09:15 UTC (rev 5116) @@ -2,16 +2,13 @@ import java.io.IOException; import java.util.Collections; -import java.util.HashMap; import java.util.Iterator; import java.util.List; -import java.util.Map; import javax.faces.component.UIComponent; import javax.faces.context.FacesContext; import javax.faces.context.ResponseWriter; -import org.ajax4jsf.javascript.JSFunction; import org.ajax4jsf.javascript.JSFunctionDefinition; import org.ajax4jsf.javascript.JSReference; import org.ajax4jsf.javascript.ScriptString; @@ -62,6 +59,9 @@ UIComboBox comboBox = (UIComboBox)component; List <String> suggestionValues = comboBox.getSuggestionValues(); ResponseWriter writer = context.getResponseWriter(); + //TODO we do not need to sort that + //TODO changing initial data source is a bad idea + //TODO should go after null check probably Collections.sort(suggestionValues); if (suggestionValues != null) { for (Iterator <String> iterator = suggestionValues.iterator(); iterator.hasNext();) { Modified: trunk/sandbox/ui/progressBAR/src/main/java/org/richfaces/component/UIProgressBar.java =================================================================== --- trunk/sandbox/ui/progressBAR/src/main/java/org/richfaces/component/UIProgressBar.java 2007-12-29 18:51:42 UTC (rev 5115) +++ trunk/sandbox/ui/progressBAR/src/main/java/org/richfaces/component/UIProgressBar.java 2007-12-30 20:09:15 UTC (rev 5116) @@ -6,10 +6,7 @@ package org.richfaces.component; -import javax.faces.context.FacesContext; - import org.ajax4jsf.component.UIPoll; -import org.ajax4jsf.context.AjaxContext; /** * TODO Class description goes here. @@ -17,10 +14,13 @@ * @author "Andrey Markavtsov" * */ + +//TODO add @since declaration public abstract class UIProgressBar extends UIPoll { public static final String COMPONENT_TYPE = "org.richfaces.ProgressBar"; public static final String COMPONENT_FAMILY = "org.richfaces.ProgressBar"; + //TODO value can be any number, e.g. big decimal } Modified: trunk/sandbox/ui/progressBAR/src/main/java/org/richfaces/renderkit/AbstractProgressBarRenderer.java =================================================================== --- trunk/sandbox/ui/progressBAR/src/main/java/org/richfaces/renderkit/AbstractProgressBarRenderer.java 2007-12-29 18:51:42 UTC (rev 5115) +++ trunk/sandbox/ui/progressBAR/src/main/java/org/richfaces/renderkit/AbstractProgressBarRenderer.java 2007-12-30 20:09:15 UTC (rev 5116) @@ -87,6 +87,8 @@ writer.endElement(HTML.SPAN_ELEM); } + //TODO do not encode content twice, use node cloning on client + //TODO provide client script with percent value public void encodePersent(FacesContext context, UIComponent component) throws IOException { ResponseWriter writer = context.getResponseWriter();