[JBoss JIRA] (TEIID-2553) Partial insert statements being submitted with incorrect default values
by Bobby Diaz (JIRA)
Bobby Diaz created TEIID-2553:
---------------------------------
Summary: Partial insert statements being submitted with incorrect default values
Key: TEIID-2553
URL: https://issues.jboss.org/browse/TEIID-2553
Project: Teiid
Issue Type: Bug
Components: Query Engine
Affects Versions: 8.4, 8.3
Reporter: Bobby Diaz
Assignee: Steven Hawkins
InsertResolver is causing incorrect default values to be returned by the ResolverUtil due to the wrong element symbol being sent to the ResolverUtil.getDefault() method. In the code below, taken from InsertResolver.getVariableValues(), I believe the first two rows inside the if statement should be reversed so that next.clone() is used to determine the default value rather than the varSymbol whose type has been changed to BOOLEAN.
Collection<ElementSymbol> insertElmnts = ResolverUtil.resolveElementsInGroup(insert.getGroup(), metadata);
insertElmnts.removeAll(insert.getVariables());
Iterator<ElementSymbol> defaultIter = insertElmnts.iterator();
while(defaultIter.hasNext()) {
ElementSymbol next = defaultIter.next();
ElementSymbol varSymbol = next.clone();
varSymbol.getGroupSymbol().setName(ProcedureReservedWords.CHANGING);
varSymbol.setType(DataTypeManager.DefaultDataClasses.BOOLEAN);
result.put(varSymbol, new Constant(Boolean.FALSE));
if (!changingOnly) {
Expression value = ResolverUtil.getDefault(varSymbol, metadata);
varSymbol = next.clone();
varSymbol.getGroupSymbol().setName(SQLConstants.Reserved.NEW);
result.put(varSymbol, value);
}
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 7 months
[JBoss JIRA] (TEIID-2552) Upgrade javacc-maven-plugin from 2.4.1 to 2.6
by Steven Hawkins (JIRA)
[ https://issues.jboss.org/browse/TEIID-2552?page=com.atlassian.jira.plugin... ]
Steven Hawkins commented on TEIID-2552:
---------------------------------------
Again there is no dependency issue here as there is no runtime artifact that is included. So while I will look into making this change it seems incorrect to categorize it as a blocker.
> Upgrade javacc-maven-plugin from 2.4.1 to 2.6
> ---------------------------------------------
>
> Key: TEIID-2552
> URL: https://issues.jboss.org/browse/TEIID-2552
> Project: Teiid
> Issue Type: Component Upgrade
> Components: Build/Kits
> Affects Versions: 8.4.1
> Reporter: Van Halbert
> Assignee: Steven Hawkins
> Priority: Blocker
>
> javacc-maven-plugin 2.6 is needed due to other components are already using 2.6.
> Also, its already been determined that Teiid fails to compile when 2.6 is used.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 7 months
[JBoss JIRA] (TEIID-2551) Delegating does not work for the createXXXExecution methods
by Steven Hawkins (JIRA)
[ https://issues.jboss.org/browse/TEIID-2551?page=com.atlassian.jira.plugin... ]
Steven Hawkins resolved TEIID-2551.
-----------------------------------
Resolution: Done
Removed the createExecution base delegation override and changed the createXXXExecution methods to instead call delegate.createExecution since that's the real public method
> Delegating does not work for the createXXXExecution methods
> -----------------------------------------------------------
>
> Key: TEIID-2551
> URL: https://issues.jboss.org/browse/TEIID-2551
> Project: Teiid
> Issue Type: Bug
> Components: Connector API
> Affects Versions: 7.7
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Fix For: 8.4.1, 8.5
>
>
> It's not explicit in the docs, but the base delegation logic basically requires you to override createExecution and not the createXXXExecution methods. Otherwise if the BaseDelegatingExecutionFactory.createExecution is called, then the delegate will be called instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 7 months
[JBoss JIRA] (TEIID-2552) Upgrade javacc-maven-plugin from 2.4.1 to 2.6
by Steven Hawkins (JIRA)
[ https://issues.jboss.org/browse/TEIID-2552?page=com.atlassian.jira.plugin... ]
Steven Hawkins commented on TEIID-2552:
---------------------------------------
I don't quite follow why this would be a blocker as there is no runtime dependency on javacc, so it doesn't matter what other components are doing.
With the change to 2.6 apparently javacc modified their exception api, thus a compile issue.
> Upgrade javacc-maven-plugin from 2.4.1 to 2.6
> ---------------------------------------------
>
> Key: TEIID-2552
> URL: https://issues.jboss.org/browse/TEIID-2552
> Project: Teiid
> Issue Type: Component Upgrade
> Components: Build/Kits
> Affects Versions: 8.4.1
> Reporter: Van Halbert
> Assignee: Steven Hawkins
> Priority: Blocker
>
> javacc-maven-plugin 2.6 is needed due to other components are already using 2.6.
> Also, its already been determined that Teiid fails to compile when 2.6 is used.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 7 months
[JBoss JIRA] (TEIID-2552) Upgrade javacc-maven-plugin from 2.4.1 to 2.6
by Van Halbert (JIRA)
Van Halbert created TEIID-2552:
----------------------------------
Summary: Upgrade javacc-maven-plugin from 2.4.1 to 2.6
Key: TEIID-2552
URL: https://issues.jboss.org/browse/TEIID-2552
Project: Teiid
Issue Type: Component Upgrade
Components: Build/Kits
Affects Versions: 8.4.1
Reporter: Van Halbert
Assignee: Steven Hawkins
Priority: Blocker
javacc-maven-plugin 2.6 is needed due to other components are already using 2.6.
Also, its already been determined that Teiid fails to compile when 2.6 is used.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 7 months
[JBoss JIRA] (TEIID-2551) Delegating does not work for the createXXXExecution methods
by Steven Hawkins (JIRA)
Steven Hawkins created TEIID-2551:
-------------------------------------
Summary: Delegating does not work for the createXXXExecution methods
Key: TEIID-2551
URL: https://issues.jboss.org/browse/TEIID-2551
Project: Teiid
Issue Type: Bug
Components: Connector API
Affects Versions: 7.7
Reporter: Steven Hawkins
Assignee: Steven Hawkins
Fix For: 8.4.1, 8.5
It's not explicit in the docs, but the base delegation logic basically requires you to override createExecution and not the createXXXExecution methods. Otherwise if the BaseDelegatingExecutionFactory.createExecution is called, then the delegate will be called instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 7 months
[JBoss JIRA] (TEIID-2549) Join planning produces cross joins with limited costing
by Steven Hawkins (JIRA)
[ https://issues.jboss.org/browse/TEIID-2549?page=com.atlassian.jira.plugin... ]
Steven Hawkins resolved TEIID-2549.
-----------------------------------
Resolution: Done
enhanced join order scoring to further prevent creating cross joins with unknown costing information. also updated dependent planning and costing to allow for ndv based upon table cardinality when no other information is available.
> Join planning produces cross joins with limited costing
> -------------------------------------------------------
>
> Key: TEIID-2549
> URL: https://issues.jboss.org/browse/TEIID-2549
> Project: Teiid
> Issue Type: Bug
> Components: Query Engine
> Affects Versions: 7.7
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Fix For: 8.4.1, 8.5
>
>
> The join planning logic does not gracefully handle a lack of costing information in effective cross joins (where there is still outside criteria). For example with a small table x that only has cardinality set and a large table y with no costing information, the join structure
> from x inner join y as y1 on x.col = y1.col inner join y as y2 on x.col1 = y2.col1
> can result in a cross join plan between y1 and y2 (although the specifics of the plan may verify from version to version - in 7.7 the cross join will likely be pushed down, while in 8.4 a dependent join can be created depending upon the size of x, but can still produce a pushed cross join).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 7 months
[JBoss JIRA] (TEIID-2549) Join planning produces cross joins with limited costing
by Steven Hawkins (JIRA)
Steven Hawkins created TEIID-2549:
-------------------------------------
Summary: Join planning produces cross joins with limited costing
Key: TEIID-2549
URL: https://issues.jboss.org/browse/TEIID-2549
Project: Teiid
Issue Type: Bug
Components: Query Engine
Affects Versions: 7.7
Reporter: Steven Hawkins
Assignee: Steven Hawkins
Fix For: 8.4.1, 8.5
The join planning logic does not gracefully handle a lack of costing information in effective cross joins (where there is still outside criteria). For example with a small table x that only has cardinality set and a large table y with no costing information, the join structure
from x inner join y as y1 on x.col = y1.col inner join y as y2 on x.col1 = y2.col1
can result in a cross join plan between y1 and y2 (although the specifics of the plan may verify from version to version - in 7.7 the cross join will likely be pushed down, while in 8.4 a dependent join can be created depending upon the size of x, but can still produce a pushed cross join).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 7 months