[
https://issues.redhat.com/browse/TEIIDSB-223?page=com.atlassian.jira.plug...
]
Steven Hawkins commented on TEIIDSB-223:
----------------------------------------
Yes, make ci locally is not a problem.
Is there a way you run travis locally to test before any changes
.travis.yaml file?
It's not really a local thing. You need to spin op their image with all of the
associated configuration defaults etc. based upon the .travis.yml file. I've put more
on this in the pr in terms of trying to iron out some of the differences, but there remain
some - I'm locally running go 1.14 (but updating .travis.yml to 1.14 didn't make a
difference) and of course travis is running ubuntu (which at the very least had to be
accounted for in the yamllint utility). To make further progress you'd probably want
to log or error out with more information about the zz generated file differences and go
from there. I got tired of messing with it so I stopped with this :)
Issues with connection_factories.json and operator
--------------------------------------------------
Key: TEIIDSB-223
URL:
https://issues.redhat.com/browse/TEIIDSB-223
Project: Teiid Spring Boot
Issue Type: Quality Risk
Reporter: Steven Hawkins
Assignee: Ramesh Reddy
Priority: Major
Fix For: 1.6.0
Time Spent: 4 hours, 4 minutes
Remaining Estimate: 0 minutes
There are a couple of things that I hit updating the connection_factories.json:
1. The objectmapper is not set to use a predictable order for the json, so it may vary by
vm leading to needless file changes. We can just change the Main to add the sorted
mapping feature.
2. The operator generation logic uses a settings.xml that does not specify snapshot
access - if you do not locally build the teiid-spring-boot snapshot, then it will fail
generation.
3. Even if you update the settings to have snapshot access, the generation logic must
download nearly everything related to teiid-spring-boot. We could consider just running
the generation step as part of the teiid-spring-boot build so that it is available as a
single artifact.
4. The operator readme doesn't mention anything about running make generate (or
related)
--
This message was sent by Atlassian Jira
(v7.13.8#713008)