12:33 p.m.
Van Halbert created TEIID-2246:
----------------------------------
Summary: Incorrect results with TIMESTAMPDIFF
Key: TEIID-2246
URL: https://issues.jboss.org/browse/TEIID-2246
Project: Teiid
Issue Type: Feature Request
Components: Server
Affects Versions: 7.4.4
Reporter: Van Halbert
Assignee: Steven Hawkins
2 issues with TIMESTAMPDIFF:
1.
select TIMESTAMPDIFF(SQL_TSI_DAY,parseDate('2012-01-01',
'yyyy-MM-dd'),parseDate('2304-04-12', 'yyyy-MM-dd'));
result = 106751
If you increase the end date by 1 day:
select TIMESTAMPDIFF(SQL_TSI_DAY,parseDate('2012-01-01',
'yyyy-MM-dd'),parseDate('2304-04-13', 'yyyy-MM-dd'))
result = -106751. I would expected the answer to be 106752
2. Both MS Excel and Oracle give the number of days between 1-Jan-2012 and 12-Apr-2304 as
106752, not the 106751 that EDS is reporting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:35 p.m.
[
https://issues.jboss.org/browse/TEIID-2246?page=com.atlassian.jira.plugin...
]
Van Halbert updated TEIID-2246:
-------------------------------
Issue Type: Bug (was: Feature Request)
Assignee: Van Halbert (was: Steven Hawkins)
After doing some testing on the 7.4.x branch, it appears there's an overflow issue.
I'll attach 2 patches that do:
- use some suggested code that test for overflow
- added unit tests that confirms the above issue
Incorrect results with TIMESTAMPDIFF
------------------------------------
Key: TEIID-2246
URL: https://issues.jboss.org/browse/TEIID-2246
Project: Teiid
Issue Type: Bug
Components: Server
Affects Versions: 7.4.4
Reporter: Van Halbert
Assignee: Van Halbert
2 issues with TIMESTAMPDIFF:
1.
select TIMESTAMPDIFF(SQL_TSI_DAY,parseDate('2012-01-01',
'yyyy-MM-dd'),parseDate('2304-04-12', 'yyyy-MM-dd'));
result = 106751
If you increase the end date by 1 day:
select TIMESTAMPDIFF(SQL_TSI_DAY,parseDate('2012-01-01',
'yyyy-MM-dd'),parseDate('2304-04-13', 'yyyy-MM-dd'))
result = -106751. I would expected the answer to be 106752
2. Both MS Excel and Oracle give the number of days between 1-Jan-2012 and 12-Apr-2304
as 106752, not the 106751 that EDS is reporting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:43 p.m.
[
https://issues.jboss.org/browse/TEIID-2246?page=com.atlassian.jira.plugin...
]
Van Halbert updated TEIID-2246:
-------------------------------
Assignee: Johnathon Lee (was: Van Halbert)
Incorrect results with TIMESTAMPDIFF
------------------------------------
Key: TEIID-2246
URL: https://issues.jboss.org/browse/TEIID-2246
Project: Teiid
Issue Type: Bug
Components: Server
Affects Versions: 7.4.4
Reporter: Van Halbert
Assignee: Johnathon Lee
Attachments: FunctionMethods.java.patch, TestFunction.java.patch
2 issues with TIMESTAMPDIFF:
1.
select TIMESTAMPDIFF(SQL_TSI_DAY,parseDate('2012-01-01',
'yyyy-MM-dd'),parseDate('2304-04-12', 'yyyy-MM-dd'));
result = 106751
If you increase the end date by 1 day:
select TIMESTAMPDIFF(SQL_TSI_DAY,parseDate('2012-01-01',
'yyyy-MM-dd'),parseDate('2304-04-13', 'yyyy-MM-dd'))
result = -106751. I would expected the answer to be 106752
2. Both MS Excel and Oracle give the number of days between 1-Jan-2012 and 12-Apr-2304
as 106752, not the 106751 that EDS is reporting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:43 p.m.
[
https://issues.jboss.org/browse/TEIID-2246?page=com.atlassian.jira.plugin...
]
Van Halbert updated TEIID-2246:
-------------------------------
Attachment: TestFunction.java.patch
Incorrect results with TIMESTAMPDIFF
------------------------------------
Key: TEIID-2246
URL: https://issues.jboss.org/browse/TEIID-2246
Project: Teiid
Issue Type: Bug
Components: Server
Affects Versions: 7.4.4
Reporter: Van Halbert
Assignee: Van Halbert
Attachments: FunctionMethods.java.patch, TestFunction.java.patch
2 issues with TIMESTAMPDIFF:
1.
select TIMESTAMPDIFF(SQL_TSI_DAY,parseDate('2012-01-01',
'yyyy-MM-dd'),parseDate('2304-04-12', 'yyyy-MM-dd'));
result = 106751
If you increase the end date by 1 day:
select TIMESTAMPDIFF(SQL_TSI_DAY,parseDate('2012-01-01',
'yyyy-MM-dd'),parseDate('2304-04-13', 'yyyy-MM-dd'))
result = -106751. I would expected the answer to be 106752
2. Both MS Excel and Oracle give the number of days between 1-Jan-2012 and 12-Apr-2304
as 106752, not the 106751 that EDS is reporting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:43 p.m.
[
https://issues.jboss.org/browse/TEIID-2246?page=com.atlassian.jira.plugin...
]
Van Halbert updated TEIID-2246:
-------------------------------
Attachment: FunctionMethods.java.patch
Incorrect results with TIMESTAMPDIFF
------------------------------------
Key: TEIID-2246
URL: https://issues.jboss.org/browse/TEIID-2246
Project: Teiid
Issue Type: Bug
Components: Server
Affects Versions: 7.4.4
Reporter: Van Halbert
Assignee: Van Halbert
Attachments: FunctionMethods.java.patch, TestFunction.java.patch
2 issues with TIMESTAMPDIFF:
1.
select TIMESTAMPDIFF(SQL_TSI_DAY,parseDate('2012-01-01',
'yyyy-MM-dd'),parseDate('2304-04-12', 'yyyy-MM-dd'));
result = 106751
If you increase the end date by 1 day:
select TIMESTAMPDIFF(SQL_TSI_DAY,parseDate('2012-01-01',
'yyyy-MM-dd'),parseDate('2304-04-13', 'yyyy-MM-dd'))
result = -106751. I would expected the answer to be 106752
2. Both MS Excel and Oracle give the number of days between 1-Jan-2012 and 12-Apr-2304
as 106752, not the 106751 that EDS is reporting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:17 p.m.
[
https://issues.jboss.org/browse/TEIID-2246?page=com.atlassian.jira.plugin...
]
Van Halbert edited comment on TEIID-2246 at 10/5/12 2:16 PM:
-------------------------------------------------------------
After doing some testing on the 7.4.x branch, it appears there's an overflow issue.
I'll attach 2 patches that do:
- use some suggested code that test for overflow
- added unit tests that confirms the above issue
When running the tests, you should see 3 error:
Tests in error:
testTimestampDiffTimeStamp_ErrorUsingEndDate(org.teiid.query.function.TestFunction):
Long overflow
testTimestampDiffTimeStamp_ErrorUsingEndDate2304(org.teiid.query.function.TestFunction):
Long overflow
testTimestampDiffTimeStamp_ErrorUsingEndDate2262(org.teiid.query.function.TestFunction):
Long overflow
The one added test: testTimestampDiffTimeStamp_ErrorUsingEndDate2261 was the determined
boundary before 2262 starts producing the problem
was (Author: van.halbert):
After doing some testing on the 7.4.x branch, it appears there's an overflow
issue. I'll attach 2 patches that do:
- use some suggested code that test for overflow
- added unit tests that confirms the above issue
Incorrect results with TIMESTAMPDIFF
------------------------------------
Key: TEIID-2246
URL: https://issues.jboss.org/browse/TEIID-2246
Project: Teiid
Issue Type: Bug
Components: Server
Affects Versions: 7.4.4
Reporter: Van Halbert
Assignee: Johnathon Lee
Attachments: TestFunction.java.patch
2 issues with TIMESTAMPDIFF:
1.
select TIMESTAMPDIFF(SQL_TSI_DAY,parseDate('2012-01-01',
'yyyy-MM-dd'),parseDate('2304-04-12', 'yyyy-MM-dd'));
result = 106751
If you increase the end date by 1 day:
select TIMESTAMPDIFF(SQL_TSI_DAY,parseDate('2012-01-01',
'yyyy-MM-dd'),parseDate('2304-04-13', 'yyyy-MM-dd'))
result = -106751. I would expected the answer to be 106752
2. Both MS Excel and Oracle give the number of days between 1-Jan-2012 and 12-Apr-2304
as 106752, not the 106751 that EDS is reporting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:17 p.m.
[
https://issues.jboss.org/browse/TEIID-2246?page=com.atlassian.jira.plugin...
]
Steven Hawkins updated TEIID-2246:
----------------------------------
Attachment: (was: FunctionMethods.java.patch)
Incorrect results with TIMESTAMPDIFF
------------------------------------
Key: TEIID-2246
URL: https://issues.jboss.org/browse/TEIID-2246
Project: Teiid
Issue Type: Bug
Components: Server
Affects Versions: 7.4.4
Reporter: Van Halbert
Assignee: Johnathon Lee
Attachments: TestFunction.java.patch
2 issues with TIMESTAMPDIFF:
1.
select TIMESTAMPDIFF(SQL_TSI_DAY,parseDate('2012-01-01',
'yyyy-MM-dd'),parseDate('2304-04-12', 'yyyy-MM-dd'));
result = 106751
If you increase the end date by 1 day:
select TIMESTAMPDIFF(SQL_TSI_DAY,parseDate('2012-01-01',
'yyyy-MM-dd'),parseDate('2304-04-13', 'yyyy-MM-dd'))
result = -106751. I would expected the answer to be 106752
2. Both MS Excel and Oracle give the number of days between 1-Jan-2012 and 12-Apr-2304
as 106752, not the 106751 that EDS is reporting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:22 p.m.
[
https://issues.jboss.org/browse/TEIID-2246?page=com.atlassian.jira.plugin...
]
Steven Hawkins updated TEIID-2246:
----------------------------------
Attachment: FunctionMethods.java.patch
Incorrect results with TIMESTAMPDIFF
------------------------------------
Key: TEIID-2246
URL: https://issues.jboss.org/browse/TEIID-2246
Project: Teiid
Issue Type: Bug
Components: Server
Affects Versions: 7.4.4
Reporter: Van Halbert
Assignee: Johnathon Lee
Attachments: FunctionMethods.java.patch, TestFunction.java.patch
2 issues with TIMESTAMPDIFF:
1.
select TIMESTAMPDIFF(SQL_TSI_DAY,parseDate('2012-01-01',
'yyyy-MM-dd'),parseDate('2304-04-12', 'yyyy-MM-dd'));
result = 106751
If you increase the end date by 1 day:
select TIMESTAMPDIFF(SQL_TSI_DAY,parseDate('2012-01-01',
'yyyy-MM-dd'),parseDate('2304-04-13', 'yyyy-MM-dd'))
result = -106751. I would expected the answer to be 106752
2. Both MS Excel and Oracle give the number of days between 1-Jan-2012 and 12-Apr-2304
as 106752, not the 106751 that EDS is reporting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:06 a.m.
[
https://issues.jboss.org/browse/TEIID-2246?page=com.atlassian.jira.plugin...
]
Steven Hawkins resolved TEIID-2246.
-----------------------------------
Fix Version/s: 8.2
Resolution: Done
Resolved by removing the unnecessary normalization to nanoseconds. See
https://github.com/teiid/teiid/commit/49e83c14d48d549ca79276017eda0a9b750...
Incorrect results with TIMESTAMPDIFF
------------------------------------
Key: TEIID-2246
URL: https://issues.jboss.org/browse/TEIID-2246
Project: Teiid
Issue Type: Bug
Components: Server
Affects Versions: 7.4.4
Reporter: Van Halbert
Assignee: Johnathon Lee
Fix For: 8.2
Attachments: FunctionMethods.java.patch, TestFunction.java.patch
2 issues with TIMESTAMPDIFF:
1.
select TIMESTAMPDIFF(SQL_TSI_DAY,parseDate('2012-01-01',
'yyyy-MM-dd'),parseDate('2304-04-12', 'yyyy-MM-dd'));
result = 106751
If you increase the end date by 1 day:
select TIMESTAMPDIFF(SQL_TSI_DAY,parseDate('2012-01-01',
'yyyy-MM-dd'),parseDate('2304-04-13', 'yyyy-MM-dd'))
result = -106751. I would expected the answer to be 106752
2. Both MS Excel and Oracle give the number of days between 1-Jan-2012 and 12-Apr-2304
as 106752, not the 106751 that EDS is reporting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:17 a.m.
[
https://issues.jboss.org/browse/TEIID-2246?page=com.atlassian.jira.plugin...
]
RH Bugzilla Integration updated TEIID-2246:
-------------------------------------------
Bugzilla Update: Perform
Incorrect results with TIMESTAMPDIFF
------------------------------------
Key: TEIID-2246
URL: https://issues.jboss.org/browse/TEIID-2246
Project: Teiid
Issue Type: Bug
Components: Server
Affects Versions: 7.4.4
Reporter: Van Halbert
Assignee: Johnathon Lee
Fix For: 8.2
Attachments: FunctionMethods.java.patch, TestFunction.java.patch
2 issues with TIMESTAMPDIFF:
1.
select TIMESTAMPDIFF(SQL_TSI_DAY,parseDate('2012-01-01',
'yyyy-MM-dd'),parseDate('2304-04-12', 'yyyy-MM-dd'));
result = 106751
If you increase the end date by 1 day:
select TIMESTAMPDIFF(SQL_TSI_DAY,parseDate('2012-01-01',
'yyyy-MM-dd'),parseDate('2304-04-13', 'yyyy-MM-dd'))
result = -106751. I would expected the answer to be 106752
2. Both MS Excel and Oracle give the number of days between 1-Jan-2012 and 12-Apr-2304
as 106752, not the 106751 that EDS is reporting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:17 a.m.
[
https://issues.jboss.org/browse/TEIID-2246?page=com.atlassian.jira.plugin...
]
RH Bugzilla Integration updated TEIID-2246:
-------------------------------------------
Bugzilla References: https://bugzilla.redhat.com/show_bug.cgi?id=864949
Incorrect results with TIMESTAMPDIFF
------------------------------------
Key: TEIID-2246
URL: https://issues.jboss.org/browse/TEIID-2246
Project: Teiid
Issue Type: Bug
Components: Server
Affects Versions: 7.4.4
Reporter: Van Halbert
Assignee: Johnathon Lee
Fix For: 8.2
Attachments: FunctionMethods.java.patch, TestFunction.java.patch
2 issues with TIMESTAMPDIFF:
1.
select TIMESTAMPDIFF(SQL_TSI_DAY,parseDate('2012-01-01',
'yyyy-MM-dd'),parseDate('2304-04-12', 'yyyy-MM-dd'));
result = 106751
If you increase the end date by 1 day:
select TIMESTAMPDIFF(SQL_TSI_DAY,parseDate('2012-01-01',
'yyyy-MM-dd'),parseDate('2304-04-13', 'yyyy-MM-dd'))
result = -106751. I would expected the answer to be 106752
2. Both MS Excel and Oracle give the number of days between 1-Jan-2012 and 12-Apr-2304
as 106752, not the 106751 that EDS is reporting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:58 a.m.
[
https://issues.jboss.org/browse/TEIID-2246?page=com.atlassian.jira.plugin...
]
Johnathon Lee updated TEIID-2246:
---------------------------------
Fix Version/s: 7.7.3
Incorrect results with TIMESTAMPDIFF
------------------------------------
Key: TEIID-2246
URL: https://issues.jboss.org/browse/TEIID-2246
Project: Teiid
Issue Type: Bug
Components: Server
Affects Versions: 7.4.4
Reporter: Van Halbert
Assignee: Johnathon Lee
Fix For: 7.7.3, 8.2
Attachments: FunctionMethods.java.patch, TestFunction.java.patch
2 issues with TIMESTAMPDIFF:
1.
select TIMESTAMPDIFF(SQL_TSI_DAY,parseDate('2012-01-01',
'yyyy-MM-dd'),parseDate('2304-04-12', 'yyyy-MM-dd'));
result = 106751
If you increase the end date by 1 day:
select TIMESTAMPDIFF(SQL_TSI_DAY,parseDate('2012-01-01',
'yyyy-MM-dd'),parseDate('2304-04-13', 'yyyy-MM-dd'))
result = -106751. I would expected the answer to be 106752
2. Both MS Excel and Oracle give the number of days between 1-Jan-2012 and 12-Apr-2304
as 106752, not the 106751 that EDS is reporting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:23 a.m.
[
https://issues.jboss.org/browse/TEIID-2246?page=com.atlassian.jira.plugin...
]
Steven Hawkins closed TEIID-2246.
---------------------------------
Incorrect results with TIMESTAMPDIFF
------------------------------------
Key: TEIID-2246
URL: https://issues.jboss.org/browse/TEIID-2246
Project: Teiid
Issue Type: Bug
Components: Server
Affects Versions: 7.4.4
Reporter: Van Halbert
Assignee: Johnathon Lee
Fix For: 7.7.3, 8.2
Attachments: FunctionMethods.java.patch, TestFunction.java.patch
2 issues with TIMESTAMPDIFF:
1.
select TIMESTAMPDIFF(SQL_TSI_DAY,parseDate('2012-01-01',
'yyyy-MM-dd'),parseDate('2304-04-12', 'yyyy-MM-dd'));
result = 106751
If you increase the end date by 1 day:
select TIMESTAMPDIFF(SQL_TSI_DAY,parseDate('2012-01-01',
'yyyy-MM-dd'),parseDate('2304-04-13', 'yyyy-MM-dd'))
result = -106751. I would expected the answer to be 106752
2. Both MS Excel and Oracle give the number of days between 1-Jan-2012 and 12-Apr-2304
as 106752, not the 106751 that EDS is reporting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4415
days inactive
4461
days old
12 comments
4 participants
participants (4)
-
Johnathon Lee (JIRA) -
RH Bugzilla Integration (JIRA)
-
Steven Hawkins (JIRA)
-
Van Halbert (JIRA)