[ https://issues.jboss.org/browse/TEIID-2815?page=com.atlassian.jira.plugin... ] Steven Hawkins commented on TEIID-2815: --------------------------------------- After looking at it more, we'll have you guys take ownership of FunctionForm as it's just an adapter for FunctionMethod (the metadata api representation) and is not useful to Teiid. The change for this: - removes FunctionForm - add FunctionLibrary.getBuiltInAggregateFunctions(boolean includeAnaylitic) this will return a list of FunctionMethods representing the aggregate metadata. count\(*) and textagg are not in the list since their syntax is not well represented in our metadata. If it's ok, this will just return the most general form of some of the aggregates, for example object max(object) rather than an entry for each type. - changed the findFunctionForm method to hasFunctionMethod - changed the category method to getFunctionsInCategory which returns a list of FunctionMethods User defined aggregates are just exposed through the normal function logic on FunctionLibrary. The TODOs then are to create further adapt the logic in Teiid to use the FunctionMethod representation internally for all aggregates and not just user defined aggregates. We also need to a way to express count\(*) and at least internally standardize the syntax for textagg - which effectively relies upon a hidden function called textline that builds each line of the result. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira