[JBoss JIRA] Created: (TEIID-1705) Encountered NPE in SQLStringVisitor for TIMESTAMPADD and TIMESTAMPDIFF
4:37 p.m.
Encountered NPE in SQLStringVisitor for TIMESTAMPADD and TIMESTAMPDIFF
----------------------------------------------------------------------
Key: TEIID-1705
URL: https://issues.jboss.org/browse/TEIID-1705
Project: Teiid
Issue Type: Bug
Components: Query Engine
Affects Versions: 7.4
Reporter: Mark Drilling
Assignee: Steven Hawkins
I was using expression builder in Designer when I encountered this NPE.
java.lang.NullPointerException
at org.teiid.query.sql.visitor.SQLStringVisitor.visit(SQLStringVisitor.java:1280)
at org.teiid.query.sql.symbol.Function.acceptVisitor(Function.java:182)
at org.teiid.query.sql.visitor.SQLStringVisitor.getSQLString(SQLStringVisitor.java:164)
at
com.metamatrix.query.internal.ui.builder.util.LanguageObjectLabelProvider.getText(LanguageObjectLabelProvider.java:129)
I think the visit method for FUNCTION in SQLStringVisitor just needs to do a null check on
the first arg. I'm attaching a code patch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:41 p.m.
New subject: [JBoss JIRA] Updated: (TEIID-1705) Encountered NPE in SQLStringVisitor for TIMESTAMPADD and TIMESTAMPDIFF
[
https://issues.jboss.org/browse/TEIID-1705?page=com.atlassian.jira.plugin...
]
Mark Drilling updated TEIID-1705:
---------------------------------
Attachment: SQLStringVisitor-Patch.txt
Encountered NPE in SQLStringVisitor for TIMESTAMPADD and
TIMESTAMPDIFF
----------------------------------------------------------------------
Key: TEIID-1705
URL: https://issues.jboss.org/browse/TEIID-1705
Project: Teiid
Issue Type: Bug
Components: Query Engine
Affects Versions: 7.4
Reporter: Mark Drilling
Assignee: Steven Hawkins
Attachments: SQLStringVisitor-Patch.txt
I was using expression builder in Designer when I encountered this NPE.
java.lang.NullPointerException
at org.teiid.query.sql.visitor.SQLStringVisitor.visit(SQLStringVisitor.java:1280)
at org.teiid.query.sql.symbol.Function.acceptVisitor(Function.java:182)
at org.teiid.query.sql.visitor.SQLStringVisitor.getSQLString(SQLStringVisitor.java:164)
at
com.metamatrix.query.internal.ui.builder.util.LanguageObjectLabelProvider.getText(LanguageObjectLabelProvider.java:129)
I think the visit method for FUNCTION in SQLStringVisitor just needs to do a null check
on the first arg. I'm attaching a code patch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:52 p.m.
New subject: [JBoss JIRA] Commented: (TEIID-1705) Encountered NPE in SQLStringVisitor for TIMESTAMPADD and TIMESTAMPDIFF
[
https://issues.jboss.org/browse/TEIID-1705?page=com.atlassian.jira.plugin...
]
Steven Hawkins commented on TEIID-1705:
---------------------------------------
If the expression builder will ask for the string form of invalid expressions, there are
probably several other places that would need changed as well.
Perhaps the fix should be to the expression builder so that it knows what the valid
keywords (SQL_TSI_FRAC_SECOND, etc.) are for the first argument. If that argument is
missing/incorrect the function will fail to parse anyway.
Encountered NPE in SQLStringVisitor for TIMESTAMPADD and
TIMESTAMPDIFF
----------------------------------------------------------------------
Key: TEIID-1705
URL: https://issues.jboss.org/browse/TEIID-1705
Project: Teiid
Issue Type: Bug
Components: Query Engine
Affects Versions: 7.4
Reporter: Mark Drilling
Assignee: Steven Hawkins
Attachments: SQLStringVisitor-Patch.txt
I was using expression builder in Designer when I encountered this NPE.
java.lang.NullPointerException
at org.teiid.query.sql.visitor.SQLStringVisitor.visit(SQLStringVisitor.java:1280)
at org.teiid.query.sql.symbol.Function.acceptVisitor(Function.java:182)
at org.teiid.query.sql.visitor.SQLStringVisitor.getSQLString(SQLStringVisitor.java:164)
at
com.metamatrix.query.internal.ui.builder.util.LanguageObjectLabelProvider.getText(LanguageObjectLabelProvider.java:129)
I think the visit method for FUNCTION in SQLStringVisitor just needs to do a null check
on the first arg. I'm attaching a code patch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:07 p.m.
New subject: [JBoss JIRA] Commented: (TEIID-1705) Encountered NPE in SQLStringVisitor for TIMESTAMPADD and TIMESTAMPDIFF
[
https://issues.jboss.org/browse/TEIID-1705?page=com.atlassian.jira.plugin...
]
Mark Drilling commented on TEIID-1705:
--------------------------------------
I was looking at the cast and convert handling in the sqlStringVisitor which does similar
handling for null constant. We can look into changing expression builder as well to
create valid args - but currently it creates the function first with null args, then the
user defines the args.
Encountered NPE in SQLStringVisitor for TIMESTAMPADD and
TIMESTAMPDIFF
----------------------------------------------------------------------
Key: TEIID-1705
URL: https://issues.jboss.org/browse/TEIID-1705
Project: Teiid
Issue Type: Bug
Components: Query Engine
Affects Versions: 7.4
Reporter: Mark Drilling
Assignee: Steven Hawkins
Attachments: SQLStringVisitor-Patch.txt
I was using expression builder in Designer when I encountered this NPE.
java.lang.NullPointerException
at org.teiid.query.sql.visitor.SQLStringVisitor.visit(SQLStringVisitor.java:1280)
at org.teiid.query.sql.symbol.Function.acceptVisitor(Function.java:182)
at org.teiid.query.sql.visitor.SQLStringVisitor.getSQLString(SQLStringVisitor.java:164)
at
com.metamatrix.query.internal.ui.builder.util.LanguageObjectLabelProvider.getText(LanguageObjectLabelProvider.java:129)
I think the visit method for FUNCTION in SQLStringVisitor just needs to do a null check
on the first arg. I'm attaching a code patch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:20 p.m.
New subject: [JBoss JIRA] Commented: (TEIID-1705) Encountered NPE in SQLStringVisitor for TIMESTAMPADD and TIMESTAMPDIFF
[
https://issues.jboss.org/browse/TEIID-1705?page=com.atlassian.jira.plugin...
]
Steven Hawkins commented on TEIID-1705:
---------------------------------------
Ideally I would rather that none of the code has to consider invalid cases. It makes
sense now that this was added quite a while ago for the expression builder, but I think it
would make more sense to just use a null constant rather than passing a null value.
Encountered NPE in SQLStringVisitor for TIMESTAMPADD and
TIMESTAMPDIFF
----------------------------------------------------------------------
Key: TEIID-1705
URL: https://issues.jboss.org/browse/TEIID-1705
Project: Teiid
Issue Type: Bug
Components: Query Engine
Affects Versions: 7.4
Reporter: Mark Drilling
Assignee: Steven Hawkins
Attachments: SQLStringVisitor-Patch.txt
I was using expression builder in Designer when I encountered this NPE.
java.lang.NullPointerException
at org.teiid.query.sql.visitor.SQLStringVisitor.visit(SQLStringVisitor.java:1280)
at org.teiid.query.sql.symbol.Function.acceptVisitor(Function.java:182)
at org.teiid.query.sql.visitor.SQLStringVisitor.getSQLString(SQLStringVisitor.java:164)
at
com.metamatrix.query.internal.ui.builder.util.LanguageObjectLabelProvider.getText(LanguageObjectLabelProvider.java:129)
I think the visit method for FUNCTION in SQLStringVisitor just needs to do a null check
on the first arg. I'm attaching a code patch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:17 p.m.
New subject: [JBoss JIRA] Commented: (TEIID-1705) Encountered NPE in SQLStringVisitor for TIMESTAMPADD and TIMESTAMPDIFF
[
https://issues.jboss.org/browse/TEIID-1705?page=com.atlassian.jira.plugin...
]
Steven Hawkins commented on TEIID-1705:
---------------------------------------
Are you good with just passing null Constant values as the resolution?
Encountered NPE in SQLStringVisitor for TIMESTAMPADD and
TIMESTAMPDIFF
----------------------------------------------------------------------
Key: TEIID-1705
URL: https://issues.jboss.org/browse/TEIID-1705
Project: Teiid
Issue Type: Bug
Components: Query Engine
Affects Versions: 7.4
Reporter: Mark Drilling
Assignee: Steven Hawkins
Attachments: SQLStringVisitor-Patch.txt
I was using expression builder in Designer when I encountered this NPE.
java.lang.NullPointerException
at org.teiid.query.sql.visitor.SQLStringVisitor.visit(SQLStringVisitor.java:1280)
at org.teiid.query.sql.symbol.Function.acceptVisitor(Function.java:182)
at org.teiid.query.sql.visitor.SQLStringVisitor.getSQLString(SQLStringVisitor.java:164)
at
com.metamatrix.query.internal.ui.builder.util.LanguageObjectLabelProvider.getText(LanguageObjectLabelProvider.java:129)
I think the visit method for FUNCTION in SQLStringVisitor just needs to do a null check
on the first arg. I'm attaching a code patch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:10 p.m.
New subject: [JBoss JIRA] Resolved: (TEIID-1705) Encountered NPE in SQLStringVisitor for TIMESTAMPADD and TIMESTAMPDIFF
[
https://issues.jboss.org/browse/TEIID-1705?page=com.atlassian.jira.plugin...
]
Steven Hawkins resolved TEIID-1705.
-----------------------------------
Resolution: Rejected
We'll expect that the expression builder / criteria builder create basically valid
object representations.
Encountered NPE in SQLStringVisitor for TIMESTAMPADD and
TIMESTAMPDIFF
----------------------------------------------------------------------
Key: TEIID-1705
URL: https://issues.jboss.org/browse/TEIID-1705
Project: Teiid
Issue Type: Bug
Components: Query Engine
Affects Versions: 7.4
Reporter: Mark Drilling
Assignee: Steven Hawkins
Attachments: SQLStringVisitor-Patch.txt
I was using expression builder in Designer when I encountered this NPE.
java.lang.NullPointerException
at org.teiid.query.sql.visitor.SQLStringVisitor.visit(SQLStringVisitor.java:1280)
at org.teiid.query.sql.symbol.Function.acceptVisitor(Function.java:182)
at org.teiid.query.sql.visitor.SQLStringVisitor.getSQLString(SQLStringVisitor.java:164)
at
com.metamatrix.query.internal.ui.builder.util.LanguageObjectLabelProvider.getText(LanguageObjectLabelProvider.java:129)
I think the visit method for FUNCTION in SQLStringVisitor just needs to do a null check
on the first arg. I'm attaching a code patch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:24 p.m.
New subject: [JBoss JIRA] (TEIID-1705) Encountered NPE in SQLStringVisitor for TIMESTAMPADD and TIMESTAMPDIFF
[
https://issues.jboss.org/browse/TEIID-1705?page=com.atlassian.jira.plugin...
]
Steven Hawkins closed TEIID-1705.
---------------------------------
Encountered NPE in SQLStringVisitor for TIMESTAMPADD and
TIMESTAMPDIFF
----------------------------------------------------------------------
Key: TEIID-1705
URL: https://issues.jboss.org/browse/TEIID-1705
Project: Teiid
Issue Type: Bug
Components: Query Engine
Affects Versions: 7.4
Reporter: Mark Drilling
Assignee: Steven Hawkins
Attachments: SQLStringVisitor-Patch.txt
I was using expression builder in Designer when I encountered this NPE.
java.lang.NullPointerException
at org.teiid.query.sql.visitor.SQLStringVisitor.visit(SQLStringVisitor.java:1280)
at org.teiid.query.sql.symbol.Function.acceptVisitor(Function.java:182)
at org.teiid.query.sql.visitor.SQLStringVisitor.getSQLString(SQLStringVisitor.java:164)
at
com.metamatrix.query.internal.ui.builder.util.LanguageObjectLabelProvider.getText(LanguageObjectLabelProvider.java:129)
I think the visit method for FUNCTION in SQLStringVisitor just needs to do a null check
on the first arg. I'm attaching a code patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4595
days inactive
4706
days old
7 comments
3 participants
participants (3)
-
Mark Drilling (JIRA) -
Steven Hawkins (Closed) (JIRA)
-
Steven Hawkins (JIRA)