Re: [weld-dev] Weld Performance improvement

Thank you Jozef and Martin! I am looking forward to consume 2.2.15.Final. On Mon, Jul 20, 2015 at 2:18 PM, Jozef Hartinger <jharting(a)redhat.com&gt; wrote: > Hi Emily, > > thanks for the feedback. We're currently busy with other releases but > I'll try to get 2.2.15.Final released soon. > > Jozef > > On 20.7.2015 14:43, Emily Jiang wrote: > >> The test applications we used were attached to the jira >> https://developer.jboss.org/message/926035#926035. >> >> You can compare the responding time between two servlet requests. >> >> Can you commit the current changes in the release 2.2.15.Final because >> I plan to consume this release for other jira fixes as well? >> Thanks >> Emily >> >> On Mon, Jul 20, 2015 at 11:15 AM, Martin Kouba <mkouba(a)redhat.com >> <mailto:mkouba@redhat.com>> wrote: >> >> Hi Emily, >> >> it's great to hear there is a performance improvement (although 1% >> is not that much). We're working on further performance improvements >> in this area [1]. >> >> However, 23% additional overhead seems to me too much. Would it be >> possible to share your performance test case / test application? We >> could run similar tests in our environment and verify that there's >> no integration problem. >> >> Martin >> >> [1] >> https://issues.jboss.org/browse/WELD-1970 >> >> >> Dne 20.7.2015 v 11:12 Emily Jiang napsal(a): >> >> Hi Jozef, Martin, >> >> Sorry for the delay! I have the performance figure collected >> eventually. >> With this Jira's changes, it shows 1% performance improvement. >> This is a >> step in the right direction but there is still a performance hit >> (23% >> worse) when turning on CDI. Would you like to commit this change >> so that >> I can reconsume this release? It will be great if a further >> performance >> improvement can be done. I am happy to collect the performance >> benchmark >> if needed. >> >> Thanks >> Emily >> >> On Thu, Jul 2, 2015 at 8:35 AM, Jozef Hartinger >> <jharting(a)redhat.com <mailto:jharting@redhat.com> >> <mailto:jharting@redhat.com <mailto:jharting@redhat.com>>> >> wrote: >> >> Hi Emily, >> >> that should not be a problem. Would it be possible for you >> to test >> the performance improvement before we actually do the >> release? I can >> prepare a separate branch or send you a binary. I would >> like to see >> how much improvement this makes in your benchmark. >> >> Jozef >> >> >> On 07/01/2015 06:19 PM, Emily Jiang wrote: >> >> Is it possible to get the following jira fix committed >> to >> 2.2.15.Final? >> >> https://issues.jboss.org/browse/WELD-1931 >> >> I would like to consume this and see how much >> improvement has been >> made. >> >> -- >> Thanks >> Emily >> ================= >> Emily Jiang >> ejiang(a)apache.org <mailto:ejiang@apache.org> >> <mailto:ejiang@apache.org <mailto:ejiang@apache.org>> >> >> >> >> >> >> -- >> Thanks >> Emily >> ================= >> Emily Jiang >> ejiang(a)apache.org <mailto:ejiang@apache.org> >> <mailto:ejiang@apache.org <mailto:ejiang@apache.org>> >> >> >> >> >> >> -- >> Thanks >> Emily >> ================= >> Emily Jiang >> ejiang(a)apache.org <mailto:ejiang@apache.org> >> > -- Thanks Emily ================= Emily Jiang ejiang(a)apache.org