Folks, this <exclude> stuff in test-ng.xml is a problem. Right now we are down to less than 180 tests from almost 220. and my guess is this is because a bunch of tests that are actually passing have been accidentally excluded. Nick, I think some of your tests fall into this category. Am I right? The real danger is that there are failing tests, that *should* pass, which have been excluded. -- Gavin King gavin.king(a)gmail.com http://in.relation.to/Bloggers/Gavin http://hibernate.org http://seamframework.org _______________________________________________ webbeans-dev mailing list webbeans-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/webbeans-dev

I tried adding a "stub" group to all tests which explicitly did an assert false (or was blank), it brought the number of tests to ~200. On Wed, Nov 12, 2008 at 7:15 PM, Nicklas Karlsson <nickarls(a)gmail.com&gt; wrote: > Yep, I agree. In addition, the groups have been added without that > much of a (documented) plan(?) > > I proposed to Pete that we would have a "stub" group that we would > explicitly place on stuff that > was unfinished and that would be the only one excluded but it was just > before he left so he didn't have > time to comment... > > On Wed, Nov 12, 2008 at 6:56 PM, Gavin King <gavin(a)hibernate.org&gt; wrote: >> Folks, this <exclude> stuff in test-ng.xml is a problem. >> >> Right now we are down to less than 180 tests from almost 220. and my >> guess is this is because a bunch of tests that are actually passing >> have been accidentally excluded. >> >> Nick, I think some of your tests fall into this category. Am I right? >> >> The real danger is that there are failing tests, that *should* pass, >> which have been excluded. >> >> >> -- >> Gavin King >> gavin.king(a)gmail.com >> http://in.relation.to/Bloggers/Gavin >> http://hibernate.org >> http://seamframework.org >> _______________________________________________ >> webbeans-dev mailing list >> webbeans-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/webbeans-dev >> > > > > -- > --- > Nik > -- --- Nik

I tried adding a "stub" group to all tests which explicitly did an assert false (or was blank), it brought the number of tests to ~200. On Wed, Nov 12, 2008 at 7:15 PM, Nicklas Karlsson <nickarls(a)gmail.com&gt; wrote: > Yep, I agree. In addition, the groups have been added without that > much of a (documented) plan(?) > > I proposed to Pete that we would have a "stub" group that we would > explicitly place on stuff that > was unfinished and that would be the only one excluded but it was just > before he left so he didn't have > time to comment... > > On Wed, Nov 12, 2008 at 6:56 PM, Gavin King <gavin(a)hibernate.org&gt; wrote: >> Folks, this <exclude> stuff in test-ng.xml is a problem. >> >> Right now we are down to less than 180 tests from almost 220. and my >> guess is this is because a bunch of tests that are actually passing >> have been accidentally excluded. >> >> Nick, I think some of your tests fall into this category. Am I right? >> >> The real danger is that there are failing tests, that *should* pass, >> which have been excluded. >> >> >> -- >> Gavin King >> gavin.king(a)gmail.com >> http://in.relation.to/Bloggers/Gavin >> http://hibernate.org >> http://seamframework.org >> _______________________________________________ >> webbeans-dev mailing list >> webbeans-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/webbeans-dev >> > > > > -- > --- > Nik > -- --- Nik _______________________________________________ webbeans-dev mailing list webbeans-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/webbeans-dev

As I said in the other email, which only just got sent, we lost about 20 tests as they were checking XML stuff which I we lost due to the changes in the model (and the prioritization of web-beans.xml for after the alpha). On 13 Nov 2008, at 07:03, Gavin King wrote: > That's much better :-) > > On Wed, Nov 12, 2008 at 3:03 PM, Nicklas Karlsson <nickarls(a)gmail.com&gt; > wrote: >> >> I tried adding a "stub" group to all tests which explicitly did an >> assert false (or was blank), it brought the number of tests to ~200. >> >> On Wed, Nov 12, 2008 at 7:15 PM, Nicklas Karlsson <nickarls(a)gmail.com&gt; >> wrote: >>> >>> Yep, I agree. In addition, the groups have been added without that >>> much of a (documented) plan(?) >>> >>> I proposed to Pete that we would have a "stub" group that we would >>> explicitly place on stuff that >>> was unfinished and that would be the only one excluded but it was just >>> before he left so he didn't have >>> time to comment... >>> >>> On Wed, Nov 12, 2008 at 6:56 PM, Gavin King <gavin(a)hibernate.org&gt; wrote: >>>> >>>> Folks, this <exclude> stuff in test-ng.xml is a problem. >>>> >>>> Right now we are down to less than 180 tests from almost 220. and my >>>> guess is this is because a bunch of tests that are actually passing >>>> have been accidentally excluded. >>>> >>>> Nick, I think some of your tests fall into this category. Am I right? >>>> >>>> The real danger is that there are failing tests, that *should* pass, >>>> which have been excluded. >>>> >>>> >>>> -- >>>> Gavin King >>>> gavin.king(a)gmail.com >>>> http://in.relation.to/Bloggers/Gavin >>>> http://hibernate.org >>>> http://seamframework.org >>>> _______________________________________________ >>>> webbeans-dev mailing list >>>> webbeans-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/webbeans-dev >>>> >>> >>> >>> >>> -- >>> --- >>> Nik >>> >> >> >> >> -- >> --- >> Nik >> _______________________________________________ >> webbeans-dev mailing list >> webbeans-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/webbeans-dev >> > > > > -- > Gavin King > gavin.king(a)gmail.com > http://in.relation.to/Bloggers/Gavin > http://hibernate.org > http://seamframework.org > _______________________________________________ > webbeans-dev mailing list > webbeans-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/webbeans-dev