Probably should be public abstract Set<? extends Type> getTypes(); not public abstract Set<Type> getTypes(); -- Pete Muir http://www.seamframework.org http://in.relation.to/Bloggers/Pete

I also notice that you have: public abstract Set<? extends InjectionPoint> getInjectionPoints(); are you sure that is correct? Do I also need to make that change? On Wed, May 6, 2009 at 9:33 PM, Gavin King <gavin.king(a)gmail.com&gt; wrote: > OK, I see you already made this change in the RI, so I will make it > in the spec. > > On Thu, Mar 12, 2009 at 9:56 AM, Pete Muir <pete.muir(a)jboss.org&gt; > wrote: >> Probably should be >> >> public abstract Set<? extends Type> getTypes(); >> >> not >> >> public abstract Set<Type> getTypes(); >> >> -- >> Pete Muir >> http://www.seamframework.org >> http://in.relation.to/Bloggers/Pete >> >> > > > > -- > Gavin King > gavin.king(a)gmail.com > http://in.relation.to/Bloggers/Gavin > http://hibernate.org > http://seamframework.org > -- Gavin King gavin.king(a)gmail.com http://in.relation.to/Bloggers/Gavin http://hibernate.org http://seamframework.org _______________________________________________ webbeans-dev mailing list webbeans-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/webbeans-dev

Good point. I altered the API to not return bounded wildcards... On 7 May 2009, at 10:53, Emmanuel Bernard wrote: > Returning bounded wildcards makes APIs quite annoying to use, is that > necessary? > > On  May 7, 2009, at 04:35, Gavin King wrote: > >> I also notice that you have: >> >>  public abstract Set<? extends InjectionPoint> getInjectionPoints(); >> >> are you sure that is correct? Do I also need to make that change? >> >> On Wed, May 6, 2009 at 9:33 PM, Gavin King <gavin.king(a)gmail.com&gt; wrote: >>> >>> OK, I see you already made this change in the RI, so I will make it in >>> the spec. >>> >>> On Thu, Mar 12, 2009 at 9:56 AM, Pete Muir <pete.muir(a)jboss.org&gt; wrote: >>>> >>>> Probably should be >>>> >>>> public abstract Set<? extends Type> getTypes(); >>>> >>>> not >>>> >>>> public abstract Set<Type> getTypes(); >>>> >>>> -- >>>> Pete Muir >>>> http://www.seamframework.org >>>> http://in.relation.to/Bloggers/Pete >>>> >>>> >>> >>> >>> >>> -- >>> Gavin King >>> gavin.king(a)gmail.com >>> http://in.relation.to/Bloggers/Gavin >>> http://hibernate.org >>> http://seamframework.org >>> >> >> >> >> -- >> Gavin King >> gavin.king(a)gmail.com >> http://in.relation.to/Bloggers/Gavin >> http://hibernate.org >> http://seamframework.org >> _______________________________________________ >> webbeans-dev mailing list >> webbeans-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/webbeans-dev > -- Pete Muir http://www.seamframework.org http://in.relation.to/Bloggers/Pete

Sorry, yes :-/ On 7 May 2009, at 14:07, Gavin King wrote: > So now I'm changing the spec back?? > > On Thu, May 7, 2009 at 5:56 AM, Pete Muir <pete.muir(a)jboss.org&gt; wrote: >> >> Good point. I altered the API to not return bounded wildcards... >> >> On 7 May 2009, at 10:53, Emmanuel Bernard wrote: >> >>> Returning bounded wildcards makes APIs quite annoying to use, is that >>> necessary? >>> >>> On  May 7, 2009, at 04:35, Gavin King wrote: >>> >>>> I also notice that you have: >>>> >>>>  public abstract Set<? extends InjectionPoint> getInjectionPoints(); >>>> >>>> are you sure that is correct? Do I also need to make that change? >>>> >>>> On Wed, May 6, 2009 at 9:33 PM, Gavin King <gavin.king(a)gmail.com&gt; >>>> wrote: >>>>> >>>>> OK, I see you already made this change in the RI, so I will make it in >>>>> the spec. >>>>> >>>>> On Thu, Mar 12, 2009 at 9:56 AM, Pete Muir <pete.muir(a)jboss.org&gt; >>>>> wrote: >>>>>> >>>>>> Probably should be >>>>>> >>>>>> public abstract Set<? extends Type> getTypes(); >>>>>> >>>>>> not >>>>>> >>>>>> public abstract Set<Type> getTypes(); >>>>>> >>>>>> -- >>>>>> Pete Muir >>>>>> http://www.seamframework.org >>>>>> http://in.relation.to/Bloggers/Pete >>>>>> >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Gavin King >>>>> gavin.king(a)gmail.com >>>>> http://in.relation.to/Bloggers/Gavin >>>>> http://hibernate.org >>>>> http://seamframework.org >>>>> >>>> >>>> >>>> >>>> -- >>>> Gavin King >>>> gavin.king(a)gmail.com >>>> http://in.relation.to/Bloggers/Gavin >>>> http://hibernate.org >>>> http://seamframework.org >>>> _______________________________________________ >>>> webbeans-dev mailing list >>>> webbeans-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/webbeans-dev >>> >> >> -- >> Pete Muir >> http://www.seamframework.org >> http://in.relation.to/Bloggers/Pete >> >> > > > > -- > Gavin King > gavin.king(a)gmail.com > http://in.relation.to/Bloggers/Gavin > http://hibernate.org > http://seamframework.org -- Pete Muir http://www.seamframework.org http://in.relation.to/Bloggers/Pete