[hibernate-commits] [hibernate/hibernate-search] 145f9f: HSEARCH-4647 Slightly simplify the mechanics of re...

Branch: refs/heads/main Home: https://github.com/hibernate/hibernate-search Commit: 145f9f4f7f685d0a7dd165eef82c098ed6191687 https://github.com/hibernate/hibernate-search/commit/145f9f4f7f685d0a7dd1... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-01 (Mon, 01 Aug 2022) Changed paths: M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AbstractAgentClusterLink.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingEventProcessorClusterLink.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingMassIndexerAgentClusterLink.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AbstractEventProcessorClusterLinkBaseTest.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AbstractMassIndexerAgentClusterLinkBaseTest.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/EventProcessorClusterLinkMixedSharding4ShardSelfStaticBaseTest.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/EventProcessorClusterLinkStaticSharding4ShardBaseTest.java Log Message: ----------- HSEARCH-4647 Slightly simplify the mechanics of retries in outbox polling coordination Commit: 37840d858110c4508c8234197abf1acbfae24a2e https://github.com/hibernate/hibernate-search/commit/37840d858110c4508c82... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-01 (Mon, 01 Aug 2022) Changed paths: M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingEventProcessor.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingMassIndexerAgent.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/mapping/impl/OutboxPollingSearchMappingImpl.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/common/spi/TransactionHelper.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/loading/impl/HibernateOrmMassEntityLoader.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/loading/impl/HibernateOrmMassIdentifierLoader.java Log Message: ----------- HSEARCH-4647 Make the transaction timeout an attribute of TransactionHelper Instead of a parameter of its methods, so that we can pass a fully parameterized TransactionHelper to other objects that have no idea what the timeout should be. In short, this is about separation of concerns in the changes coming in the next commits. Commit: d36f82e2ddc24d1275f0a00d141b380ea4a86ad5 https://github.com/hibernate/hibernate-search/commit/d36f82e2ddc24d1275f0... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-01 (Mon, 01 Aug 2022) Changed paths: M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingEventProcessor.java Log Message: ----------- HSEARCH-4647 Never perform event processing in the same transaction as a pulse ... to reduce transaction contention. Commit: b89e51ffb6ca7fbcc7825ce5a7681aed6130c914 https://github.com/hibernate/hibernate-search/commit/b89e51ffb6ca7fbcc782... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-01 (Mon, 01 Aug 2022) Changed paths: M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingEventProcessor.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingMassIndexerAgent.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/mapping/impl/OutboxPollingSearchMappingImpl.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/common/spi/TransactionHelper.java M orm6/mapper/orm-coordination-outbox-polling/ant-src-changes.patch M orm6/mapper/orm/ant-src-changes.patch Log Message: ----------- HSEARCH-4647 Remove unnecessary parameter in lambdas passed to TransactionHelper We were always using the session from the surrounding context anyway, so the parameter was not useful. Commit: e5b1439c996c1852f3f38a2090406b9213daf1ba https://github.com/hibernate/hibernate-search/commit/e5b1439c996c1852f3f3... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-01 (Mon, 01 Aug 2022) Changed paths: M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingEventProcessor.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingMassIndexerAgent.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/common/spi/SessionHelper.java Log Message: ----------- HSEARCH-4647 Simplify the execution of code in a Hibernate ORM session This will be useful for unit testing, in particular, where we want to abstract away from sessions. Commit: a1ee30cce3438cf1d4b8855679fdcbafac40e543 https://github.com/hibernate/hibernate-search/commit/a1ee30cce3438cf1d4b8... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-01 (Mon, 01 Aug 2022) Changed paths: M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AbstractAgentClusterLink.java A mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AgentClusterLinkContext.java A mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AgentClusterLinkContextProvider.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingEventProcessor.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingMassIndexerAgent.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AbstractEventProcessorClusterLinkBaseTest.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AbstractEventProcessorClusterLinkTest.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AbstractMassIndexerAgentClusterLinkBaseTest.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AbstractMassIndexerAgentClusterLinkTest.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/EventProcessorClusterLinkDynamicShardingBaseTest.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/EventProcessorClusterLinkLeaveClusterTest.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/EventProcessorClusterLinkStaticShardingEdgeCasesTest.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/MassIndexerAgentClusterLinkLeaveClusterTest.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/common/spi/SessionHelper.java Log Message: ----------- HSEARCH-4647 Move transaction boundary control to AgentClusterLinks This does not change the behavior of outbox polling, but lays the groundwork to changing it. This will be necessary in the following commits. Commit: e5011c3dcb58ff0856cf28a4960ef0ac00a29e71 https://github.com/hibernate/hibernate-search/commit/e5011c3dcb58ff0856cf... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-01 (Mon, 01 Aug 2022) Changed paths: M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/cluster/impl/AgentPersister.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AbstractAgentClusterLink.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/logging/impl/Log.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AgentRepositoryMockingHelper.java Log Message: ----------- HSEARCH-4647 When registering an outbox-polling agent, do not do anything else in the same transaction So that the risk of deadlocks (see below) is minimal and other agents are made aware of this agent as soon as possible. This avoids unnecessary rebalancing when multiple nodes start in quick succession to each other. Commit: de48fa51ef755801ed6b962848a42f2485e5d4eb https://github.com/hibernate/hibernate-search/commit/de48fa51ef755801ed6b... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-01 (Mon, 01 Aug 2022) Changed paths: M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AbstractAgentClusterLink.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingEventProcessorClusterLink.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingMassIndexerAgentClusterLink.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AbstractEventProcessorClusterLinkTest.java M mapper/orm-coordination-outbox-polling/src/test/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/AbstractMassIndexerAgentClusterLinkTest.java Log Message: ----------- HSEARCH-4647 Split outbox polling transactions into smaller chunks ... to reduce transaction contention. Commit: bc55c995936411eb51fdcb7db0b1912d64661820 https://github.com/hibernate/hibernate-search/commit/bc55c995936411eb51fd... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-01 (Mon, 01 Aug 2022) Changed paths: M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingEventProcessorClusterLink.java Log Message: ----------- HSEARCH-4647 Avoid confusing TRACE statements where no agents are to be suspended Commit: da9ce3efe64aa5e25445014da432dbadfa764a22 https://github.com/hibernate/hibernate-search/commit/da9ce3efe64aa5e25445... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-01 (Mon, 01 Aug 2022) Changed paths: M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxEventLoader.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxEventUpdater.java M mapper/orm-coordination-outbox-polling/src/main/java/org/hibernate/search/mapper/orm/coordination/outboxpolling/event/impl/OutboxPollingEventProcessor.java Log Message: ----------- HSEARCH-4634 Fall back to traditional, blocking locks for outbox event deletion when SKIP_LOCKED is not supported Commit: ec335a11ae93d930c7563a688010d63a40f000f6 https://github.com/hibernate/hibernate-search/commit/ec335a11ae93d930c756... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2022-08-01 (Mon, 01 Aug 2022) Changed paths: M Jenkinsfile M integrationtest/mapper/orm-realbackend/src/test/java/org/hibernate/search/integrationtest/mapper/orm/realbackend/limitations/ConcurrentEmbeddedUpdateLimitationIT.java A orm6/integrationtest/mapper/orm-realbackend/ant-src-changes.patch M parents/integrationtest/pom.xml M pom.xml Log Message: ----------- HSEARCH-4644 Test against CockroachDB in continuous integration Compare: https://github.com/hibernate/hibernate-search/compare/2c08486db99c...ec33...