[hibernate-commits] [hibernate/hibernate-validator] a0c142: HV-433 adding test and initial fix

Branch: refs/heads/master Home: https://github.com/hibernate/hibernate-validator Commit: a0c142f475ff3e09cb304f89c7f4135eaebd90bc https://github.com/hibernate/hibernate-validator/commit/a0c142f475ff3e09c... Author: Hardy Ferentschik <hibernate(a)ferentschik.de&gt; Date: 2011-02-24 (Thu, 24 Feb 2011) Changed paths: M hibernate-validator/src/main/java/org/hibernate/validator/metadata/BeanMetaDataImpl.java M hibernate-validator/src/main/java/org/hibernate/validator/metadata/MethodMetaData.java M hibernate-validator/src/main/java/org/hibernate/validator/metadata/ParameterMetaData.java A hibernate-validator/src/test/java/org/hibernate/validator/test/cfg/CascadingWithConstraintMappingTest.java Log Message: ----------- HV-433 adding test and initial fix Commit: 83aa07e67ec85f3333cbf0b08cae1a7cd3c3de0d https://github.com/hibernate/hibernate-validator/commit/83aa07e67ec85f333... Author: Hardy Ferentschik <hibernate(a)ferentschik.de&gt; Date: 2011-02-24 (Thu, 24 Feb 2011) Changed paths: M hibernate-validator/src/main/java/org/hibernate/validator/HibernateValidatorConfiguration.java M hibernate-validator/src/main/java/org/hibernate/validator/metadata/BeanMetaData.java Log Message: ----------- HV-433 Issue unrelated changes. Interface members are always public Commit: a802c53c160190c3f1da36563ae8cd8b12c7a91b https://github.com/hibernate/hibernate-validator/commit/a802c53c160190c3f... Author: Hardy Ferentschik <hibernate(a)ferentschik.de&gt; Date: 2011-02-24 (Thu, 24 Feb 2011) Changed paths: M hibernate-validator-annotation-processor/src/main/java/org/hibernate/validator/ap/ConstraintAnnotationVisitor.java M hibernate-validator-annotation-processor/src/main/java/org/hibernate/validator/ap/checks/ConstraintCheckError.java M hibernate-validator/src/main/java/org/hibernate/validator/HibernateValidatorContext.java M hibernate-validator/src/main/java/org/hibernate/validator/constraints/ScriptAssert.java M hibernate-validator/src/main/java/org/hibernate/validator/constraints/impl/DigitsValidatorForString.java M hibernate-validator/src/main/java/org/hibernate/validator/engine/MethodParameterNodeImpl.java M hibernate-validator/src/main/java/org/hibernate/validator/engine/MethodReturnValueNodeImpl.java M hibernate-validator/src/main/java/org/hibernate/validator/method/MethodValidator.java Log Message: ----------- HV-433 Issue unrelated changes. Fixing some Sonar style warnings. Javadocs @link statements introduced an import statement. Using the fqn in the javadocs seems nicer (at the very least it let's Sonar shut up ;-) Commit: 9e0902728074e745cadf61ce9ef0db7033b82728 https://github.com/hibernate/hibernate-validator/commit/9e0902728074e745c... Author: Hardy Ferentschik <hibernate(a)ferentschik.de&gt; Date: 2011-02-24 (Thu, 24 Feb 2011) Changed paths: M hibernate-validator/src/main/java/org/hibernate/validator/metadata/BeanMetaDataImpl.java M hibernate-validator/src/test/java/org/hibernate/validator/test/cfg/CascadingWithConstraintMappingTest.java Log Message: ----------- HV-433 Introducing metaDataCached flag (this time outside the inner loop). Adding comments to the jira issue. Commit: 0db945ab4bb3d1b28b4eb30922d5c341c55fde95 https://github.com/hibernate/hibernate-validator/commit/0db945ab4bb3d1b28... Author: Hardy Ferentschik <hibernate(a)ferentschik.de&gt; Date: 2011-02-24 (Thu, 24 Feb 2011) Changed paths: M hibernate-validator/src/test/java/org/hibernate/validator/test/cfg/CascadingWithConstraintMappingTest.java Log Message: ----------- HV-433 Adding a test for method access Commit: 565aa09a8aa834d91542ec79089a6c716093dc13 https://github.com/hibernate/hibernate-validator/commit/565aa09a8aa834d91... Author: Hardy Ferentschik <hibernate(a)ferentschik.de&gt; Date: 2011-02-24 (Thu, 24 Feb 2011) Changed paths: M hibernate-validator/src/main/java/org/hibernate/validator/engine/ValidatorFactoryImpl.java M hibernate-validator/src/main/java/org/hibernate/validator/engine/ValidatorImpl.java M hibernate-validator/src/main/java/org/hibernate/validator/metadata/BeanMetaData.java M hibernate-validator/src/main/java/org/hibernate/validator/metadata/BeanMetaDataImpl.java Log Message: ----------- HV-433 Changing BeanMetaDataImpl so that the test passes also with method level annotations Changing the caascadeMembers to be a set, since this seems the better abstraction. Using CollectionHelper to instantiate maps and sets. Adding some comments Commit: 3753410b9a5984d217445f0fb46e0a6859c20df5 https://github.com/hibernate/hibernate-validator/commit/3753410b9a5984d21... Author: Hardy Ferentschik <hibernate(a)ferentschik.de&gt; Date: 2011-02-24 (Thu, 24 Feb 2011) Changed paths: M hibernate-validator/src/main/java/org/hibernate/validator/metadata/BeanMetaDataImpl.java M hibernate-validator/src/main/java/org/hibernate/validator/util/CollectionHelper.java Log Message: ----------- HV-433 Using static CollectionHelper imports. Also added additional helper method which take an initial size parameter. Also setting allMethods to null at the end of instance construction Commit: 974b39b336b9ceba2230556fc8ab1d6e4db924d6 https://github.com/hibernate/hibernate-validator/commit/974b39b336b9ceba2... Author: Hardy Ferentschik <hibernate(a)ferentschik.de&gt; Date: 2011-02-24 (Thu, 24 Feb 2011) Changed paths: M hibernate-validator/src/test/java/org/hibernate/validator/test/cfg/CascadingWithConstraintMappingTest.java Log Message: ----------- HV-433 Refactoring test and adding a new test for method level validation Commit: adc5189413f058aa560a9ea504d6c2306420e602 https://github.com/hibernate/hibernate-validator/commit/adc5189413f058aa5... Author: Hardy Ferentschik <hibernate(a)ferentschik.de&gt; Date: 2011-02-24 (Thu, 24 Feb 2011) Changed paths: M hibernate-validator/src/main/java/org/hibernate/validator/metadata/BeanMetaDataImpl.java Log Message: ----------- HV-433 When it comes down to it, constraintHelper is not needed anymore after construction either Commit: fdd412431b32d6b34dd11eaabeae0a053c115602 https://github.com/hibernate/hibernate-validator/commit/fdd412431b32d6b34... Author: Gunnar Morling <gunnar.morling(a)googlemail.com&gt; Date: 2011-02-24 (Thu, 24 Feb 2011) Changed paths: M hibernate-validator/src/main/java/org/hibernate/validator/metadata/BeanMetaDataImpl.java Log Message: ----------- HV-433: Fixing typo