[hibernate-commits] Hibernate SVN: r10980 - in branches/Branch_3_2/Hibernate3/test/org/hibernate: junit/functional test test/bidi test/legacy
Author: steve.ebersole(a)jboss.com
Date: 2006-12-12 19:13:43 -0500 (Tue, 12 Dec 2006)
New Revision: 10980
Modified:
branches/Branch_3_2/Hibernate3/test/org/hibernate/junit/functional/FunctionalTestCase.java
branches/Branch_3_2/Hibernate3/test/org/hibernate/test/AllTests.java
branches/Branch_3_2/Hibernate3/test/org/hibernate/test/bidi/AuctionTest2.java
branches/Branch_3_2/Hibernate3/test/org/hibernate/test/legacy/MasterDetailTest.java
Log:
cleanup
Modified:
branches/Branch_3_2/Hibernate3/test/org/hibernate/junit/functional/FunctionalTestCase.java
===================================================================
---
branches/Branch_3_2/Hibernate3/test/org/hibernate/junit/functional/FunctionalTestCase.java 2006-12-13
00:13:19 UTC (rev 10979)
+++
branches/Branch_3_2/Hibernate3/test/org/hibernate/junit/functional/FunctionalTestCase.java 2006-12-13
00:13:43 UTC (rev 10980)
@@ -377,7 +377,7 @@
* @return true if sensitive
*/
protected boolean dialectIsCaseSensitive(String testDescription) {
- if ( getDialect().areStringComparisonsCaseInsensitive() ) {
+ if ( ! getDialect().areStringComparisonsCaseInsensitive() ) {
reportSkip( "Dialect is case sensitive. ", testDescription );
return true;
}
Modified: branches/Branch_3_2/Hibernate3/test/org/hibernate/test/AllTests.java
===================================================================
--- branches/Branch_3_2/Hibernate3/test/org/hibernate/test/AllTests.java 2006-12-13
00:13:19 UTC (rev 10979)
+++ branches/Branch_3_2/Hibernate3/test/org/hibernate/test/AllTests.java 2006-12-13
00:13:43 UTC (rev 10980)
@@ -322,7 +322,6 @@
suite.addTest( OneToOneCacheTest.suite() );
suite.addTest( NonReflectiveBinderTest.suite() );
suite.addTest( ConfigurationPerformanceTest.suite() ); // Added to ensure we can
utilize the recommended performance tips ;)
- suite.addTest( CustomSQLTest.suite() );
return filter( suite );
// return suite;
}
Modified: branches/Branch_3_2/Hibernate3/test/org/hibernate/test/bidi/AuctionTest2.java
===================================================================
---
branches/Branch_3_2/Hibernate3/test/org/hibernate/test/bidi/AuctionTest2.java 2006-12-13
00:13:19 UTC (rev 10979)
+++
branches/Branch_3_2/Hibernate3/test/org/hibernate/test/bidi/AuctionTest2.java 2006-12-13
00:13:43 UTC (rev 10980)
@@ -26,14 +26,18 @@
return new String[] { "bidi/Auction2.hbm.xml" };
}
+ public boolean createSchema() {
+ return getDialect().supportsExistsInSelect();
+ }
+
public static Test suite() {
return new FunctionalTestClassTestSuite( AuctionTest2.class );
}
public void testLazy() {
-
- if ( getDialect() instanceof Oracle9Dialect ) {
- return; //ora doesn't like exists() in the select clause
+ if ( ! getDialect().supportsExistsInSelect() ) {
+ reportSkip( "dialect does not support exist fragments in the select clause",
"bidi support" );
+ return;
}
Session s = openSession();
Modified:
branches/Branch_3_2/Hibernate3/test/org/hibernate/test/legacy/MasterDetailTest.java
===================================================================
---
branches/Branch_3_2/Hibernate3/test/org/hibernate/test/legacy/MasterDetailTest.java 2006-12-13
00:13:19 UTC (rev 10979)
+++
branches/Branch_3_2/Hibernate3/test/org/hibernate/test/legacy/MasterDetailTest.java 2006-12-13
00:13:43 UTC (rev 10980)
@@ -877,7 +877,7 @@
ss.close();
s.refresh(c);
- assertTrue( c.getSubcategories().size()==2 );
+ assertEquals( 2, c.getSubcategories().size() );
s.flush();
s.connection().commit();
@@ -885,7 +885,7 @@
s = openSession();
c = (Category) s.load(Category.class, id);
- assertTrue( c.getSubcategories().size()==2 );
+ assertEquals( 2, c.getSubcategories().size() );
s.delete(c);
s.flush();
s.connection().commit();