[hibernate-commits] [hibernate/hibernate-search] 262ce5: HSEARCH-3170 Remove unused methods related to Cont...

Branch: refs/heads/master Home: https://github.com/hibernate/hibernate-search Commit: 262ce53661468f1931f5d0c7cc83354e9b5293ad https://github.com/hibernate/hibernate-search/commit/262ce53661468f1931f5... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-12-11 (Tue, 11 Dec 2018) Changed paths: M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/extractor/impl/ContainerValueExtractorBinder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoIndexModelBinder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoIndexModelBinderImpl.java Log Message: ----------- HSEARCH-3170 Remove unused methods related to ContainerValueExtractors We are going to change this code to introduce bean holders, so the less code, the better. Commit: b3b8c12ffd2dcde71d4c78f9facd5612b7cd3171 https://github.com/hibernate/hibernate-search/commit/b3b8c12ffd2dcde71d4c... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-12-11 (Tue, 11 Dec 2018) Changed paths: M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/AbstractPojoImplicitReindexingResolverNodeBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/AbstractPojoImplicitReindexingResolverTypeNodeBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoImplicitReindexingResolverBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoImplicitReindexingResolverBuildingHelper.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoImplicitReindexingResolverContainerElementNodeBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoImplicitReindexingResolverMarkingNodeBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoImplicitReindexingResolverPropertyNodeBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoImplicitReindexingResolverValueNodeBuilderDelegate.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/impl/DefaultPojoImplicitReindexingResolver.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/impl/NoOpPojoImplicitReindexingResolver.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/impl/NoOpPojoImplicitReindexingResolverNode.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/impl/PojoImplicitReindexingResolver.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/impl/PojoImplicitReindexingResolverCastedTypeNode.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/impl/PojoImplicitReindexingResolverContainerElementNode.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/impl/PojoImplicitReindexingResolverDirtinessFilterNode.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/impl/PojoImplicitReindexingResolverMarkingNode.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/impl/PojoImplicitReindexingResolverNode.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/impl/PojoImplicitReindexingResolverOriginalTypeNode.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/impl/PojoImplicitReindexingResolverPropertyNode.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoMapper.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/PojoContainedTypeManager.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/PojoIndexedTypeManager.java Log Message: ----------- HSEARCH-3170 Add "close"/"closeOnFailure" methods to Pojo reindexing resolvers and their builders We are going to need this because they instantiate container value extractors, which are beans and need to be released. Commit: b6f750f57032af2c1194e38089c9268340821a76 https://github.com/hibernate/hibernate-search/commit/b6f750f57032af2c1194... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-12-11 (Tue, 11 Dec 2018) Changed paths: A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/impl/BeanBridgeBuilder.java R mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/impl/BeanResolverBridgeBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/impl/AnnotationProcessorHelper.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/AbstractPropertyFieldMappingContext.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/InitialPropertyMappingContext.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/PropertyDocumentIdMappingContextImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/programmatic/impl/TypeMappingContextImpl.java Log Message: ----------- HSEARCH-3170 Rename BeanResolverBridgeBuilder to BeanBridgeBuilder and document it The name was confusing, and we're about to add a similar, but not identical builder, so we'd better be as clear as possible. Commit: f54d3bd754b1f90b6a01c6e967b9afc5baafe11d https://github.com/hibernate/hibernate-search/commit/f54d3bd754b1f90b6a01... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-12-11 (Tue, 11 Dec 2018) Changed paths: M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/mapping/definition/AnnotationMappingDiscoveryIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/AnnotationMappingDiscoveryIT.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/builtin/spatial/impl/LatitudeMarker.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/builtin/spatial/impl/LongitudeMarker.java A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/mapping/MarkerBuildContext.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/mapping/MarkerBuilder.java A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/MarkerBuildContextImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoMapper.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/additionalmetadata/building/impl/PojoPropertyAdditionalMetadataBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/additionalmetadata/building/impl/PojoTypeAdditionalMetadataBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/model/additionalmetadata/building/impl/PojoTypeAdditionalMetadataProvider.java Log Message: ----------- HSEARCH-3170 Pass a build context to marker builders First because it seems to make sense, considering these builders are very similar to bridge builders, and we may want to pass more context in the future. Second, because we will need access to the bean provider in order to implement the marker builder lifecycle (releasing in particular) properly in the next commits. Commit: f0f1b71a8f84bc820d04bbf555c9d372a22995b1 https://github.com/hibernate/hibernate-search/commit/f0f1b71a8f84bc820d04... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-12-11 (Tue, 11 Dec 2018) Changed paths: A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/impl/AnnotationInitializingBeanDelegatingBridgeBuilder.java A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/impl/AnnotationInitializingBeanDelegatingMarkerBuilder.java A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/impl/BeanDelegatingBridgeBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/impl/AnnotationMappingDefinitionContextImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/impl/AnnotationProcessorHelper.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/definition/annotation/impl/AnnotationProcessorProvider.java Log Message: ----------- HSEARCH-3170 Delay instantiation of bridge/marker builders until when they are actually needed This makes resource management easier: we will get the builder beans each time we need them, thus will be able to release them each time we use them, too. We may want something more optimized in the future, but for now this will do just fine. Especially because it's just bootstrap, and bridge builders are not expected to be very heavy most of the time. Commit: ff7b931fed380e43a9c87b2d7ab533526610938f https://github.com/hibernate/hibernate-search/commit/ff7b931fed380e43a9c8... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-12-11 (Tue, 11 Dec 2018) Changed paths: M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/impl/ElasticsearchBackendFactory.java M backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/impl/ElasticsearchBeanConfigurer.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBackendFactory.java M backend/lucene/src/main/java/org/hibernate/search/backend/lucene/impl/LuceneBeanConfigurer.java M engine/src/main/java/org/hibernate/search/engine/common/impl/IndexManagerBuildingStateHolder.java A engine/src/main/java/org/hibernate/search/engine/environment/bean/BeanHolder.java M engine/src/main/java/org/hibernate/search/engine/environment/bean/BeanProvider.java M engine/src/main/java/org/hibernate/search/engine/environment/bean/BeanReference.java M engine/src/main/java/org/hibernate/search/engine/environment/bean/CastingBeanReference.java M engine/src/main/java/org/hibernate/search/engine/environment/bean/InstanceBeanReference.java A engine/src/main/java/org/hibernate/search/engine/environment/bean/SimpleBeanHolder.java M engine/src/main/java/org/hibernate/search/engine/environment/bean/TypeAndNameBeanReference.java M engine/src/main/java/org/hibernate/search/engine/environment/bean/TypeBeanReference.java M engine/src/main/java/org/hibernate/search/engine/environment/bean/impl/BeanProviderImpl.java M engine/src/main/java/org/hibernate/search/engine/environment/bean/spi/BeanFactory.java M engine/src/main/java/org/hibernate/search/engine/environment/bean/spi/BeanResolver.java M engine/src/main/java/org/hibernate/search/engine/environment/bean/spi/ReflectionBeanResolver.java M engine/src/test/java/org/hibernate/search/engine/cfg/spi/ConfigurationPropertyBeanReferenceTest.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/smoke/bridge/CustomPropertyBridge.java M integrationtest/mapper/orm/src/test/java/org/hibernate/search/integrationtest/mapper/orm/smoke/bridge/CustomTypeBridge.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/lifecycle/CleanupIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/BridgeIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/IndexedEmbeddedBaseIT.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/smoke/bridge/CustomPropertyBridge.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/smoke/bridge/CustomTypeBridge.java A integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/test/util/CloseCountingBeanHolder.java M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/test/util/StartupStubBridge.java M integrationtest/showcase/library/src/main/java/org/hibernate/search/integrationtest/showcase/library/bridge/MultiKeywordStringBridge.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/bootstrap/impl/HibernateOrmBeanContainerBeanResolver.java A mapper/orm/src/main/java/org/hibernate/search/mapper/orm/bootstrap/impl/HibernateOrmContainedBeanBeanHolderAdapter.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/bootstrap/impl/HibernateSearchSessionFactoryObserver.java M mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMappingInitiator.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/builtin/spatial/impl/GeoPointBridge.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/impl/AnnotationInitializingBeanDelegatingBridgeBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/impl/AnnotationInitializingBeanDelegatingMarkerBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/impl/BeanBridgeBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/impl/BeanDelegatingBridgeBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/impl/BridgeResolver.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/mapping/BridgeBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/bridge/mapping/MarkerBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/extractor/impl/ContainerValueExtractorBinder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/BoundPropertyBridge.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/BoundRoutingKeyBridge.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/BoundTypeBridge.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/BoundValueBridge.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoIdentityMappingCollector.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoIndexModelBinder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoIndexModelBinderImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoIndexedTypeManagerBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/PropertyIdentifierMapping.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/RoutingKeyBridgeRoutingKeyProvider.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/PojoIndexingProcessorPropertyNodeBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/PojoIndexingProcessorTypeNodeBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/PojoIndexingProcessorValueNodeBuilderDelegate.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorPropertyNode.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorTypeNode.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorValueBridgeNode.java Log Message: ----------- HSEARCH-3170 Enclose beans retrieved from the provider in BeanHolders to allow early release This way, we don't need to hold a list of all beans and release them at shutdown. This is especially interesting for bootstrap-only beans, such as configurers, bridge builders, and so on, which we used to keep alive during the whole time Hibernate Search was running, even though they were only needed during bootstrap. Commit: b9322aac76254f39f320b2e9f732af418021b59e https://github.com/hibernate/hibernate-search/commit/b9322aac76254f39f320... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-12-11 (Tue, 11 Dec 2018) Changed paths: M engine/src/main/java/org/hibernate/search/engine/environment/bean/BeanHolder.java M engine/src/main/java/org/hibernate/search/engine/environment/bean/BeanProvider.java A engine/src/main/java/org/hibernate/search/engine/environment/bean/CompositeBeanHolder.java M engine/src/test/java/org/hibernate/search/engine/cfg/spi/ConfigurationPropertyBeanReferenceTest.java Log Message: ----------- HSEARCH-3170 Make it easier to work with multi-valued BeanReference properties now that we have to handle BeanHolders This will be useful in the next few commits in particular. Commit: 4760e6cd435ffcdb980ee927d7e7f6655342f308 https://github.com/hibernate/hibernate-search/commit/4760e6cd435ffcdb980e... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-12-11 (Tue, 11 Dec 2018) Changed paths: A engine/src/main/java/org/hibernate/search/engine/cfg/SearchEngineSettings.java M engine/src/main/java/org/hibernate/search/engine/common/impl/SearchIntegrationBuilderImpl.java R engine/src/main/java/org/hibernate/search/engine/environment/bean/impl/BeanProviderImpl.java A engine/src/main/java/org/hibernate/search/engine/environment/bean/impl/BeanResolverOnlyBeanProvider.java A engine/src/main/java/org/hibernate/search/engine/environment/bean/impl/ConfiguredBeanProvider.java Log Message: ----------- HSEARCH-3170 Allow to set additional bean configurers from configuration properties This will help when testing, in particular Commit: 677ef5c05efdecced1701e4ceb2a8a284a95f0f7 https://github.com/hibernate/hibernate-search/commit/677ef5c05efdecced170... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-12-11 (Tue, 11 Dec 2018) Changed paths: M engine/src/main/java/org/hibernate/search/engine/environment/bean/impl/BeanConfigurationContextImpl.java M engine/src/main/java/org/hibernate/search/engine/environment/bean/impl/ConfiguredBeanProvider.java M engine/src/main/java/org/hibernate/search/engine/environment/bean/spi/BeanConfigurationContext.java Log Message: ----------- HSEARCH-3170 Allow to define configured beans with a type reference only (without a name) This will be useful to register ContainerValueExtractor beans, in particular in the tests we will introduce in the following commits. Commit: a446b406755b5e50fb222468f9727aa0a44aa73a https://github.com/hibernate/hibernate-search/commit/a446b406755b5e50fb22... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-12-11 (Tue, 11 Dec 2018) Changed paths: M engine/src/main/java/org/hibernate/search/engine/environment/classpath/spi/ClassLoaderHelper.java M util/internal/common/src/main/java/org/hibernate/search/util/impl/common/Throwables.java Log Message: ----------- HSEARCH-3170 Use meaningful messages when nesting exceptions, relying on the cause chain if necessary InvocationTargetException, in particular, will not show any message, which used to result in something like "Got exception: null" in the failure report. Now we will try to get the message for the cause of that InvocationTargetException, which may be more informative. Commit: a85ca0656528e3b1cd28e49a5c63335b6fae5adb https://github.com/hibernate/hibernate-search/commit/a85ca0656528e3b1cd28... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-12-11 (Tue, 11 Dec 2018) Changed paths: M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoImplicitReindexingResolverBuildingHelper.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoImplicitReindexingResolverContainerElementNodeBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/building/impl/PojoImplicitReindexingResolverPropertyNodeBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/dirtiness/impl/PojoImplicitReindexingResolverContainerElementNode.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/extractor/impl/ContainerValueExtractorBinder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoIndexModelBinder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoIndexModelBinderImpl.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/PojoIndexingProcessorContainerElementNodeBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/processing/building/impl/PojoIndexingProcessorPropertyNodeBuilder.java M mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/processing/impl/PojoIndexingProcessorContainerElementNode.java Log Message: ----------- HSEARCH-3170 Close container value extractor bean holders as appropriate Commit: eb7fc511c6ef8e47fa55c18cc5bb8d3526278322 https://github.com/hibernate/hibernate-search/commit/eb7fc511c6ef8e47fa55... Author: Yoann Rodière <yoann(a)hibernate.org&gt; Date: 2018-12-11 (Tue, 11 Dec 2018) Changed paths: M integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/lifecycle/CleanupIT.java A integrationtest/mapper/pojo/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/test/util/StartupStubContainerValueExtractor.java A mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/extractor/impl/ContainerValueExtractorHolder.java Log Message: ----------- HSEARCH-3170 Test that container value extractor bean holders are properly closed Compare: https://github.com/hibernate/hibernate-search/compare/eb820f8597b2...eb7f... **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.