Re: [jboss-as7-dev] add operation in CLI GUI

On 1/12/2012 7:15 PM, Kabir Khan wrote: > On 12 Jan 2012, at 19:39, ssilvert(a)redhat.com wrote: > >> On 1/12/2012 1:09 PM, Kabir Khan wrote: >>>> On 1/12/2012 11:39 AM, Alexey Loubyansky wrote: >>>>> I could suggest two ways to workaround this: >>>>> >>>>> - node type as a 'folder', currently the unit is node-type=node-name, >>>>> instead node-type could be a folder that contained node-names and you >>>>> could click on the node-type to add new nodes. >>>> Early on I was going to do it this way, but it became clear that it >>>> would be overly complicated and would break with the directory notion in >>>> the CLI where a directory is /subsystem=jca/, not /subsystem/jca/. Once >>>> you replace = with / you lose sight of the underlying address scheme. >>> Could the structure perhaps be >>> subsystem/ >>> subsystem=jca >>> subsystem=jmx >>> Or is that too weird? >> I just tried that and it did indeed get weird. You end up with nodes >> that don't have any correspondence to the address path. So you have to >> code around it all over the place. It also made any sort of refresh >> impossible to implement without significant hacks. I do need to improve >> refresh at some point and I don't want to make that any harder than it >> already is. >> >> Try my three latest commits found here and let me know what you think: >> https://github.com/ssilvert/jboss-as/commits/cli-gui-fixadd >> >> Alexey, once you see it, let me know if you still think that "?" makes >> more sense than "*". That's an easy change. > It looks better, perhaps instead of * or ? some descriptive string (that will not crash with any names used, so something like ***Root***) could work. Just an idea, not sure if it is a good or bad one... I'm thinking of using a different icon to set it apart.