On Monday 28 November 2011 01:35 PM, Ondřej Žižka wrote:
Hi,
I did this intentionally - the intention was to skip unit tests but
run the testsuite - not to get the build failed if some module's unit
tests fail.
If a unit test fails the build should fail. There's
-Dmaven.test.failure.ignore=true if you want to ignore those test
failures. I don't know how the AS7 project handles the
-Dmaven.test.failure.ignore property due to our testsuite
profiles/customizations. But we shouldn't be adding new meaning to
already well known flags.
How about having two params for that, with -DskipTests for unit tests,
and, say, -DskipTestsuite for skipping the testsuite module's tests?
IMO, we shouldn't just be adding all these new flags which make it
complicated to understand what set of flags to use and when. The actual
question for this specific issue is what's the real usecase of skipping
unit tests (which potentially can have failures) but still want to run
the integration tests?
To be clear - IMO, we should have the -DskipTests back without adding a
new meaning to that param.
-Jaikiran
Ondra
-------- Přeposlaná zpráva --------
> *Od*: Darran Lofthouse (Created) (JIRA) <jira-events(a)lists.jboss.org
>
<mailto:%22Darran%20Lofthouse%20%28Created%29%20%28JIRA%29%22%20%3cjira-events@lists.jboss.org%3e>>
> *Komu* : ozizka(a)redhat.com <mailto:ozizka@redhat.com>
> *Předmět* : [JBoss JIRA] (AS7-2796) -DskipTests argument no longer
> preventing the execution of tests on AS7 build
> *Datum* : Fri, 25 Nov 2011 10:15:40 -0500 (EST)
>
> -DskipTests argument no longer preventing the execution of tests on AS7 build
> -----------------------------------------------------------------------------
>
> Key: AS7-2796
>
URL:https://issues.jboss.org/browse/AS7-2796
> Project: Application Server 7
> Issue Type: Bug
> Components: Test Suite
> Reporter: Darran Lofthouse
> Assignee: Ondrej Zizka
> Fix For: 7.1.0.CR1
>
>
> Since the testsuite changes have been committed the -DskipTests argument no longer
skips the tests.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
administrators:https://issues.jboss.org/secure/ContactAdministrators!defa...
<
https://issues.jboss.org/secure/ContactAdministrators%21default.jspa>
> For more information on JIRA,
see:http://www.atlassian.com/software/jira
>
>
_______________________________________________
jboss-as7-dev mailing list
jboss-as7-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev