Comments inline...
On 13/12/2010 10:42, Thomas Diesler wrote:
Hi David,
I applied your changes
Thanks!
http://jbmuc.dyndns.org:8280/hudson/job/JBoss-7.0.0/27/changes
There are a number of open questions about this however
#1 TCCL issue in SW
You seemed to have found a workaround that sets the TCCL explicitly to
some SW impl class. I believe SW should not work like this. Instead
there may be some initialization routine that SW must go through.
Followed by ordinary SW usage where the client should not have to have a
dependency on SW impl detail. OSGi bundles now seem to require an import
on the SW impl package, which is against what we preach for modularity
and separation of API/Impl. An ARQ test bundle may need to have a
dependency on the SW API, but not never on the impl. Maybe this is work
in progress, I just liked to mention it.
+1
Some ideas on how to do this have been floated in earlier postings in
this thread.
#2 Binding to the OSGi protocol
Currently, the archive provider functionality is still bound to the OSGi
protocol. Other AS tests cannot use multiple test archives. Is it
planned to make this functionality generally available?
In the call that we had a few weeks back I think Aslak agreed to look at
how we do the callback in OSGi and see if he could make that available
more generally in ARQ.
#3 Assembling the archive in the test case
Aslak and Kabir suggested that the test archive should be assembled on
the client side and that the client side container should deploy the
archive (instead of the test case it self). Is this going to change?
cheers
-thomas
Cheers,
David