[jboss-jira] [JBoss JIRA] (JGRP-1733) UNICAST / NAKACK: OOB messages should be marked as OOB_DELIVERED before adding them to the table
[
https://issues.jboss.org/browse/JGRP-1733?page=com.atlassian.jira.plugin....
]
Bela Ban commented on JGRP-1733:
--------------------------------
Can't do this for batches: if we successfully add a batch, this only means that at
least 1 message was added. Therefore, we still have to check for each message whether it
has the OOB_DELIVERED flag set and cannot set it in all messages of a batch up front.
So we can do this for single messages, but not for message batches.
UNICAST / NAKACK: OOB messages should be marked as OOB_DELIVERED
before adding them to the table
------------------------------------------------------------------------------------------------
Key: JGRP-1733
URL: https://issues.jboss.org/browse/JGRP-1733
Project: JGroups
Issue Type: Enhancement
Reporter: Bela Ban
Assignee: Bela Ban
Fix For: 3.5
Currently, OOB messages are added to the table, then passed up unless they're already
marked as OOB_DELIVERED. This could happen if another thread removed messages from the
table and passed them up before the current thread could pass the message up.
However, this work stealing might be detrimental: if the stealing thread batched messages
up and 'stole' OOB messages (and those messages blocked), then the rest of the
batch would be blocked from delivery.
This is the same though if a batch only contains regular messages...
However, this would make things simpler as threads from the regular pool would never
deliver OOB messages (but not the other way round, OOB thread could still deliver regular
messages).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira