[jboss-jira] [JBoss JIRA] Commented: (JBAS-8734) API change in deployment scanner's add cause failed deployments
[
https://issues.jboss.org/browse/JBAS-8734?page=com.atlassian.jira.plugin....
]
Snjezana Peco commented on JBAS-8734:
-------------------------------------
There are a few places in the AS6 code where VFS.getChild(URL url) is called with an
invalid URL.
Ales's fix (using jboss-vfs.jar attached to JBAS-8677) fixes the weld-int bug.
The bug in TomcatDeployment.java can be fixed using the following patch:
- docBase = VFS.getChild(warUrl.getPhysicalFile().getAbsolutePath();
+ docBase = VFS.getChild(warUrl.getPath()).getPhysicalFile().getAbsolutePath();
but still there is a bug in jboss-deployers-vfs (UrlIntegrationDeployer.deploy()).
In my opinion, the easiest way to fix these issues would be to fix VFS.getChild(URL url).
Attached is a patch against jboss-vfs 3.0.0CR5 and jboss-vfs.jar (source and binary).
The patch fixes all the mentioned issues.
In order to test it, you can install JBoss AS 6.0 CR1 to a directory containing the space
character, copy the attached jboss-vfs.jar to $JBOSS_HOME/lib and start the server.
After that, JBIDE-7822 could be tested using the JBoss Tools nightly build or SVN trunk.
API change in deployment scanner's add cause failed deployments
---------------------------------------------------------------
Key: JBAS-8734
URL: https://issues.jboss.org/browse/JBAS-8734
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Deployers
Affects Versions: 6.0.0.CR1
Reporter: Rob Stryker
Assignee: Remy Maucherat
Priority: Critical
Attachments: JBAS_8734.trace
When using the deployment scanner mbean to pass in a new URL that the JBossAS should scan
for deployments, a path format which worked fine in JBoss 5 and below no longer works.
Specifically, passing in a URL such as the one below:
file:/home/rob/apps/eclipse/workspaces/main_code/runtime%20space%20workspace/.metadata/.plugins/org.jboss.ide.eclipse.as.core/JBoss_6.0_Runtime_Server1292215199516/deploy/Dyn888.war/
When passing this string into the addURL mbean, the following error in the jboss console
results:
14:52:54,927 INFO [org.jboss.web.tomcat.service.deployers.TomcatDeployment] deploy,
ctxPath=/Dyn888
14:52:54,930 ERROR [org.jboss.kernel.plugins.dependency.AbstractKernelController] Error
installing to Start: name=jboss.web.deployment:war=/Dyn888 state=Create mode=Manual
requiredState=Installed: java.net.URISyntaxException: Illegal character in path at index
56: file:/home/rob/apps/eclipse/workspaces/main_code/runtime space
workspace/.metadata/.plugins/org.jboss.ide.eclipse.as.core/JBoss_6.0_Runtime_Server1292215199516/deploy/Dyn888.war/
at java.net.URI$Parser.fail(URI.java:2809) [:1.6.0_14]
at java.net.URI$Parser.checkChars(URI.java:2982) [:1.6.0_14]
Despite that I pass in a string with clear %20 blocking out the spaces, the deployment
scanner does not seem to recognize this and errors. This format of a string has no problem
working in AS 5.1 however.
This is blocking JBossTools server integration.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira