[jboss-jira] [JBoss JIRA] (AS7-3615) CLI: xa-data-source add command does not allow to specify xa-datasource-properties
[
https://issues.jboss.org/browse/AS7-3615?page=com.atlassian.jira.plugin.s...
]
Alexey Loubyansky reassigned AS7-3615:
--------------------------------------
Assignee: Stefano Maestri (was: Alexey Loubyansky)
The issue is not about changing the structure of the managed resource. It's about the
contract of the add method. I don't think the console team asked to remove xa props
from the arguments of the add op specifically, or if they did, I'd like to hear the
reason.
IMO, the contract of the add method is not, literally, to initialize all the attributes
but to create a resource. A resource that can be used, I'd say.
Suppose, we leave as it is now. Then, to create an xa ds we need two operations, at least.
On its own, the add becomes useless. So, users will be coming up with façades which will
translate into composite ops. Which is an unnecessary complication, imo. There is no
reason why the add shouldn't do it itself. It would only make it simpler and
friendlier to the users.
Please, let me know if there is a conflict with the console team or of some other kind.
Thanks.
CLI: xa-data-source add command does not allow to specify
xa-datasource-properties
----------------------------------------------------------------------------------
Key: AS7-3615
URL: https://issues.jboss.org/browse/AS7-3615
Project: Application Server 7
Issue Type: Bug
Components: CLI, Domain Management, JCA
Affects Versions: 7.1.0.Final
Reporter: Dominik Pospisil
Assignee: Stefano Maestri
It seems that CLI xa-data-source add command does not allow to specify
xa-datasource-properties. As having non empty xa-tadasource-properties map is mandatory,
enabling such datasource fails:
[standalone@localhost:9999 xa-datasource-properties] xa-data-source add --name=TestXADS
--jndi-name=java:jboss/datasources/TestXADS --driver-name=h2
[standalone@localhost:9999 xa-datasource-properties] xa-data-source enable
--name=TestXADS
JBAS014750: Operation handler failed to complete
Server exception:
15:54:56,948 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-7) MSC00001: Failed
to start service jboss.data-source.java:jboss/datasources/TestXADS:
org.jboss.msc.service.StartException in service
jboss.data-source.java:jboss/datasources/TestXADS: JBAS010433: Error during the deployment
of TestXADS
at
org.jboss.as.connector.subsystems.datasources.AbstractDataSourceService.start(AbstractDataSourceService.java:118)
at
org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1811)
[jboss-msc-1.0.2.GA.jar:1.0.2.GA]
at
org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1746)
[jboss-msc-1.0.2.GA.jar:1.0.2.GA]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
[:1.7.0_b147-icedtea]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
[:1.7.0_b147-icedtea]
at java.lang.Thread.run(Thread.java:722) [:1.7.0_b147-icedtea]
Caused by: org.jboss.jca.common.api.validator.ValidateException: IJ010069: Missing
required element xa-datasource-property in
org.jboss.jca.common.metadata.ds.XADataSourceImpl
at
org.jboss.jca.common.metadata.ds.XADataSourceImpl.validate(XADataSourceImpl.java:384)
at
org.jboss.jca.common.metadata.ds.XADataSourceImpl.<init>(XADataSourceImpl.java:115)
at
org.jboss.as.connector.subsystems.datasources.ModifiableXaDataSource.getUnModifiableInstance(ModifiableXaDataSource.java:372)
at
org.jboss.as.connector.subsystems.datasources.XaDataSourceService.getDeployer(XaDataSourceService.java:66)
at
org.jboss.as.connector.subsystems.datasources.AbstractDataSourceService.start(AbstractDataSourceService.java:111)
... 5 more
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira