[
https://issues.jboss.org/browse/JGRP-1737?page=com.atlassian.jira.plugin....
]
Bela Ban edited comment on JGRP-1737 at 11/12/13 10:20 AM:
-----------------------------------------------------------
Used UPerf to benchmark this on cluster01-04 (4 nodes, fast.xml with ip_tl=1):
|| Bundling enabled (master) || Bundling enabled (JGRP-1737) || Bundling disabled (master)
|| Bundling disabled (JGRP-1737) ||
| 27'127 | 28'105 | 22'863 | *26'106* |
The numbers for bundling are about the same (fluctuations do occur as others are using
this cluster, too). However, the number for bundling disabled ({{+DONT_BUNDLE}}) goes up
from 22'836 to 26'106. This is the case because now even messages with the
{{DONT_BUNDLE}} flag set are bundled.
was (Author: belaban):
Used UPerf to benchmark this on cluster01-04 (4 nodes, fast.xml with ip_tl=1):
|| Bundling enabled (master) || Bundling enabled (JGRP-1737) || Bundling disabled (master)
|| Bundling disabled (JGRP-1737) ||
| 27'127 | 28'105 | 22'863 | 26'106 |
The numbers for bundling are about the same (fluctuations do occur as others are using
this cluster, too). However, the number for bundling disabled ({{+DONT_BUNDLE}}) go up
from 22'836 to 26'106. This is the case because now even messages with the
{{DONT_BUNDLE}} flag set are bundled.
TP: ignore DONT_BUNDLE flag for sending of messages
---------------------------------------------------
Key: JGRP-1737
URL:
https://issues.jboss.org/browse/JGRP-1737
Project: JGroups
Issue Type: Enhancement
Reporter: Bela Ban
Assignee: Bela Ban
Fix For: 3.5
Currently, messages tagged with DONT_BUNDLE are sent separately, not as a message bundle
through a bundler. On the receiver, they are passed up as single messages, ie. on a
separate thread.
Sending a lot of single (possibly small) messages is inefficient; it would be better to
bundle *all* message on the sender side. This requires a bundler which sends single
messages immediately when no other messages are available to be sent.
SOLUTION (sender):
* If the bundler is *not* "old", ignore the DONT_BUNDLE flag and send the
message through the bundler
* Else, same as now; send the message immediately as single message
SOLUTION (receiver):
* When reading the message list and creating the 4 batches (regular, oob, oob+internal,
internal), if a message has DONT_BUNDLE set, pass it as single message to the
corresponding thread pool and don't add it to the batch
This has the advantage that we have a more efficient way of sending messages (as message
bundles), yet the behavior (and performance) at the receiver is the same as now
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira