[JBoss JIRA] Created: (JBAS-5176) Remove the first classloader hack from the ProfileServiceBootstrap
1 p.m.
Remove the first classloader hack from the ProfileServiceBootstrap
------------------------------------------------------------------
Key: JBAS-5176
URL: http://jira.jboss.com/jira/browse/JBAS-5176
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public (Everyone can see)
Components: ProfileService
Reporter: Adrian Brock
Fix For: JBossAS-5.0.0.CR1
When JBMICROCONT-230 is in trunk we can remove the hack from the profile service
bootstrap
that sets the context classloader to the first bootstrap classloader.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:48 a.m.
New subject: [JBoss JIRA] Updated: (JBAS-5176) Remove the first classloader hack from the ProfileServiceBootstrap
[ http://jira.jboss.com/jira/browse/JBAS-5176?page=all ]
Dimitris Andreadis updated JBAS-5176:
-------------------------------------
Fix Version/s: JBossAS-5.0.0.CR2
(was: JBossAS-5.0.0.CR1)
Pushing non-critical issues to the next CR2. If you think they are critical for CR1,
please re-schedule them.
Remove the first classloader hack from the ProfileServiceBootstrap
------------------------------------------------------------------
Key: JBAS-5176
URL: http://jira.jboss.com/jira/browse/JBAS-5176
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: ProfileService
Reporter: Adrian Brock
Fix For: JBossAS-5.0.0.CR2
When JBMICROCONT-230 is in trunk we can remove the hack from the profile service
bootstrap
that sets the context classloader to the first bootstrap classloader.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:48 p.m.
New subject: [JBoss JIRA] Updated: (JBAS-5176) Remove the first classloader hack from the ProfileServiceBootstrap
[
https://jira.jboss.org/jira/browse/JBAS-5176?page=com.atlassian.jira.plug...
]
Dimitris Andreadis updated JBAS-5176:
-------------------------------------
Comment: was deleted
Remove the first classloader hack from the ProfileServiceBootstrap
------------------------------------------------------------------
Key: JBAS-5176
URL: https://jira.jboss.org/jira/browse/JBAS-5176
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: ProfileService
Reporter: Adrian Brock
Fix For: JBossAS-5.0.0.CR2
When JBMICROCONT-230 is in trunk we can remove the hack from the profile service
bootstrap
that sets the context classloader to the first bootstrap classloader.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:50 p.m.
New subject: [JBoss JIRA] Assigned: (JBAS-5176) Remove the first classloader hack from the ProfileServiceBootstrap
[
https://jira.jboss.org/jira/browse/JBAS-5176?page=com.atlassian.jira.plug...
]
Dimitris Andreadis reassigned JBAS-5176:
----------------------------------------
Assignee: Adrian Brock
Adrian, since you know exactly what's needed can you look at it now?
Remove the first classloader hack from the ProfileServiceBootstrap
------------------------------------------------------------------
Key: JBAS-5176
URL: https://jira.jboss.org/jira/browse/JBAS-5176
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: ProfileService
Reporter: Adrian Brock
Assignee: Adrian Brock
Fix For: JBossAS-5.0.0.CR2
When JBMICROCONT-230 is in trunk we can remove the hack from the profile service
bootstrap
that sets the context classloader to the first bootstrap classloader.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:01 a.m.
New subject: [JBoss JIRA] Commented: (JBAS-5176) Remove the first classloader hack from the ProfileServiceBootstrap
[
https://jira.jboss.org/jira/browse/JBAS-5176?page=com.atlassian.jira.plug...
]
Adrian Brock commented on JBAS-5176:
------------------------------------
This issue is out-of-date. It has already been fixed.
But there is a related issue on which classloader to use as the context classloader
when running the "bootstraps".
Currently we have two bootstraps, the core MC and a seperate JMX one.
For JBoss5 it is not really an issue since all the bootstrap configurations are
configured
with classloaders that importAll=true in the DefaultDomain, so it doesn't really
matter
what classloader gets used.
The issue is that it uses bootstrap.getClass().getClassLoader() which may not always be
correct
(i.e. when the "bootstrap" is instantiated by a different "deployment"
to where the class is located).
See AbstractServerImpl (the same issue occurs for stopping bootstraps)
// TODO Fix the TCL hack used here!
ClassLoader cl = Thread.currentThread().getContextClassLoader();
try
{
// Run the bootstraps
for (Bootstrap bootstrap : bootstraps)
{
Thread.currentThread().setContextClassLoader(bootstrap.getClass().getClassLoader());
startedBootstraps.add(0, bootstrap);
bootstrap.start(this);
}
}
finally
{
Thread.currentThread().setContextClassLoader(cl);
}
The correct fix would probably be to remember the context classloader that is
being used at "addBootstrap"?
Remove the first classloader hack from the ProfileServiceBootstrap
------------------------------------------------------------------
Key: JBAS-5176
URL: https://jira.jboss.org/jira/browse/JBAS-5176
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: ProfileService
Reporter: Adrian Brock
Assignee: Adrian Brock
Fix For: JBossAS-5.0.0.CR2
When JBMICROCONT-230 is in trunk we can remove the hack from the profile service
bootstrap
that sets the context classloader to the first bootstrap classloader.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:06 a.m.
New subject: [JBoss JIRA] Updated: (JBAS-5176) The bootstrap classloader assumption may no be correct
[
https://jira.jboss.org/jira/browse/JBAS-5176?page=com.atlassian.jira.plug...
]
Adrian Brock updated JBAS-5176:
-------------------------------
Summary: The bootstrap classloader assumption may no be correct (was: Remove
the first classloader hack from the ProfileServiceBootstrap)
Fix Version/s: (was: JBossAS-5.0.0.CR2)
Assignee: (was: Adrian Brock)
This issue doesn't need to fixed for 5.0 final
The hard part of this work is writing a test that uses complicated
(export/import) classloading rules in the bootstrap configuration of the AS server.
The bootstrap classloader assumption may no be correct
------------------------------------------------------
Key: JBAS-5176
URL: https://jira.jboss.org/jira/browse/JBAS-5176
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: ProfileService
Reporter: Adrian Brock
When JBMICROCONT-230 is in trunk we can remove the hack from the profile service
bootstrap
that sets the context classloader to the first bootstrap classloader.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5980
days inactive
6196
days old
5 comments
2 participants
participants (2)
-
Adrian Brock (JIRA) -
Dimitris Andreadis (JIRA)