12:36 p.m.
Mathieu Lachance created AS7-5448:
-------------------------------------
Summary: expose thread pool queue size through jmx
Key: AS7-5448
URL: https://issues.jboss.org/browse/AS7-5448
Project: Application Server 7
Issue Type: Feature Request
Components: JMX
Affects Versions: 7.1.2.Final (EAP)
Reporter: Mathieu Lachance
Assignee: Stuart Douglas
issue https://issues.jboss.org/browse/AS7-793 is not completed.
thread pool exposed in jmx is still missing the queue size which is an essential metric to
evaluate the system load.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:45 p.m.
[
https://issues.jboss.org/browse/AS7-5448?page=com.atlassian.jira.plugin.s...
]
Brian Stansberry commented on AS7-5448:
---------------------------------------
Please be specific about what mbean is not exposing the information you want.
Threading stuff appears in various ways in JMX, so I want to be sure we understand what
you mean.
expose thread pool queue size through jmx
-----------------------------------------
Key: AS7-5448
URL: https://issues.jboss.org/browse/AS7-5448
Project: Application Server 7
Issue Type: Feature Request
Components: JMX
Affects Versions: 7.1.2.Final (EAP)
Reporter: Mathieu Lachance
Assignee: Stuart Douglas
issue https://issues.jboss.org/browse/AS7-793 is not completed.
thread pool exposed in jmx is still missing the queue size which is an essential metric
to evaluate the system load.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:57 p.m.
[
https://issues.jboss.org/browse/AS7-5448?page=com.atlassian.jira.plugin.s...
]
Mathieu Lachance commented on AS7-5448:
---------------------------------------
in java.util.concurrent.ThreadPoolExecutor there's a getter on the workQueue which
return a java.util.concurrent.BlockingQueue.
According to javadoc :
/**
* Returns the task queue used by this executor. Access to the
* task queue is intended primarily for debugging and monitoring.
* This queue may be in active use. Retrieving the task queue
* does not prevent queued tasks from executing.
*
* @return the task queue
*/
I'd like the BlockingQueue::size() be exposed through jmx. that way, it will be
possible to know if there's queued element waiting to be run.
expose thread pool queue size through jmx
-----------------------------------------
Key: AS7-5448
URL: https://issues.jboss.org/browse/AS7-5448
Project: Application Server 7
Issue Type: Feature Request
Components: JMX
Affects Versions: 7.1.2.Final (EAP)
Reporter: Mathieu Lachance
Assignee: Stuart Douglas
issue https://issues.jboss.org/browse/AS7-793 is not completed.
thread pool exposed in jmx is still missing the queue size which is an essential metric
to evaluate the system load.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:22 p.m.
[
https://issues.jboss.org/browse/AS7-5448?page=com.atlassian.jira.plugin.s...
]
Brian Stansberry commented on AS7-5448:
---------------------------------------
You filed AS7-5449, so my assumption is you're talking about the mbeans exposed by the
"threads" subsystem, i.e. <subsystem
xmlns="urn:jboss:domain:threads:1.1">.
That's what I was trying to clarify.
expose thread pool queue size through jmx
-----------------------------------------
Key: AS7-5448
URL: https://issues.jboss.org/browse/AS7-5448
Project: Application Server 7
Issue Type: Feature Request
Components: JMX
Affects Versions: 7.1.2.Final (EAP)
Reporter: Mathieu Lachance
Assignee: Stuart Douglas
issue https://issues.jboss.org/browse/AS7-793 is not completed.
thread pool exposed in jmx is still missing the queue size which is an essential metric
to evaluate the system load.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:30 p.m.
[
https://issues.jboss.org/browse/AS7-5448?page=com.atlassian.jira.plugin.s...
]
Brian Stansberry updated AS7-5448:
----------------------------------
Component/s: Domain Management
(was: JMX)
This isn't really a JMX issue; the requested data isn't available through the core
management API. Exposing it there will also make it available through JMX.
Resolving this will require a change in the jboss-threads project, as the underlying
ExecutorService implementations are coming from there, and they don't expose the queue
size. The implementation isn't java.util.concurrent.ThreadPoolExecutor.)
expose thread pool queue size through jmx
-----------------------------------------
Key: AS7-5448
URL: https://issues.jboss.org/browse/AS7-5448
Project: Application Server 7
Issue Type: Feature Request
Components: Domain Management
Affects Versions: 7.1.2.Final (EAP)
Reporter: Mathieu Lachance
Assignee: Stuart Douglas
issue https://issues.jboss.org/browse/AS7-793 is not completed.
thread pool exposed in jmx is still missing the queue size which is an essential metric
to evaluate the system load.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:01 p.m.
[
https://issues.jboss.org/browse/AS7-5448?page=com.atlassian.jira.plugin.s...
]
Mathieu Lachance commented on AS7-5448:
---------------------------------------
Sorry for the misunderstanding, yes I was referring to the threads subsystem.
as defined in the jboss-threads-2.0.0.GA.jar packaged in the jboss 7.1.2.Final
distribution
org.jboss.threads.JBossThreadPoolExecutor implements
org.jboss.threads.management.ThreadExecutorMBean, I think the getQueueSize() method should
be added here.
org.jboss.threads.JBossThreadPoolExecutor extends java.util.concurrent.ThreadPoolExecutor,
so the BlockingQueue I was talking about is available, making the getQueueSize() method a
snap to implements.
should the issue be filled instead in the jboss-threads jira ?
expose thread pool queue size through jmx
-----------------------------------------
Key: AS7-5448
URL: https://issues.jboss.org/browse/AS7-5448
Project: Application Server 7
Issue Type: Feature Request
Components: Domain Management
Affects Versions: 7.1.2.Final (EAP)
Reporter: Mathieu Lachance
Assignee: Stuart Douglas
issue https://issues.jboss.org/browse/AS7-793 is not completed.
thread pool exposed in jmx is still missing the queue size which is an essential metric
to evaluate the system load.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:05 p.m.
[
https://issues.jboss.org/browse/AS7-5448?page=com.atlassian.jira.plugin.s...
]
Brian Stansberry commented on AS7-5448:
---------------------------------------
Not instead, but an additional JIRA that this one depends on would be good. Exposing the
property in jboss-threads would just make it possible for the AS to expose it, but there
would need to be an AS change to actually do that. So keeping this JIRA is good.
I'll just clone this JIRA and move the clone into the JBTHR project.
expose thread pool queue size through jmx
-----------------------------------------
Key: AS7-5448
URL: https://issues.jboss.org/browse/AS7-5448
Project: Application Server 7
Issue Type: Feature Request
Components: Domain Management
Affects Versions: 7.1.2.Final (EAP)
Reporter: Mathieu Lachance
Assignee: Stuart Douglas
issue https://issues.jboss.org/browse/AS7-793 is not completed.
thread pool exposed in jmx is still missing the queue size which is an essential metric
to evaluate the system load.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:09 p.m.
[
https://issues.jboss.org/browse/AS7-5448?page=com.atlassian.jira.plugin.s...
]
Brian Stansberry commented on AS7-5448:
---------------------------------------
Done; see JBTHR-22.
expose thread pool queue size through jmx
-----------------------------------------
Key: AS7-5448
URL: https://issues.jboss.org/browse/AS7-5448
Project: Application Server 7
Issue Type: Feature Request
Components: Domain Management
Affects Versions: 7.1.2.Final (EAP)
Reporter: Mathieu Lachance
Assignee: Stuart Douglas
issue https://issues.jboss.org/browse/AS7-793 is not completed.
thread pool exposed in jmx is still missing the queue size which is an essential metric
to evaluate the system load.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:30 p.m.
[
https://issues.jboss.org/browse/AS7-5448?page=com.atlassian.jira.plugin.s...
]
Mathieu Lachance commented on AS7-5448:
---------------------------------------
big thanks !
expose thread pool queue size through jmx
-----------------------------------------
Key: AS7-5448
URL: https://issues.jboss.org/browse/AS7-5448
Project: Application Server 7
Issue Type: Feature Request
Components: Domain Management
Affects Versions: 7.1.2.Final (EAP)
Reporter: Mathieu Lachance
Assignee: Stuart Douglas
issue https://issues.jboss.org/browse/AS7-793 is not completed.
thread pool exposed in jmx is still missing the queue size which is an essential metric
to evaluate the system load.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:36 p.m.
[
https://issues.jboss.org/browse/AS7-5448?page=com.atlassian.jira.plugin.s...
]
Mathieu Lachance commented on AS7-5448:
---------------------------------------
I have done locally all modifications for AS7-5448 and JBTHR-22 though I'm getting the
following error inside Java Visual VM:
"java.util.MissingResourceException: Cant't find resource for bundle
java.util.PropertyResourceBundle, key threadpool.common.queue-size" which is
effectively the new attribute that I've added.
I guess this is related to a certain .properties file packaged within jboss that I still
need to modify.
Can someone help me with this one, then I'll be able to send all the code ?
Thanks !
expose thread pool queue size through jmx
-----------------------------------------
Key: AS7-5448
URL: https://issues.jboss.org/browse/AS7-5448
Project: Application Server 7
Issue Type: Feature Request
Components: Domain Management
Affects Versions: 7.1.2.Final (EAP)
Reporter: Mathieu Lachance
Assignee: Stuart Douglas
issue https://issues.jboss.org/browse/AS7-793 is not completed.
thread pool exposed in jmx is still missing the queue size which is an essential metric
to evaluate the system load.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:42 p.m.
[
https://issues.jboss.org/browse/AS7-5448?page=com.atlassian.jira.plugin.s...
]
Brian Stansberry commented on AS7-5448:
---------------------------------------
Great!
The file you need to modify is
https://github.com/jbossas/jboss-as/blob/master/threads/src/main/resource...
expose thread pool queue size through jmx
-----------------------------------------
Key: AS7-5448
URL: https://issues.jboss.org/browse/AS7-5448
Project: Application Server 7
Issue Type: Feature Request
Components: Domain Management
Affects Versions: 7.1.2.Final (EAP)
Reporter: Mathieu Lachance
Assignee: Stuart Douglas
issue https://issues.jboss.org/browse/AS7-793 is not completed.
thread pool exposed in jmx is still missing the queue size which is an essential metric
to evaluate the system load.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:50 p.m.
[
https://issues.jboss.org/browse/AS7-5448?page=com.atlassian.jira.plugin.s...
]
Mathieu Lachance commented on AS7-5448:
---------------------------------------
Yep exactly the file I was looking for !
Everything's seems to work fine, I'll push the code when I'll be back from the
long weekend on Tuesday.
expose thread pool queue size through jmx
-----------------------------------------
Key: AS7-5448
URL: https://issues.jboss.org/browse/AS7-5448
Project: Application Server 7
Issue Type: Feature Request
Components: Domain Management
Affects Versions: 7.1.2.Final (EAP)
Reporter: Mathieu Lachance
Assignee: Stuart Douglas
issue https://issues.jboss.org/browse/AS7-793 is not completed.
thread pool exposed in jmx is still missing the queue size which is an essential metric
to evaluate the system load.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:27 a.m.
[
https://issues.jboss.org/browse/AS7-5448?page=com.atlassian.jira.plugin.s...
]
Mathieu Lachance updated AS7-5448:
----------------------------------
Attachment: AS7-5548_JBTHR-22.zip
expose thread pool queue size through jmx
-----------------------------------------
Key: AS7-5448
URL: https://issues.jboss.org/browse/AS7-5448
Project: Application Server 7
Issue Type: Feature Request
Components: Domain Management
Affects Versions: 7.1.2.Final (EAP)
Reporter: Mathieu Lachance
Assignee: Stuart Douglas
Attachments: AS7-5548_JBTHR-22.zip
issue https://issues.jboss.org/browse/AS7-793 is not completed.
thread pool exposed in jmx is still missing the queue size which is an essential metric
to evaluate the system load.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:29 a.m.
[
https://issues.jboss.org/browse/AS7-5448?page=com.atlassian.jira.plugin.s...
]
Mathieu Lachance updated AS7-5448:
----------------------------------
Attachment: LocalDescriptions.properties
expose thread pool queue size through jmx
-----------------------------------------
Key: AS7-5448
URL: https://issues.jboss.org/browse/AS7-5448
Project: Application Server 7
Issue Type: Feature Request
Components: Domain Management
Affects Versions: 7.1.2.Final (EAP)
Reporter: Mathieu Lachance
Assignee: Stuart Douglas
Attachments: AS7-5548_JBTHR-22.zip, LocalDescriptions.properties
issue https://issues.jboss.org/browse/AS7-793 is not completed.
thread pool exposed in jmx is still missing the queue size which is an essential metric
to evaluate the system load.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:33 a.m.
[
https://issues.jboss.org/browse/AS7-5448?page=com.atlassian.jira.plugin.s...
]
Mathieu Lachance commented on AS7-5448:
---------------------------------------
There you go I've attached all the necessary code.
Thanks !
expose thread pool queue size through jmx
-----------------------------------------
Key: AS7-5448
URL: https://issues.jboss.org/browse/AS7-5448
Project: Application Server 7
Issue Type: Feature Request
Components: Domain Management
Affects Versions: 7.1.2.Final (EAP)
Reporter: Mathieu Lachance
Assignee: Stuart Douglas
Attachments: AS7-5548_JBTHR-22.zip, LocalDescriptions.properties
issue https://issues.jboss.org/browse/AS7-793 is not completed.
thread pool exposed in jmx is still missing the queue size which is an essential metric
to evaluate the system load.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:57 a.m.
[
https://issues.jboss.org/browse/AS7-5448?page=com.atlassian.jira.plugin.s...
]
Mathieu Lachance commented on AS7-5448:
---------------------------------------
https://github.com/jbossas/jboss-as/pull/3010
expose thread pool queue size through jmx
-----------------------------------------
Key: AS7-5448
URL: https://issues.jboss.org/browse/AS7-5448
Project: Application Server 7
Issue Type: Feature Request
Components: Domain Management
Affects Versions: 7.1.2.Final (EAP)
Reporter: Mathieu Lachance
Assignee: Stuart Douglas
Attachments: AS7-5548_JBTHR-22.zip, LocalDescriptions.properties
issue https://issues.jboss.org/browse/AS7-793 is not completed.
thread pool exposed in jmx is still missing the queue size which is an essential metric
to evaluate the system load.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:52 a.m.
[
https://issues.jboss.org/browse/AS7-5448?page=com.atlassian.jira.plugin.s...
]
Brian Stansberry updated AS7-5448:
----------------------------------
Fix Version/s: 7.2.0.Alpha1
expose thread pool queue size through jmx
-----------------------------------------
Key: AS7-5448
URL: https://issues.jboss.org/browse/AS7-5448
Project: Application Server 7
Issue Type: Feature Request
Components: Domain Management
Affects Versions: 7.1.2.Final (EAP)
Reporter: Mathieu Lachance
Assignee: Stuart Douglas
Fix For: 7.2.0.Alpha1
Attachments: AS7-5548_JBTHR-22.zip, LocalDescriptions.properties
issue https://issues.jboss.org/browse/AS7-793 is not completed.
thread pool exposed in jmx is still missing the queue size which is an essential metric
to evaluate the system load.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:27 p.m.
[
https://issues.jboss.org/browse/AS7-5448?page=com.atlassian.jira.plugin.s...
]
Stuart Douglas reassigned AS7-5448:
-----------------------------------
Assignee: (was: Stuart Douglas)
expose thread pool queue size through jmx
-----------------------------------------
Key: AS7-5448
URL: https://issues.jboss.org/browse/AS7-5448
Project: Application Server 7
Issue Type: Feature Request
Components: Domain Management
Affects Versions: 7.1.2.Final (EAP)
Reporter: Mathieu Lachance
Fix For: 7.2.0.Alpha1
Attachments: AS7-5548_JBTHR-22.zip, LocalDescriptions.properties
issue https://issues.jboss.org/browse/AS7-793 is not completed.
thread pool exposed in jmx is still missing the queue size which is an essential metric
to evaluate the system load.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:09 a.m.
[
https://issues.jboss.org/browse/AS7-5448?page=com.atlassian.jira.plugin.s...
]
Bartosz Baranowski reassigned AS7-5448:
---------------------------------------
Assignee: Bartosz Baranowski
expose thread pool queue size through jmx
-----------------------------------------
Key: AS7-5448
URL: https://issues.jboss.org/browse/AS7-5448
Project: Application Server 7
Issue Type: Feature Request
Components: Domain Management
Affects Versions: 7.1.2.Final (EAP)
Reporter: Mathieu Lachance
Assignee: Bartosz Baranowski
Fix For: 7.2.0.Alpha1
Attachments: AS7-5548_JBTHR-22.zip, LocalDescriptions.properties
issue https://issues.jboss.org/browse/AS7-793 is not completed.
thread pool exposed in jmx is still missing the queue size which is an essential metric
to evaluate the system load.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:24 a.m.
[
https://issues.jboss.org/browse/AS7-5448?page=com.atlassian.jira.plugin.s...
]
Bartosz Baranowski commented on AS7-5448:
-----------------------------------------
7.1 - https://github.com/jbossas/jboss-as/pull/3551
master - https://github.com/jbossas/jboss-as/pull/3552
expose thread pool queue size through jmx
-----------------------------------------
Key: AS7-5448
URL: https://issues.jboss.org/browse/AS7-5448
Project: Application Server 7
Issue Type: Feature Request
Components: Domain Management
Affects Versions: 7.1.2.Final (EAP)
Reporter: Mathieu Lachance
Assignee: Bartosz Baranowski
Fix For: 7.2.0.Alpha1
Attachments: AS7-5548_JBTHR-22.zip, LocalDescriptions.properties
issue https://issues.jboss.org/browse/AS7-793 is not completed.
thread pool exposed in jmx is still missing the queue size which is an essential metric
to evaluate the system load.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4428
days inactive
4521
days old
19 comments
4 participants
participants (4)
-
Bartosz Baranowski (JIRA) -
Brian Stansberry (JIRA)
-
Mathieu Lachance (JIRA)
-
Stuart Douglas (JIRA)