11:34 p.m.
JBossCustomDeployDUFilter has an overly broad excludes list
-----------------------------------------------------------
Key: JBAS-8076
URL: https://jira.jboss.org/browse/JBAS-8076
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public (Everyone can see)
Reporter: Brian Stansberry
Assignee: Ales Justin
Priority: Blocker
Fix For: 6.0.0.M4
The changes to the excludes list done as part of JBAS-8060 is overly broad.
FileNameVirtualFileFilter works by doing a "contains" check against the set of
keys, so the list of keys needs to be pretty exact. It currently include easily matched
terms like "cluster", "security" and "hornetq".
This is the cause of testsuite failures such as
http://hudson.qa.jboss.com/hudson/view/JBoss%20AS/job/JBoss-AS-6.0.x-test...
The tests deploy artifacts that include "cluster" in their names, and the
artifacts aren't being scanned for EJB3 annotations.
This may be the cause of other failures as well; e.g. quite a few seem to be related to
messaging or security.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:02 a.m.
New subject: [JBoss JIRA] Commented: (JBAS-8076) JBossCustomDeployDUFilter has an overly broad excludes list
[
https://jira.jboss.org/browse/JBAS-8076?page=com.atlassian.jira.plugin.sy...
]
jaikiran pai commented on JBAS-8076:
------------------------------------
Capturing the mail discussion from jboss-dev mailing list:
Thanks for looking into this Brian.
As for the issue, I think, as already pointed out by Remy, relying on
deployment file names in itself isn't a good way of filtering out
deployments. I know it's a good to have feature, but I believe it should
be more of a "user deployment" feature rather than for deployments that
are shipped by JBoss AS. From what I understand, the real fix is to add
a (empty?) jboss-scanning.xml to such deployments which shouldn't be
scanned. Or maybe there's a better way based on metadata (version)? I'll
create a separate JIRA for that, so that we can get rid of these name
based filtering (atleast for JBoss AS shipped deployments).
JBossCustomDeployDUFilter has an overly broad excludes list
-----------------------------------------------------------
Key: JBAS-8076
URL: https://jira.jboss.org/browse/JBAS-8076
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Reporter: Brian Stansberry
Assignee: Ales Justin
Priority: Blocker
Fix For: 6.0.0.M4
The changes to the excludes list done as part of JBAS-8060 is overly broad.
FileNameVirtualFileFilter works by doing a "contains" check against the set of
keys, so the list of keys needs to be pretty exact. It currently include easily matched
terms like "cluster", "security" and "hornetq".
This is the cause of testsuite failures such as
http://hudson.qa.jboss.com/hudson/view/JBoss%20AS/job/JBoss-AS-6.0.x-test...
The tests deploy artifacts that include "cluster" in their names, and the
artifacts aren't being scanned for EJB3 annotations.
This may be the cause of other failures as well; e.g. quite a few seem to be related to
messaging or security.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:49 a.m.
New subject: [JBoss JIRA] Commented: (JBAS-8076) JBossCustomDeployDUFilter has an overly broad excludes list
[
https://jira.jboss.org/browse/JBAS-8076?page=com.atlassian.jira.plugin.sy...
]
Remy Maucherat commented on JBAS-8076:
--------------------------------------
Removing the three "wildcard" entries ("cluster", "security"
and "hornetq") from scanning-deployers-jboss-beans.xml does not impact the
"all" profile startup time in any measurable way. So even if we do not
immediately replace them with jboss-scanning metadata, we should drop them now IMO.
JBossCustomDeployDUFilter has an overly broad excludes list
-----------------------------------------------------------
Key: JBAS-8076
URL: https://jira.jboss.org/browse/JBAS-8076
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Reporter: Brian Stansberry
Assignee: Ales Justin
Priority: Blocker
Fix For: 6.0.0.M4
The changes to the excludes list done as part of JBAS-8060 is overly broad.
FileNameVirtualFileFilter works by doing a "contains" check against the set of
keys, so the list of keys needs to be pretty exact. It currently include easily matched
terms like "cluster", "security" and "hornetq".
This is the cause of testsuite failures such as
http://hudson.qa.jboss.com/hudson/view/JBoss%20AS/job/JBoss-AS-6.0.x-test...
The tests deploy artifacts that include "cluster" in their names, and the
artifacts aren't being scanned for EJB3 annotations.
This may be the cause of other failures as well; e.g. quite a few seem to be related to
messaging or security.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:20 a.m.
New subject: [JBoss JIRA] Commented: (JBAS-8076) JBossCustomDeployDUFilter has an overly broad excludes list
[
https://jira.jboss.org/browse/JBAS-8076?page=com.atlassian.jira.plugin.sy...
]
Ales Justin commented on JBAS-8076:
-----------------------------------
I've already removed hornetq and security, while added more exact info to cluster.
JBossCustomDeployDUFilter has an overly broad excludes list
-----------------------------------------------------------
Key: JBAS-8076
URL: https://jira.jboss.org/browse/JBAS-8076
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Reporter: Brian Stansberry
Assignee: Ales Justin
Priority: Blocker
Fix For: 6.0.0.M4
The changes to the excludes list done as part of JBAS-8060 is overly broad.
FileNameVirtualFileFilter works by doing a "contains" check against the set of
keys, so the list of keys needs to be pretty exact. It currently include easily matched
terms like "cluster", "security" and "hornetq".
This is the cause of testsuite failures such as
http://hudson.qa.jboss.com/hudson/view/JBoss%20AS/job/JBoss-AS-6.0.x-test...
The tests deploy artifacts that include "cluster" in their names, and the
artifacts aren't being scanned for EJB3 annotations.
This may be the cause of other failures as well; e.g. quite a few seem to be related to
messaging or security.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:45 a.m.
New subject: [JBoss JIRA] Commented: (JBAS-8076) JBossCustomDeployDUFilter has an overly broad excludes list
[
https://jira.jboss.org/browse/JBAS-8076?page=com.atlassian.jira.plugin.sy...
]
Brian Stansberry commented on JBAS-8076:
----------------------------------------
Just to complete the record, the 2 sars under deploy/cluster had empty jboss-scanning.xml
files. There was one .aop jar that didn't that I'll fix. (It has no classes
though.) Other than that everything under cluster/ hornetq/ or security/ was an xml file,
so Remy's result that simply dropping the exclusions didn't impact startup is not
surprising.
JBossCustomDeployDUFilter has an overly broad excludes list
-----------------------------------------------------------
Key: JBAS-8076
URL: https://jira.jboss.org/browse/JBAS-8076
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Reporter: Brian Stansberry
Assignee: Ales Justin
Priority: Blocker
Fix For: 6.0.0.M4
The changes to the excludes list done as part of JBAS-8060 is overly broad.
FileNameVirtualFileFilter works by doing a "contains" check against the set of
keys, so the list of keys needs to be pretty exact. It currently include easily matched
terms like "cluster", "security" and "hornetq".
This is the cause of testsuite failures such as
http://hudson.qa.jboss.com/hudson/view/JBoss%20AS/job/JBoss-AS-6.0.x-test...
The tests deploy artifacts that include "cluster" in their names, and the
artifacts aren't being scanned for EJB3 annotations.
This may be the cause of other failures as well; e.g. quite a few seem to be related to
messaging or security.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:59 a.m.
New subject: [JBoss JIRA] Commented: (JBAS-8076) JBossCustomDeployDUFilter has an overly broad excludes list
[
https://jira.jboss.org/browse/JBAS-8076?page=com.atlassian.jira.plugin.sy...
]
Ales Justin commented on JBAS-8076:
-----------------------------------
Feel free to remove cluster entry once you fixed that .aop as well.
Just a slight note wrt xml files.
Even though they are just xml files, some can have explicit (big) classpath.
e.g. jboss-service.xml has classpath element -- see conf/jboss-service.xml.
But in our case, I think none has explicit classpath element entry.
JBossCustomDeployDUFilter has an overly broad excludes list
-----------------------------------------------------------
Key: JBAS-8076
URL: https://jira.jboss.org/browse/JBAS-8076
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Reporter: Brian Stansberry
Assignee: Ales Justin
Priority: Blocker
Fix For: 6.0.0.M4
The changes to the excludes list done as part of JBAS-8060 is overly broad.
FileNameVirtualFileFilter works by doing a "contains" check against the set of
keys, so the list of keys needs to be pretty exact. It currently include easily matched
terms like "cluster", "security" and "hornetq".
This is the cause of testsuite failures such as
http://hudson.qa.jboss.com/hudson/view/JBoss%20AS/job/JBoss-AS-6.0.x-test...
The tests deploy artifacts that include "cluster" in their names, and the
artifacts aren't being scanned for EJB3 annotations.
This may be the cause of other failures as well; e.g. quite a few seem to be related to
messaging or security.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:36 p.m.
New subject: [JBoss JIRA] Commented: (JBAS-8076) JBossCustomDeployDUFilter has an overly broad excludes list
[
https://jira.jboss.org/browse/JBAS-8076?page=com.atlassian.jira.plugin.sy...
]
Brian Stansberry commented on JBAS-8076:
----------------------------------------
I fixed jbossweb-cluster.aop and removed the cluster" entry as part of JBAS-8085.
JBossCustomDeployDUFilter has an overly broad excludes list
-----------------------------------------------------------
Key: JBAS-8076
URL: https://jira.jboss.org/browse/JBAS-8076
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Reporter: Brian Stansberry
Assignee: Ales Justin
Priority: Blocker
Fix For: 6.0.0.M4
The changes to the excludes list done as part of JBAS-8060 is overly broad.
FileNameVirtualFileFilter works by doing a "contains" check against the set of
keys, so the list of keys needs to be pretty exact. It currently include easily matched
terms like "cluster", "security" and "hornetq".
This is the cause of testsuite failures such as
http://hudson.qa.jboss.com/hudson/view/JBoss%20AS/job/JBoss-AS-6.0.x-test...
The tests deploy artifacts that include "cluster" in their names, and the
artifacts aren't being scanned for EJB3 annotations.
This may be the cause of other failures as well; e.g. quite a few seem to be related to
messaging or security.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:35 p.m.
New subject: [JBoss JIRA] Updated: (JBAS-8076) JBossCustomDeployDUFilter has an overly broad excludes list
[
https://jira.jboss.org/browse/JBAS-8076?page=com.atlassian.jira.plugin.sy...
]
Jason T. Greene updated JBAS-8076:
----------------------------------
Fix Version/s: TBD-6.x
(was: 6.0.0.M4)
All uncompleted issues are now moved to the new "To be determined for future 6.x
releases" category. Feel free to reassign this to a specific release, but only if you
have the time to do it
JBossCustomDeployDUFilter has an overly broad excludes list
-----------------------------------------------------------
Key: JBAS-8076
URL: https://jira.jboss.org/browse/JBAS-8076
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Reporter: Brian Stansberry
Assignee: Ales Justin
Priority: Blocker
Fix For: TBD-6.x
The changes to the excludes list done as part of JBAS-8060 is overly broad.
FileNameVirtualFileFilter works by doing a "contains" check against the set of
keys, so the list of keys needs to be pretty exact. It currently include easily matched
terms like "cluster", "security" and "hornetq".
This is the cause of testsuite failures such as
http://hudson.qa.jboss.com/hudson/view/JBoss%20AS/job/JBoss-AS-6.0.x-test...
The tests deploy artifacts that include "cluster" in their names, and the
artifacts aren't being scanned for EJB3 annotations.
This may be the cause of other failures as well; e.g. quite a few seem to be related to
messaging or security.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:46 a.m.
New subject: [JBoss JIRA] Resolved: (JBAS-8076) JBossCustomDeployDUFilter has an overly broad excludes list
[
https://jira.jboss.org/browse/JBAS-8076?page=com.atlassian.jira.plugin.sy...
]
Ales Justin resolved JBAS-8076.
-------------------------------
Fix Version/s: 6.0.0.M4
(was: TBD-6.x)
Resolution: Done
JBossCustomDeployDUFilter has an overly broad excludes list
-----------------------------------------------------------
Key: JBAS-8076
URL: https://jira.jboss.org/browse/JBAS-8076
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Reporter: Brian Stansberry
Assignee: Ales Justin
Priority: Blocker
Fix For: 6.0.0.M4
The changes to the excludes list done as part of JBAS-8060 is overly broad.
FileNameVirtualFileFilter works by doing a "contains" check against the set of
keys, so the list of keys needs to be pretty exact. It currently include easily matched
terms like "cluster", "security" and "hornetq".
This is the cause of testsuite failures such as
http://hudson.qa.jboss.com/hudson/view/JBoss%20AS/job/JBoss-AS-6.0.x-test...
The tests deploy artifacts that include "cluster" in their names, and the
artifacts aren't being scanned for EJB3 annotations.
This may be the cause of other failures as well; e.g. quite a few seem to be related to
messaging or security.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5281
days inactive
5330
days old
8 comments
5 participants
participants (5)
-
Ales Justin (JIRA) -
Brian Stansberry (JIRA)
-
jaikiran pai (JIRA)
-
Jason T. Greene (JIRA)
-
Remy Maucherat (JIRA)