10:43 a.m.
Some files have the license headers twice
-----------------------------------------
Key: JBRULES-2688
URL: https://jira.jboss.org/browse/JBRULES-2688
Project: Drools
Issue Type: Task
Security Level: Public (Everyone can see)
Components: All
Affects Versions: 5.1.0.FINAL
Reporter: Geoffrey De Smet
Assignee: Toni Rikkola
Priority: Trivial
Fix For: FUTURE
Several files have the license header twice, for example:
/home/ge0ffrey/projects/jboss/drools/drools-guvnor/src/main/java/org/drools/guvnor/server/repository/RulesRepositoryManager.java
The reason is that the original file already had a license header, but not on the correct
position (after the package statement instead of before it).
/**
* Copyright 2010 JBoss Inc
*
...
*/
package org.drools.guvnor.server.repository;
/*
* Copyright 2005 JBoss Inc
*
...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:24 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2688) Some files have the license headers twice
[
https://jira.jboss.org/browse/JBRULES-2688?page=com.atlassian.jira.plugin...
]
Geoffrey De Smet commented on JBRULES-2688:
-------------------------------------------
should be easy to fix with a regex replace in all files
;\s+/\*\n \* Copyright [^/]+\*/ *\n
Some files have the license headers twice
-----------------------------------------
Key: JBRULES-2688
URL: https://jira.jboss.org/browse/JBRULES-2688
Project: Drools
Issue Type: Task
Security Level: Public(Everyone can see)
Components: All
Affects Versions: 5.1.0.FINAL
Reporter: Geoffrey De Smet
Assignee: Toni Rikkola
Priority: Trivial
Fix For: FUTURE
Several files have the license header twice, for example:
/home/ge0ffrey/projects/jboss/drools/drools-guvnor/src/main/java/org/drools/guvnor/server/repository/RulesRepositoryManager.java
The reason is that the original file already had a license header, but not on the correct
position (after the package statement instead of before it).
/**
* Copyright 2010 JBoss Inc
*
...
*/
package org.drools.guvnor.server.repository;
/*
* Copyright 2005 JBoss Inc
*
...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
noon
New subject: [JBoss JIRA] Assigned: (JBRULES-2688) Some files have the license headers twice
[
https://jira.jboss.org/browse/JBRULES-2688?page=com.atlassian.jira.plugin...
]
Geoffrey De Smet reassigned JBRULES-2688:
-----------------------------------------
Assignee: Geoffrey De Smet (was: Toni Rikkola)
Some files have the license headers twice
-----------------------------------------
Key: JBRULES-2688
URL: https://jira.jboss.org/browse/JBRULES-2688
Project: Drools
Issue Type: Task
Security Level: Public(Everyone can see)
Components: All
Affects Versions: 5.1.0.FINAL
Reporter: Geoffrey De Smet
Assignee: Geoffrey De Smet
Priority: Trivial
Fix For: FUTURE
Several files have the license header twice, for example:
/home/ge0ffrey/projects/jboss/drools/drools-guvnor/src/main/java/org/drools/guvnor/server/repository/RulesRepositoryManager.java
The reason is that the original file already had a license header, but not on the correct
position (after the package statement instead of before it).
/**
* Copyright 2010 JBoss Inc
*
...
*/
package org.drools.guvnor.server.repository;
/*
* Copyright 2005 JBoss Inc
*
...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:12 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2688) Some files have the license headers twice
[
https://jira.jboss.org/browse/JBRULES-2688?page=com.atlassian.jira.plugin...
]
Geoffrey De Smet commented on JBRULES-2688:
-------------------------------------------
org.drools.ide.common.server.rules.ClassWalker has non a jboss inc copyright (but is asl
licenced), but we don't use the class, so I think we can safely remove
Some files have the license headers twice
-----------------------------------------
Key: JBRULES-2688
URL: https://jira.jboss.org/browse/JBRULES-2688
Project: Drools
Issue Type: Task
Security Level: Public(Everyone can see)
Components: All
Affects Versions: 5.1.0.FINAL
Reporter: Geoffrey De Smet
Assignee: Geoffrey De Smet
Priority: Trivial
Fix For: FUTURE
Several files have the license header twice, for example:
/home/ge0ffrey/projects/jboss/drools/drools-guvnor/src/main/java/org/drools/guvnor/server/repository/RulesRepositoryManager.java
The reason is that the original file already had a license header, but not on the correct
position (after the package statement instead of before it).
/**
* Copyright 2010 JBoss Inc
*
...
*/
package org.drools.guvnor.server.repository;
/*
* Copyright 2005 JBoss Inc
*
...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:27 p.m.
New subject: [JBoss JIRA] Issue Comment Edited: (JBRULES-2688) Some files have the license headers twice
[
https://jira.jboss.org/browse/JBRULES-2688?page=com.atlassian.jira.plugin...
]
Geoffrey De Smet edited comment on JBRULES-2688 at 9/6/10 1:27 PM:
-------------------------------------------------------------------
should be easy to fix with a regex replace in all files
;\s+/\*\n \* Copyright [^/]+//www.apache.org/licenses/LICENSE-2.0[^/]+\*/
was (Author: ge0ffrey):
should be easy to fix with a regex replace in all files
;\s+/\*\n \* Copyright [^/]+\*/ *\n
Some files have the license headers twice
-----------------------------------------
Key: JBRULES-2688
URL: https://jira.jboss.org/browse/JBRULES-2688
Project: Drools
Issue Type: Task
Security Level: Public(Everyone can see)
Components: All
Affects Versions: 5.1.0.FINAL
Reporter: Geoffrey De Smet
Assignee: Geoffrey De Smet
Priority: Trivial
Fix For: FUTURE
Several files have the license header twice, for example:
/home/ge0ffrey/projects/jboss/drools/drools-guvnor/src/main/java/org/drools/guvnor/server/repository/RulesRepositoryManager.java
The reason is that the original file already had a license header, but not on the correct
position (after the package statement instead of before it).
/**
* Copyright 2010 JBoss Inc
*
...
*/
package org.drools.guvnor.server.repository;
/*
* Copyright 2005 JBoss Inc
*
...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:31 p.m.
New subject: [JBoss JIRA] Issue Comment Edited: (JBRULES-2688) Some files have the license headers twice
[
https://jira.jboss.org/browse/JBRULES-2688?page=com.atlassian.jira.plugin...
]
Geoffrey De Smet edited comment on JBRULES-2688 at 9/6/10 1:29 PM:
-------------------------------------------------------------------
with a regex find in all files you can find many suspects easily
;\s+/\*\n \* Copyright [^/]+//www.apache.org/licenses/LICENSE-2.0[^/]+\*/
The problem is some of those file have twice, but others have it only once, but after the
package statement (those should be moved above the package statement
was (Author: ge0ffrey):
should be easy to fix with a regex replace in all files
;\s+/\*\n \* Copyright [^/]+//www.apache.org/licenses/LICENSE-2.0[^/]+\*/
Some files have the license headers twice
-----------------------------------------
Key: JBRULES-2688
URL: https://jira.jboss.org/browse/JBRULES-2688
Project: Drools
Issue Type: Task
Security Level: Public(Everyone can see)
Components: All
Affects Versions: 5.1.0.FINAL
Reporter: Geoffrey De Smet
Assignee: Geoffrey De Smet
Priority: Trivial
Fix For: FUTURE
Several files have the license header twice, for example:
/home/ge0ffrey/projects/jboss/drools/drools-guvnor/src/main/java/org/drools/guvnor/server/repository/RulesRepositoryManager.java
The reason is that the original file already had a license header, but not on the correct
position (after the package statement instead of before it).
/**
* Copyright 2010 JBoss Inc
*
...
*/
package org.drools.guvnor.server.repository;
/*
* Copyright 2005 JBoss Inc
*
...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:33 p.m.
New subject: [JBoss JIRA] Assigned: (JBRULES-2688) Some files have the license headers twice
[
https://jira.jboss.org/browse/JBRULES-2688?page=com.atlassian.jira.plugin...
]
Geoffrey De Smet reassigned JBRULES-2688:
-----------------------------------------
Assignee: Toni Rikkola (was: Geoffrey De Smet)
Fixed a bunch already, but looks like there are about 502 left (less than half has double
license headers I believe).
Some files have the license headers twice
-----------------------------------------
Key: JBRULES-2688
URL: https://jira.jboss.org/browse/JBRULES-2688
Project: Drools
Issue Type: Task
Security Level: Public(Everyone can see)
Components: All
Affects Versions: 5.1.0.FINAL
Reporter: Geoffrey De Smet
Assignee: Toni Rikkola
Priority: Trivial
Fix For: FUTURE
Several files have the license header twice, for example:
/home/ge0ffrey/projects/jboss/drools/drools-guvnor/src/main/java/org/drools/guvnor/server/repository/RulesRepositoryManager.java
The reason is that the original file already had a license header, but not on the correct
position (after the package statement instead of before it).
/**
* Copyright 2010 JBoss Inc
*
...
*/
package org.drools.guvnor.server.repository;
/*
* Copyright 2005 JBoss Inc
*
...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:17 a.m.
New subject: [JBoss JIRA] Issue Comment Edited: (JBRULES-2688) Some files have the license headers twice
[
https://issues.jboss.org/browse/JBRULES-2688?page=com.atlassian.jira.plug...
]
Geoffrey De Smet edited comment on JBRULES-2688 at 1/18/11 10:15 AM:
---------------------------------------------------------------------
with a regex find in all files you can find many suspects easily (note that you need to
edit this comment to copy paste the regex because jira changes it during rendering):
;\s+/\*\n \* Copyright [^/]+//www.apache.org/licenses/LICENSE-2.0[^/]+\*/
The problem is some of those file have twice, but others have it only once, but after the
package statement (those should be moved above the package statement
was (Author: ge0ffrey):
with a regex find in all files you can find many suspects easily
;\s+/\*\n \* Copyright [^/]+//www.apache.org/licenses/LICENSE-2.0[^/]+\*/
The problem is some of those file have twice, but others have it only once, but after the
package statement (those should be moved above the package statement
Some files have the license headers twice
-----------------------------------------
Key: JBRULES-2688
URL: https://issues.jboss.org/browse/JBRULES-2688
Project: Drools
Issue Type: Task
Security Level: Public(Everyone can see)
Components: All
Affects Versions: 5.1.0.FINAL
Reporter: Geoffrey De Smet
Assignee: Toni Rikkola
Priority: Trivial
Fix For: FUTURE
Several files have the license header twice, for example:
/home/ge0ffrey/projects/jboss/drools/drools-guvnor/src/main/java/org/drools/guvnor/server/repository/RulesRepositoryManager.java
The reason is that the original file already had a license header, but not on the correct
position (after the package statement instead of before it).
/**
* Copyright 2010 JBoss Inc
*
...
*/
package org.drools.guvnor.server.repository;
/*
* Copyright 2005 JBoss Inc
*
...
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:27 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2688) Some files have the license headers twice
[
https://issues.jboss.org/browse/JBRULES-2688?page=com.atlassian.jira.plug...
]
Geoffrey De Smet commented on JBRULES-2688:
-------------------------------------------
Replace this regex:
/\*\*\n \* Copyright 2010 JBoss Inc[\w\n\*/:\-\.\s\,\(\)\"\;]+? \*/\s+package
([\w\.]+);\s+(/\*\*?\n \* Copyright (\d+) JBoss Inc[\w\n\*/:\-\.\s\,\(\)\"\;]+? \*/)
With this:
$2\n\npackage $1;
Some files have the license headers twice
-----------------------------------------
Key: JBRULES-2688
URL: https://issues.jboss.org/browse/JBRULES-2688
Project: Drools
Issue Type: Task
Security Level: Public(Everyone can see)
Components: All
Affects Versions: 5.1.0.FINAL
Reporter: Geoffrey De Smet
Assignee: Toni Rikkola
Priority: Trivial
Fix For: FUTURE
Several files have the license header twice, for example:
/home/ge0ffrey/projects/jboss/drools/drools-guvnor/src/main/java/org/drools/guvnor/server/repository/RulesRepositoryManager.java
The reason is that the original file already had a license header, but not on the correct
position (after the package statement instead of before it).
/**
* Copyright 2010 JBoss Inc
*
...
*/
package org.drools.guvnor.server.repository;
/*
* Copyright 2005 JBoss Inc
*
...
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:24 a.m.
New subject: [JBoss JIRA] Resolved: (JBRULES-2688) Some files have the license headers twice
[
https://issues.jboss.org/browse/JBRULES-2688?page=com.atlassian.jira.plug...
]
Geoffrey De Smet resolved JBRULES-2688.
---------------------------------------
Assignee: Geoffrey De Smet (was: Toni Rikkola)
Fix Version/s: 5.2.0.M2
(was: FUTURE)
Resolution: Done
Done
Some files have the license headers twice
-----------------------------------------
Key: JBRULES-2688
URL: https://issues.jboss.org/browse/JBRULES-2688
Project: Drools
Issue Type: Task
Security Level: Public(Everyone can see)
Components: All
Affects Versions: 5.1.0.FINAL
Reporter: Geoffrey De Smet
Assignee: Geoffrey De Smet
Priority: Trivial
Fix For: 5.2.0.M2
Several files have the license header twice, for example:
/home/ge0ffrey/projects/jboss/drools/drools-guvnor/src/main/java/org/drools/guvnor/server/repository/RulesRepositoryManager.java
The reason is that the original file already had a license header, but not on the correct
position (after the package statement instead of before it).
/**
* Copyright 2010 JBoss Inc
*
...
*/
package org.drools.guvnor.server.repository;
/*
* Copyright 2005 JBoss Inc
*
...
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5042
days inactive
5176
days old
9 comments
1 participants
participants (1)
-
Geoffrey De Smet (JIRA)