11:07 a.m.
Brian Stansberry created AS7-3617:
-------------------------------------
Summary: Determine use case for ServerEnvironment.install()
Key: AS7-3617
URL: https://issues.jboss.org/browse/AS7-3617
Project: Application Server 7
Issue Type: Task
Components: Domain Management
Reporter: Brian Stansberry
Assignee: Brian Stansberry
Fix For: 7.1.1.Final
ServerEnvironment.install() is package protected and is called from
ApplicationServerService.start(). See if there is any good reason for this; it seems like
this could just be done in the ServerEnvironment constructor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:34 a.m.
[
https://issues.jboss.org/browse/AS7-3617?page=com.atlassian.jira.plugin.s...
]
Emanuel Muckenhuber commented on AS7-3617:
------------------------------------------
I recently fixed the usage of ServerEnvironment in the ServerStartTask, perhaps the
original use-case was the reason for the install() method.
Determine use case for ServerEnvironment.install()
--------------------------------------------------
Key: AS7-3617
URL: https://issues.jboss.org/browse/AS7-3617
Project: Application Server 7
Issue Type: Task
Components: Domain Management
Reporter: Brian Stansberry
Assignee: Brian Stansberry
Fix For: 7.1.1.Final
ServerEnvironment.install() is package protected and is called from
ApplicationServerService.start(). See if there is any good reason for this; it seems like
this could just be done in the ServerEnvironment constructor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:50 p.m.
[
https://issues.jboss.org/browse/AS7-3617?page=com.atlassian.jira.plugin.s...
]
Brian Stansberry updated AS7-3617:
----------------------------------
Fix Version/s: 7.2.0.Alpha1
(was: 7.1.1.Final)
Priority: Minor (was: Major)
Moving to 7.2 as this is a nit.
Determine use case for ServerEnvironment.install()
--------------------------------------------------
Key: AS7-3617
URL: https://issues.jboss.org/browse/AS7-3617
Project: Application Server 7
Issue Type: Task
Components: Domain Management
Reporter: Brian Stansberry
Assignee: Brian Stansberry
Priority: Minor
Fix For: 7.2.0.Alpha1
ServerEnvironment.install() is package protected and is called from
ApplicationServerService.start(). See if there is any good reason for this; it seems like
this could just be done in the ServerEnvironment constructor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:28 p.m.
[
https://issues.jboss.org/browse/AS7-3617?page=com.atlassian.jira.plugin.s...
]
Brian Stansberry resolved AS7-3617.
-----------------------------------
Fix Version/s: 7.1.1.Final
(was: 7.2.0.Alpha1)
Resolution: Done
It's not done in the ServerEnvironment constructor because in a managed domain server
that constructor is called in the HC process and the object is serialized to the server
process. Calling it from ApplicationServerService allows the setting of system properties
to be deferred until the object is in the correct JVM.
Determine use case for ServerEnvironment.install()
--------------------------------------------------
Key: AS7-3617
URL: https://issues.jboss.org/browse/AS7-3617
Project: Application Server 7
Issue Type: Task
Components: Domain Management
Reporter: Brian Stansberry
Assignee: Brian Stansberry
Priority: Minor
Fix For: 7.1.1.Final
ServerEnvironment.install() is package protected and is called from
ApplicationServerService.start(). See if there is any good reason for this; it seems like
this could just be done in the ServerEnvironment constructor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:40 p.m.
[
https://issues.jboss.org/browse/AS7-3617?page=com.atlassian.jira.plugin.s...
]
Brian Stansberry updated AS7-3617:
----------------------------------
Fix Version/s: 7.2.0.Alpha1
(was: 7.1.1.Final)
Determine use case for ServerEnvironment.install()
--------------------------------------------------
Key: AS7-3617
URL: https://issues.jboss.org/browse/AS7-3617
Project: Application Server 7
Issue Type: Task
Components: Domain Management
Reporter: Brian Stansberry
Assignee: Brian Stansberry
Priority: Minor
Fix For: 7.2.0.Alpha1
ServerEnvironment.install() is package protected and is called from
ApplicationServerService.start(). See if there is any good reason for this; it seems like
this could just be done in the ServerEnvironment constructor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:40 p.m.
[
https://issues.jboss.org/browse/AS7-3617?page=com.atlassian.jira.plugin.s...
]
Brian Stansberry reopened AS7-3617:
-----------------------------------
Reopening, as my last comment was wrong. In a managed domain the ServerEnvironment
constructor is still called in the server vm, in ServerStartTask.run()
Determine use case for ServerEnvironment.install()
--------------------------------------------------
Key: AS7-3617
URL: https://issues.jboss.org/browse/AS7-3617
Project: Application Server 7
Issue Type: Task
Components: Domain Management
Reporter: Brian Stansberry
Assignee: Brian Stansberry
Priority: Minor
Fix For: 7.1.1.Final
ServerEnvironment.install() is package protected and is called from
ApplicationServerService.start(). See if there is any good reason for this; it seems like
this could just be done in the ServerEnvironment constructor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4691
days inactive
4724
days old
5 comments
2 participants
participants (2)
-
Brian Stansberry (JIRA) -
Emanuel Muckenhuber (JIRA)