[
https://issues.redhat.com/browse/WFLY-13779?page=com.atlassian.jira.plugi...
]
Jeff Mesnil commented on WFLY-13779:
------------------------------------
I have thought about this more.
The main thing to consider is that with MicroProfile Config, the config sources are added
to the Config the first time a class loader calls ConfigProviderResolver.getConfig().
Any addition/removal of a config-source provided by the subsystem will not modify existing
Config associated to a ClassLoader.
In case of deployments, that means that the set of ConfigSources is determined when the
deployment is deployed.
For WildFly subsystems, that means that the set of ConfigSources is determined when the
use MicroProfile Config the first time. Any subsequent modifications to the
microprofile-config-smallrye substem will not impact these Configs.
So I think we need to make 2 changes:
* in the WildFly codebase, flag the config-source and config-source-provider :remove
operations with RESTART-ALL-SERVICES to properly notify that if these resources are
removed, server must be reloaded
* in your test fixture, after removing a config-source-provider, you'll have to reload
the server to get it in the proper state.
MicroProfile Metrics tests started to fail since changes in
ConfigSource
------------------------------------------------------------------------
Key: WFLY-13779
URL:
https://issues.redhat.com/browse/WFLY-13779
Project: WildFly
Issue Type: Bug
Components: MP Metrics
Reporter: Sultan Zhantemirov
Assignee: Jeff Mesnil
Priority: Major
WildFly build: 21.0.0.Beta1-SNAPSHOT
Java: oracle-java-11
A several failures appeared in our small standalone test suite [1] for MicroProfile on
WF/EAP. To be more specific, a few failures in MP Metrics that have one common cause:
{noformat}
java.lang.RuntimeException: config.source.properties.path property not defined
{noformat}
caused by line [2].
I have a reason to believe that this PR [3] could be reason of these failures. What
should be done in this case?
Thank you.
[1] -
https://github.com/jboss-eap-qe/eap-microprofile-test-suite/tree/master/m...
[2] -
https://github.com/jboss-eap-qe/eap-microprofile-test-suite/blob/8b726042...
[3] -
https://github.com/wildfly/wildfly/pull/13247
--
This message was sent by Atlassian Jira
(v7.13.8#713008)