4:57 p.m.
Stuart Douglas created AS7-4687:
-----------------------------------
Summary: REview the use of InheritableThreadLocal in
SecurityContextAssociation
Key: AS7-4687
URL: https://issues.jboss.org/browse/AS7-4687
Project: Application Server 7
Issue Type: Task
Reporter: Stuart Douglas
There have been problems with the SecurityContext leaking into thread pools, due to the
use of the InheritableThreadLocal.
Do we still need this to be an InheritableThreadLocal? If so, is there anything we can do
to stop it from leaking into thread pools?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:57 p.m.
New subject: [JBoss JIRA] (AS7-4687) Review the use of InheritableThreadLocal in SecurityContextAssociation
[
https://issues.jboss.org/browse/AS7-4687?page=com.atlassian.jira.plugin.s...
]
Stuart Douglas updated AS7-4687:
--------------------------------
Summary: Review the use of InheritableThreadLocal in SecurityContextAssociation
(was: REview the use of InheritableThreadLocal in SecurityContextAssociation)
Assignee: Anil Saldhana
Component/s: Security
Review the use of InheritableThreadLocal in
SecurityContextAssociation
----------------------------------------------------------------------
Key: AS7-4687
URL: https://issues.jboss.org/browse/AS7-4687
Project: Application Server 7
Issue Type: Task
Components: Security
Reporter: Stuart Douglas
Assignee: Anil Saldhana
There have been problems with the SecurityContext leaking into thread pools, due to the
use of the InheritableThreadLocal.
Do we still need this to be an InheritableThreadLocal? If so, is there anything we can do
to stop it from leaking into thread pools?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:09 p.m.
New subject: [JBoss JIRA] (AS7-4687) Review the use of InheritableThreadLocal in SecurityContextAssociation
[
https://issues.jboss.org/browse/AS7-4687?page=com.atlassian.jira.plugin.s...
]
Anil Saldhana reassigned AS7-4687:
----------------------------------
Assignee: Stefan Guilhen (was: Anil Saldhana)
Stefan, we should remove the usage of InheritableThreadLocal in
SecurityContextAssociation.
Review the use of InheritableThreadLocal in
SecurityContextAssociation
----------------------------------------------------------------------
Key: AS7-4687
URL: https://issues.jboss.org/browse/AS7-4687
Project: Application Server 7
Issue Type: Task
Components: Security
Reporter: Stuart Douglas
Assignee: Stefan Guilhen
There have been problems with the SecurityContext leaking into thread pools, due to the
use of the InheritableThreadLocal.
Do we still need this to be an InheritableThreadLocal? If so, is there anything we can do
to stop it from leaking into thread pools?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:45 p.m.
New subject: [JBoss JIRA] (AS7-4687) Review the use of InheritableThreadLocal in SecurityContextAssociation
[
https://issues.jboss.org/browse/AS7-4687?page=com.atlassian.jira.plugin.s...
]
Stuart Douglas commented on AS7-4687:
-------------------------------------
There is a config option to change it to a ThreadLocal, but it is disabled by default.
Just changing the default would probably be sufficient.
I am not sure what the broader impact of this change would be though.
Review the use of InheritableThreadLocal in
SecurityContextAssociation
----------------------------------------------------------------------
Key: AS7-4687
URL: https://issues.jboss.org/browse/AS7-4687
Project: Application Server 7
Issue Type: Task
Components: Security
Reporter: Stuart Douglas
Assignee: Stefan Guilhen
There have been problems with the SecurityContext leaking into thread pools, due to the
use of the InheritableThreadLocal.
Do we still need this to be an InheritableThreadLocal? If so, is there anything we can do
to stop it from leaking into thread pools?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:07 p.m.
New subject: [JBoss JIRA] (AS7-4687) Review the use of InheritableThreadLocal in SecurityContextAssociation
[
https://issues.jboss.org/browse/AS7-4687?page=com.atlassian.jira.plugin.s...
]
Stefan Guilhen commented on AS7-4687:
-------------------------------------
Stuart is right. There is a system property that can be used to enable ThreadLocal usage
instead of InheritableThreadLocal.
We can set the org.jboss.security.context.ThreadLocal sys property to true in
standalone.xml and see how things go. If the AS needs this property to be always true we
can set it in the security subsystem when booting the AS.
Review the use of InheritableThreadLocal in
SecurityContextAssociation
----------------------------------------------------------------------
Key: AS7-4687
URL: https://issues.jboss.org/browse/AS7-4687
Project: Application Server 7
Issue Type: Task
Components: Security
Reporter: Stuart Douglas
Assignee: Stefan Guilhen
There have been problems with the SecurityContext leaking into thread pools, due to the
use of the InheritableThreadLocal.
Do we still need this to be an InheritableThreadLocal? If so, is there anything we can do
to stop it from leaking into thread pools?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:04 a.m.
New subject: [JBoss JIRA] (AS7-4687) Review the use of InheritableThreadLocal in SecurityContextAssociation
[
https://issues.jboss.org/browse/AS7-4687?page=com.atlassian.jira.plugin.s...
]
Darran Lofthouse commented on AS7-4687:
---------------------------------------
Why don't we flip the default ThreadLocal used to be non inheritable? Rather than
relying on a system property being set - at the moment I have not seen a valid reason for
using an InheritedThreadLocal and this is not the first time it has caused us problems.
Review the use of InheritableThreadLocal in
SecurityContextAssociation
----------------------------------------------------------------------
Key: AS7-4687
URL: https://issues.jboss.org/browse/AS7-4687
Project: Application Server 7
Issue Type: Task
Components: Security
Reporter: Stuart Douglas
Assignee: Stefan Guilhen
There have been problems with the SecurityContext leaking into thread pools, due to the
use of the InheritableThreadLocal.
Do we still need this to be an InheritableThreadLocal? If so, is there anything we can do
to stop it from leaking into thread pools?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:42 p.m.
New subject: [JBoss JIRA] (AS7-4687) Review the use of InheritableThreadLocal in SecurityContextAssociation
[
https://issues.jboss.org/browse/AS7-4687?page=com.atlassian.jira.plugin.s...
]
Stefan Guilhen closed AS7-4687.
-------------------------------
Fix Version/s: 7.1.2.Final (EAP)
Resolution: Done
Stuart has changed the security subsystem to so that ThreadLocal is used by default.
Review the use of InheritableThreadLocal in
SecurityContextAssociation
----------------------------------------------------------------------
Key: AS7-4687
URL: https://issues.jboss.org/browse/AS7-4687
Project: Application Server 7
Issue Type: Task
Components: Security
Reporter: Stuart Douglas
Assignee: Stefan Guilhen
Fix For: 7.1.2.Final (EAP)
There have been problems with the SecurityContext leaking into thread pools, due to the
use of the InheritableThreadLocal.
Do we still need this to be an InheritableThreadLocal? If so, is there anything we can do
to stop it from leaking into thread pools?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4630
days inactive
4637
days old
6 comments
4 participants
participants (4)
-
Anil Saldhana (JIRA) -
Darran Lofthouse (JIRA)
-
Stefan Guilhen (JIRA)
-
Stuart Douglas (JIRA)