November 2008 - jboss-jira - Jboss List Archives

[JBoss JIRA] Created: (JBPORTAL-1708) Identity APIs should invalidate cache on update/change of role membership

by Andrew Oliver (JIRA)

Identity APIs should invalidate cache on update/change of role membership ------------------------------------------------------------------------- Key: JBPORTAL-1708 URL: http://jira.jboss.com/jira/browse/JBPORTAL-1708 Project: JBoss Portal Issue Type: Bug Security Level: Public (Everyone can see) Components: Portal Identity Affects Versions: 2.6.1 Final Reporter: Andrew Oliver Consider this code: String username = request.getParameter("username"); User user= usermodule.findUserByUserName(username); System.err.println("user was equal to "+(user == null ? "null" : user.getUserName())); Role role = rolemodule.findRoleByName("approved"); Set users = new HashSet(); users.add(user); membership.assignUsers(role, users); And this code: Role roleApproved = rolemodule.findRoleByName("approved"); Set usersApproved = membership.getUsers(roleApproved); With the default Hibernate settings for identity in server\default\deploy\jboss-portal.sar\conf\hibernate\user\hibernate.cfg.xml: <property name="cache.use_second_level_cache">true</property> <property name="cache.use_query_cache">true</property> The second bit of code doesn't see changes by the first bit of code until the portal is restarted (it seems). Switching these to false solves the problem. It is likely that this is due to the HibernateMembershipModuleImpl and the <set name="roles" table="jbp_role_membership" lazy="false" inverse="false" cascade="none" sort="unsorted"> <cache usage="read-write"/> <key column="jbp_uid"/> <many-to-many class="org.jboss.portal.identity.db.HibernateRoleImpl" column="jbp_rid" outer-join="true"/> </set> which specifies a cached collection and in http://viewvc.jboss.org/cgi-bin/viewvc.cgi/portal/branches/JBoss_Portal_B... public void assignRoles(User user, Set roles) throws IdentityException { //throw new UnsupportedOperationException("Not yet implemented"); if (!(user instanceof HibernateUserImpl)) { throw new IllegalArgumentException("User is not a HibernateUserImpl user"); } // We make a defensive copy with unwrapped maps and update with a new set Set copy = new HashSet(); for (Iterator i = roles.iterator(); i.hasNext();) { Object o = i.next(); if (o instanceof HibernateRoleImpl) { copy.add(o); } else { throw new IllegalArgumentException("Only HibernateRoleImpl roles can be accepted"); } } // Assign new roles HibernateUserImpl ui = (HibernateUserImpl)user; ui.setRoles(copy); } The defensive copy which avoids the hibernate collection probably prevents triggering of the cache invalidation logic in the many-many relationship (not 100% sure that this is how hibernate works for collection caching but it seems logical). The hibernate membership module's usage of hibernate is a bit odd and probably needs review anyhow. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 6 months

3
6
0 / 0

[JBoss JIRA] Created: (JBPORTAL-1689) Maven documentation

by Julien Viet (JIRA)

Maven documentation ------------------- Key: JBPORTAL-1689 URL: http://jira.jboss.com/jira/browse/JBPORTAL-1689 Project: JBoss Portal Issue Type: Sub-task Security Level: Public (Everyone can see) Reporter: Julien Viet -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 6 months

4
11
0 / 0

[JBoss JIRA] Created: (JBPORTAL-1493) Separate internal configuration state (DB / LDAP) from the exposed meta data of the property

by Julien Viet (JIRA)

Separate internal configuration state (DB / LDAP) from the exposed meta data of the property -------------------------------------------------------------------------------------------- Key: JBPORTAL-1493 URL: http://jira.jboss.com/jira/browse/JBPORTAL-1493 Project: JBoss Portal Issue Type: Task Security Level: Public (Everyone can see) Components: Portal Identity Reporter: Julien Viet Assigned To: Boleslaw Dawidowicz Fix For: 2.8 Final For example : public String getName(); public String getType(); public String getAccessMode(); public String getUsage(); public LocalizedString getDisplayName(); public LocalizedString getDescription(); is what client of the API will care about. public String getMappingDBType(); public String getMappingLDAPValue(); public String getMappingDBValue(); public boolean isMappedDB(); public boolean isMappedLDAP(); is an internal implementation detail that the client should not know about, as it is part of the configuration of the property, not the usage. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 6 months

2
1
0 / 0

[JBoss JIRA] Created: (JBPORTAL-1494) Add a boolean meta data that says if a property can be resetted

by Julien Viet (JIRA)

Add a boolean meta data that says if a property can be resetted --------------------------------------------------------------- Key: JBPORTAL-1494 URL: http://jira.jboss.com/jira/browse/JBPORTAL-1494 Project: JBoss Portal Issue Type: Task Security Level: Public (Everyone can see) Reporter: Julien Viet Assigned To: Boleslaw Dawidowicz Fix For: 2.8 Final on PropertyInfo we need boolean isResettable() { } which returns true if the property can be reverted to the initial value -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 6 months

2
2
0 / 0

[JBoss JIRA] Created: (JBPORTAL-1343) Create an Ant task to execute a TestDriver

by Julien Viet (JIRA)

Create an Ant task to execute a TestDriver ------------------------------------------ Key: JBPORTAL-1343 URL: http://jira.jboss.com/jira/browse/JBPORTAL-1343 Project: JBoss Portal Issue Type: Task Security Level: Public (Everyone can see) Reporter: Julien Viet Fix For: 2.8 Final An org.jboss.portal.common.test.driver.TestDriver is executed in Ant though the usage of the org.jboss.portal.common.test.junit.JUnitAdapter which adaps the TestDriver protocol to junit. It has several limitations : - the way to pass parameters to the test driver is convoluted and basically an hack (that works) - it is not possible to filter the set of tests returned by the TestDriver easily which force many times to create subclasses in order to execute each test separately -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 6 months

2
5
0 / 0

[JBoss JIRA] Created: (JBMICROCONT-133) Figure out how to generically do the equivalent of setAccessible() for the javassist constructed reflection objects

by Adrian Brock (JIRA)

Figure out how to generically do the equivalent of setAccessible() for the javassist constructed reflection objects ------------------------------------------------------------------------------------------------------------------- Key: JBMICROCONT-133 URL: http://jira.jboss.com/jira/browse/JBMICROCONT-133 Project: JBoss MicroContainer Issue Type: Task Affects Versions: JBossMC_2_0_0 Beta Reporter: Adrian Brock See the associated forum discussion and the TODO in JavassistReflectionFactory -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 6 months

5
14
0 / 0

[JBoss JIRA] Created: (JBMICROCONT-127) ClassInfo tests testing annotation attribute values

by Adrian Brock (JIRA)

ClassInfo tests testing annotation attribute values --------------------------------------------------- Key: JBMICROCONT-127 URL: http://jira.jboss.com/jira/browse/JBMICROCONT-127 Project: JBoss MicroContainer Issue Type: Task Components: BeanInfo Affects Versions: JBossMC_2_0_0 Beta Reporter: Adrian Brock Need to write some tests for the annotation attributes in the main ClassInfo tests. Currently, it only tests that it got the correct annotations, not that those annotations have the correct values. Kabir does have some other basic "standup tests" for this, but they are not excercising all the edge cases. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 6 months

6
9
0 / 0

[JBoss JIRA] Created: (JBMICROCONT-118) Fix the introspection assumption in ClassInfo

by Adrian Brock (JIRA)

Fix the introspection assumption in ClassInfo --------------------------------------------- Key: JBMICROCONT-118 URL: http://jira.jboss.com/jira/browse/JBMICROCONT-118 Project: JBoss MicroContainer Issue Type: Task Components: BeanInfo Affects Versions: JBossMC_2_0_0 Beta Reporter: Adrian Brock Priority: Minor Fix For: JBossMC_2_0_0_CR1 Although the javassist version of the ClassInfo works fine, there are still some places in the base ClassInfoImpl that assume introspection (i.e. java.lang.reflect objects). The javassist impl works around these issues by subclassing. Additionally, the deprecated ClassInfo.getType() needs removing. This will require understanding where it is currently used and fixing it (I think it is mainly related to determining the classloader?) Moving this method and its dependencies to the ReflectClassInfoImpl Whether we actually remove the deprecated method is another issue since it is useful to temporarily fix problems (in future) where we don't provide an equivalent in the ClassInfo api. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 6 months

6
10
0 / 0

[JBoss JIRA] Created: (JBREFLECT-39) Cryptic Error Message

by Adrian Brock (JIRA)

Cryptic Error Message --------------------- Key: JBREFLECT-39 URL: https://jira.jboss.org/jira/browse/JBREFLECT-39 Project: JBoss Reflection Issue Type: Task Components: ClassInfo Affects Versions: JBossReflection.2.0.0.CR1 Reporter: Adrian Brock This blog entry http://merike.pri.ee/mind/2008/10/15/cryptic-jboss-error/ shows there is some issue with how parameter annotations work across JDKs. Although I think GCJ is actually wrong if you read the javadoc http://java.sun.com/j2se/1.5.0/docs/api/java/lang/reflect/Method.html#get... since the parameter annotations array should be the same length as the number of parameters we can certainly give a better error message than an ArrayIndex error. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 6 months

3
8
0 / 0

[JBoss JIRA] Created: (JBAS-5903) Add clustering dependencies to clustered EJB3 beans

by Brian Stansberry (JIRA)

Add clustering dependencies to clustered EJB3 beans --------------------------------------------------- Key: JBAS-5903 URL: https://jira.jboss.org/jira/browse/JBAS-5903 Project: JBoss Application Server Issue Type: Sub-task Security Level: Public (Everyone can see) Components: Clustering, EJB3 Reporter: Brian Stansberry Assignee: Brian Stansberry Fix For: JBossAS-5.0.0.CR2 See parent task. The work on the parent task already handles EJB3 as well, if the ejb jar includes any xml deployment descriptors. Need to deal with the case where the jar has no xml; see forum thread for details. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 6 months

2
10
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-jira November 2008